From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F08CCC2BB1D for ; Fri, 13 Mar 2020 03:03:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AE10720716 for ; Fri, 13 Mar 2020 03:03:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ugq8qbdw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE10720716 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5CD846B0005; Thu, 12 Mar 2020 23:03:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 556596B0006; Thu, 12 Mar 2020 23:03:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 444986B0007; Thu, 12 Mar 2020 23:03:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0252.hostedemail.com [216.40.44.252]) by kanga.kvack.org (Postfix) with ESMTP id 263396B0005 for ; Thu, 12 Mar 2020 23:03:02 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id CADF4181AEF3E for ; Fri, 13 Mar 2020 03:03:01 +0000 (UTC) X-FDA: 76588842162.15.dog24_549fe611e421f X-HE-Tag: dog24_549fe611e421f X-Filterd-Recvd-Size: 2247 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Fri, 13 Mar 2020 03:03:01 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 569AD206E2; Fri, 13 Mar 2020 03:03:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584068580; bh=MfD/el5E9LurZZaSPewSeycv8wSAS3R57zWeVs/eDn0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ugq8qbdwRlDRYUE6VABOfQoKJks/BvDS0ZkVWlcSotdEyl45bnMZYGGR3reqsLd2K JHMz8OZMqnVoVhqLQQhKH8duhDQ+/D953aeF+bYMCVtpNZsHvTrhFFrVPZA2uzcO1O QuLTbMLJhLKH0/gThuELJJu+AOsf/e0BA5KUj1ag= Date: Thu, 12 Mar 2020 20:02:59 -0700 From: Andrew Morton To: Jaewon Kim Cc: willy@infradead.org, walken@google.com, bp@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, jaewon31.kim@gmail.com Subject: Re: [PATCH v2 1/2] mmap: remove inline of vm_unmapped_area Message-Id: <20200312200259.7b79b38341bde97609fde99a@linux-foundation.org> In-Reply-To: <20200313011420.15995-2-jaewon31.kim@samsung.com> References: <20200313011420.15995-1-jaewon31.kim@samsung.com> <20200313011420.15995-2-jaewon31.kim@samsung.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 13 Mar 2020 10:14:19 +0900 Jaewon Kim wrote: > In prepration for next patch remove inline of vm_unmapped_area and move > code to mmap.c. There is no logical change. > > Also remove unmapped_area[_topdown] out of mm.h, there is no code > calling to them. > Patches seem reasonable. > -extern unsigned long unmapped_area(struct vm_unmapped_area_info *info); > -extern unsigned long unmapped_area_topdown(struct vm_unmapped_area_info *info); I believe these can now be made static to mmap.c