From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECAAAC1975A for ; Thu, 12 Mar 2020 13:34:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B14A8206E7 for ; Thu, 12 Mar 2020 13:34:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="ot5tc0+I" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B14A8206E7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 608706B0008; Thu, 12 Mar 2020 09:34:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B8C46B000A; Thu, 12 Mar 2020 09:34:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CE746B000C; Thu, 12 Mar 2020 09:34:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0062.hostedemail.com [216.40.44.62]) by kanga.kvack.org (Postfix) with ESMTP id 326966B0008 for ; Thu, 12 Mar 2020 09:34:21 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 066028248076 for ; Thu, 12 Mar 2020 13:34:21 +0000 (UTC) X-FDA: 76586804280.22.dad67_8d004d616222 X-HE-Tag: dad67_8d004d616222 X-Filterd-Recvd-Size: 3250 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Thu, 12 Mar 2020 13:34:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Q0cv74t7l2uuMQ2H/NQkK+DglLbOkOKLtyHL354NblA=; b=ot5tc0+IvUfEcgEfLzzsCgLL+/ 1ug77ff+cDabhhKK38eBX7KVrLjkgIrnASJc8Q6cGJzEewM+2MDWMl2An8GM0rX0oEPHuN8tu3Nvk LODWevICsNOuFnkn4pgxuK8h1rnsPookChAYkWHfMID49MJo+2LpDz/EYxB4WszXlRp+UVi//oSJW z8g7+WvFUT61/E/uqFyri0WOV0spT4cZq+QQ1wu6u3CHCPqTwVBMIX0lOr5DiLbNJdUV60R4YCupZ 5g96opD9LAn6AyjbcVY2tx/8QrnoE9hMp0IqfDo1ReVFTIiFCYvpti6q9QVXFBrMOJeDfcj7Lsj/W kbvNsebA==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCNyb-0006ED-0R; Thu, 12 Mar 2020 13:34:17 +0000 Date: Thu, 12 Mar 2020 06:34:16 -0700 From: Matthew Wilcox To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.com, akpm@linux-foundation.org, david@redhat.com, richard.weiyang@gmail.com Subject: Re: [PATCH v2] mm/sparse.c: Use kvmalloc_node/kvfree to alloc/free memmap for the classic sparse Message-ID: <20200312133416.GI22433@bombadil.infradead.org> References: <20200312130822.6589-1-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200312130822.6589-1-bhe@redhat.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 12, 2020 at 09:08:22PM +0800, Baoquan He wrote: > This change makes populate_section_memmap()/depopulate_section_memmap > much simpler. > > Suggested-by: Michal Hocko > Signed-off-by: Baoquan He > --- > v1->v2: > The old version only used __get_free_pages() to replace alloc_pages() > in populate_section_memmap(). > http://lkml.kernel.org/r/20200307084229.28251-8-bhe@redhat.com > > mm/sparse.c | 27 +++------------------------ > 1 file changed, 3 insertions(+), 24 deletions(-) > > diff --git a/mm/sparse.c b/mm/sparse.c > index bf6c00a28045..362018e82e22 100644 > --- a/mm/sparse.c > +++ b/mm/sparse.c > @@ -734,35 +734,14 @@ static void free_map_bootmem(struct page *memmap) > struct page * __meminit populate_section_memmap(unsigned long pfn, > unsigned long nr_pages, int nid, struct vmem_altmap *altmap) > { > - struct page *page, *ret; > - unsigned long memmap_size = sizeof(struct page) * PAGES_PER_SECTION; > - > - page = alloc_pages(GFP_KERNEL|__GFP_NOWARN, get_order(memmap_size)); > - if (page) > - goto got_map_page; > - > - ret = vmalloc(memmap_size); > - if (ret) > - goto got_map_ptr; > - > - return NULL; > -got_map_page: > - ret = (struct page *)pfn_to_kaddr(page_to_pfn(page)); > -got_map_ptr: > - > - return ret; > + return kvmalloc_node(sizeof(struct page) * PAGES_PER_SECTION, > + GFP_KERNEL|__GFP_NOWARN, nid); Use of NOWARN here is inappropriate, because there's no fallback. Also, I'd use array_size(sizeof(struct page), PAGES_PER_SECTION).