From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DC65C1975A for ; Thu, 12 Mar 2020 09:25:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 03FE12067C for ; Thu, 12 Mar 2020 09:25:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03FE12067C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 90DC66B000C; Thu, 12 Mar 2020 05:25:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8BEF06B000D; Thu, 12 Mar 2020 05:25:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B0096B000E; Thu, 12 Mar 2020 05:25:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0196.hostedemail.com [216.40.44.196]) by kanga.kvack.org (Postfix) with ESMTP id 6303E6B000C for ; Thu, 12 Mar 2020 05:25:35 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 1B4728248D7C for ; Thu, 12 Mar 2020 09:25:35 +0000 (UTC) X-FDA: 76586177430.18.badge63_139bc4ebc444c X-HE-Tag: badge63_139bc4ebc444c X-Filterd-Recvd-Size: 4695 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Thu, 12 Mar 2020 09:25:34 +0000 (UTC) Received: by mail-wm1-f67.google.com with SMTP id h83so1846804wmf.3 for ; Thu, 12 Mar 2020 02:25:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cMMKbXhN9eUImpsZTVHPnKioeTIq6eieLdWAKaUpf5Q=; b=mqcd8wBJ3/SCF11B4mxwtfeJ0kfH14aaUTpvdkr7T8j8Y2xLI2VcbkRG0FIfEbB8fl 9vXgVn0KJacyqHsj1QYcG4GsoAbLZI+GjNfw+xRyIoI/1LQE93BamoASArqDjGl5oNx9 uED+yhtFFj++Hoch4wSuTEQFgouCPLjkuO5jHnh+//gXVBvdPMZQzoXoPluDUPqYFzmG Xl/bsfIKSZb6bHibdrmikLqYWKPJo4/7klAz5n9fxKUOdFDdIAA08IgTKFp6XyjdvPbj ecUUd3lZ96jih3NusidKWHe6x0bnPt/eQgYMuyFiMKuw4AHvEToYVgZ/T55Th8KosMSR NUPg== X-Gm-Message-State: ANhLgQ1msKirYTmwonBudS8DAL7nL/zuW/zirD/mzpkzJ0xSdpyJhhYu HSHAtVuqqsyBXI/oOgXc5I0= X-Google-Smtp-Source: ADFU+vuonuF0fj4AX6GKv6FiF9ZC8rUyNxOFkSydg0YUX+Sx7UVQ+93RWd3J+LrP6b3rbzvpv1EAjw== X-Received: by 2002:a1c:56d5:: with SMTP id k204mr4046198wmb.13.1584005133477; Thu, 12 Mar 2020 02:25:33 -0700 (PDT) Received: from localhost (ip-37-188-253-35.eurotel.cz. [37.188.253.35]) by smtp.gmail.com with ESMTPSA id v10sm3832526wml.44.2020.03.12.02.25.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2020 02:25:32 -0700 (PDT) Date: Thu, 12 Mar 2020 10:25:31 +0100 From: Michal Hocko To: Ivan Teterevkov Cc: "corbet@lwn.net" , "akpm@linux-foundation.org" , "mchehab+samsung@kernel.org" , "tglx@linutronix.de" , "jpoimboe@redhat.com" , "pawan.kumar.gupta@linux.intel.com" , "jgross@suse.com" , "oneukum@suse.com" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" Subject: Re: [PATCH] mm/vmscan: add vm_swappiness configuration knobs Message-ID: <20200312092531.GU23944@dhcp22.suse.cz> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 11-03-20 17:45:58, Ivan Teterevkov wrote: > This patch adds a couple of knobs: > > - The configuration option (CONFIG_VM_SWAPPINESS). > - The command line parameter (vm_swappiness). > > The default value is preserved, but now defined by CONFIG_VM_SWAPPINESS. > > Historically, the default swappiness is set to the well-known value 60, > and this works well for the majority of cases. The vm_swappiness is also > exposed as the kernel parameter that can be changed at runtime too, e.g. > with sysctl. > > This approach might not suit well some configurations, e.g. systemd-based > distros, where systemd is put in charge of the cgroup controllers, > including the memory one. In such cases, the default swappiness 60 > is copied across the cgroup subtrees early at startup, when systemd > is arranging the slices for its services, before the sysctl.conf > or tmpfiles.d/*.conf changes are applied. > > One could run a script to traverse the cgroup trees later and set the > desired memory.swappiness individually in each occurrence when the runtime > is set up, but this would require some amount of work to implement > properly. Instead, why not set the default swappiness as early as possible? I have to say I am not a great fan of more tunning for swappiness as this is quite a poor tunning for many years already. It essentially does nothing in many cases because the reclaim process ignores to value in many cases (have a look a get_scan_count. I have seen quite some reports that setting a specific value for vmswappiness didn't make any change. The knob itself has a terrible semantic to begin with because there is no way to express I really prefer to swap rather than page cache reclaim. This all makes me think that swappiness is a historical mistake that we should rather make obsolete than promote even further. -- Michal Hocko SUSE Labs