From: Andrew Morton <akpm@linux-foundation.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Jules Irenge <jbi.octave@gmail.com>,
boqun.feng@gmail.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] backing-dev: refactor wb_congested_put()
Date: Wed, 11 Mar 2020 20:00:23 -0700 [thread overview]
Message-ID: <20200311200023.974009d9a5648b977d5168f6@linux-foundation.org> (raw)
In-Reply-To: <20200312022948.GH22433@bombadil.infradead.org>
On Wed, 11 Mar 2020 19:29:48 -0700 Matthew Wilcox <willy@infradead.org> wrote:
> On Wed, Mar 11, 2020 at 05:59:19PM -0700, Andrew Morton wrote:
> > hm, it's hard to get excited over this. Open-coding the
> > refcount_dec_and_lock_irqsave() internals at a callsite in order to
> > make sparse happy.
> >
> > Is there some other way, using __acquires (for example)?
>
> sparse is really bad at conditional lock acquisition.
I can well imagine.
> we have similar
> problems over the vfs. but we shouldn't be obfuscating our code to make
> the tool happy.
Perhaps sparse needs a way of being directed to suppress checking
across a particular function.
next prev parent reply other threads:[~2020-03-12 3:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 0:21 [PATCH 0/1] Refactoring wb_congested_put() Jules Irenge
2020-03-12 0:21 ` [PATCH 1/1] backing-dev: refactor wb_congested_put() Jules Irenge
2020-03-12 0:59 ` Andrew Morton
2020-03-12 2:29 ` Matthew Wilcox
2020-03-12 3:00 ` Andrew Morton [this message]
2020-03-12 9:56 ` Jules Irenge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200311200023.974009d9a5648b977d5168f6@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=boqun.feng@gmail.com \
--cc=jbi.octave@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox