From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1071AC0044D for ; Wed, 11 Mar 2020 18:35:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A87AA206E9 for ; Wed, 11 Mar 2020 18:35:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="Oj2+9cL+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A87AA206E9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4312F6B0008; Wed, 11 Mar 2020 14:35:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E2C86B000A; Wed, 11 Mar 2020 14:35:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 281AA6B000C; Wed, 11 Mar 2020 14:35:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0206.hostedemail.com [216.40.44.206]) by kanga.kvack.org (Postfix) with ESMTP id 118C16B0008 for ; Wed, 11 Mar 2020 14:35:19 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C74D0181AEF09 for ; Wed, 11 Mar 2020 18:35:18 +0000 (UTC) X-FDA: 76583933916.13.tank56_6889392581506 X-HE-Tag: tank56_6889392581506 X-Filterd-Recvd-Size: 4125 Received: from mail-qt1-f193.google.com (mail-qt1-f193.google.com [209.85.160.193]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Mar 2020 18:35:18 +0000 (UTC) Received: by mail-qt1-f193.google.com with SMTP id m33so2354977qtb.3 for ; Wed, 11 Mar 2020 11:35:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eYOHMjSMYAiqyn3S+V97OaKejU5YnzW7DlF+2YMOcF0=; b=Oj2+9cL+KscU9a9zK4Suzl5t1bo3inZGbyVIq9f/zeCmxkVp6hpJxKiilnqnMZQ/FY 88384yWaxGdO7AK2SvS4w/5ttmUJ1QwwiIIQkIru3m4YEvr6DVRfcc2LZX2b+WisWs3x Q9/ZJPxajspOeqvaygRv/+e66+A+86ngTjF2dHCc+iW767kCXhfOPdAWbvM9qhpvmh52 a1hdeiAzVdj1EC+964oWge4gJ1EvDWASPw6bKneNMxHD5zeTPMdbLleLYVkd/wi+PWZ9 2CJq/Ge+3bDYLHuaBaG8pI2c5Dwhg7JguuNwrBTyac857oUPLrhjtOnYkU9jB4pEhySk Wr0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eYOHMjSMYAiqyn3S+V97OaKejU5YnzW7DlF+2YMOcF0=; b=XMBgNgBoei91wc9RL7I3AGcM3l9Np+w/hcR3ia5EEy8CdfILWfLCOrcp6FcPuqG5M2 E5x1clbYs/KaDJ0dkvtTuCTXMomMSV5bg37WzmbsAWWbnzb0s/+YLkTwLgfRIWH9O/GX Uv0ZSrbDKEMmWmAnQDAT51VLF7lGay0oLkV1oT39fF8yP4RzfrLoiDMPj/l3Am0jnRvQ llEvoGR9kaQBrtElHnGO5xCO4tuythqyvT+wVIjOKkQUJRQsr7HaU3Z7nW4uPsHsg07M 27dGVei45UVXDwp4nHd49QU1miEggZM1njoLzviie7VzQjGHwMgO4NdXi2Ype2nEZnag g4XA== X-Gm-Message-State: ANhLgQ1CPZ89cIJWHByfYTefntcQDz5K0jOOheQfGC8l7vmUpItKdLrl UOGxvws5EDFlEkso2jhwWBYwWA== X-Google-Smtp-Source: ADFU+vvtZI7GOONaM2bhtDz46uIiycc1D5Nn8U4YJ8Luo17HKLeSzNTw8qbnVEqbl89i5RN+bVZ38Q== X-Received: by 2002:ac8:1758:: with SMTP id u24mr4036108qtk.148.1583951716868; Wed, 11 Mar 2020 11:35:16 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id u26sm948048qku.97.2020.03.11.11.35.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 11 Mar 2020 11:35:16 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jC6CJ-00016R-6m; Wed, 11 Mar 2020 15:35:15 -0300 From: Jason Gunthorpe To: Jerome Glisse , Ralph Campbell , Felix.Kuehling@amd.com Cc: linux-mm@kvack.org, John Hubbard , dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, Christoph Hellwig , Philip Yang , Jason Gunthorpe Subject: [PATCH hmm 4/8] mm/hmm: add missing pfns set to hmm_vma_walk_pmd() Date: Wed, 11 Mar 2020 15:35:02 -0300 Message-Id: <20200311183506.3997-5-jgg@ziepe.ca> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200311183506.3997-1-jgg@ziepe.ca> References: <20200311183506.3997-1-jgg@ziepe.ca> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Jason Gunthorpe All success exit paths from the walker functions must set the pfns array. A migration entry with no required fault is a HMM_PFN_NONE return, just like the pte case. Fixes: d08faca018c4 ("mm/hmm: properly handle migration pmd") Signed-off-by: Jason Gunthorpe --- mm/hmm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/hmm.c b/mm/hmm.c index 32dcbfd3908315..5f5ccf13dd1e85 100644 --- a/mm/hmm.c +++ b/mm/hmm.c @@ -394,7 +394,7 @@ static int hmm_vma_walk_pmd(pmd_t *pmdp, pmd_migration_entry_wait(walk->mm, pmdp); return -EBUSY; } - return 0; + return hmm_pfns_fill(start, end, range, HMM_PFN_NONE); } else if (!pmd_present(pmd)) return hmm_pfns_fill(start, end, range, HMM_PFN_ERROR); =20 --=20 2.25.1