From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2056C2BAEE for ; Wed, 11 Mar 2020 17:35:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1C20D2072F for ; Wed, 11 Mar 2020 17:35:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Qxv1kSHh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C20D2072F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 260156B0037; Wed, 11 Mar 2020 13:35:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1EA036B006C; Wed, 11 Mar 2020 13:35:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D8C96B006E; Wed, 11 Mar 2020 13:35:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0169.hostedemail.com [216.40.44.169]) by kanga.kvack.org (Postfix) with ESMTP id EA4746B0037 for ; Wed, 11 Mar 2020 13:35:55 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A5498181AEF15 for ; Wed, 11 Mar 2020 17:35:55 +0000 (UTC) X-FDA: 76583784270.07.cow46_169e50ba98035 X-HE-Tag: cow46_169e50ba98035 X-Filterd-Recvd-Size: 4065 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Mar 2020 17:35:55 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id v11so3726112wrm.9 for ; Wed, 11 Mar 2020 10:35:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ul3aKF3mgmNSrCiKZR1xszeDpKLTrhtBGKS0nAOe96I=; b=Qxv1kSHhmiyl18Lg2mWDZPGmXfwOrbANLmtvAgLq2LDLT4t5EMSGVFbTQ0T7HnVUVC /El7DtDiEORVt9HKOrXAvI53eA3ZjgKAh3xoy5kjaVBE2OwCQPnczmJXs2UCRN58QwEY nrOpJ/cQR0ULP4WPL/gjVtx2SnEEjvJp610a6X85Ou8I0za0dBWskFn4m+JdxiaEEc8i IFgGTtV7w7h/D7nm4FAlQn0lvzYNfHdCon//XQInYH1YHgMmu6IqVsBKjL0wl4YLoVq4 2+DCA5uZrFKQoWq5nY5ISU1UlfRZCd32gjj6Da0JK1KvIBa8ky1OTK6lh2qDENVtMezh UFsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ul3aKF3mgmNSrCiKZR1xszeDpKLTrhtBGKS0nAOe96I=; b=gl3Iore5NcWav9gdelAqbXl6BupJnv0VFyCWawmTNJamKhL5/U7qQhqtOn/KcAFsjf fUo4dxtzQ5qn0KYf9O22sfFh+lIO5ezQTtNuwV787QzDKo4+EQDn25CQG3No34cYWL1I dXziI/q6ZFViz/6y4U0o+Z5QMJcc3QO4O39I0z/IMIKcK2msx+MfslFsPCHVn+j+8yFt SL9s5sfyqpiQbyCAflowLr9clM25G4ILPxZbiRnnAiRaZcKrui72Qmz0dv/le9vpFzXH 2a6ZD1JUu2jfiZsIME9l2lQHC4orGfgXWrtfREUDEz1FCiX1jnyp8Eq1yicrDbCeS+Eh gm5w== X-Gm-Message-State: ANhLgQ1DglRemALUhV3iST9wUb642ekFLS50m5mZL0eDu9xKU7eWCwTK hyFvB/EVpnKPuHLM6/TMQg== X-Google-Smtp-Source: ADFU+vsjpr414bIBPts3KWkhIsaYHeKBASQZ7NLY183Ib+uUwl1ipw/yJLNpNo/BaGgh+eB9SQ8QUQ== X-Received: by 2002:adf:e447:: with SMTP id t7mr5687572wrm.374.1583948154005; Wed, 11 Mar 2020 10:35:54 -0700 (PDT) Received: from avx2 ([46.53.249.42]) by smtp.gmail.com with ESMTPSA id y69sm9437327wmd.46.2020.03.11.10.35.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2020 10:35:53 -0700 (PDT) Date: Wed, 11 Mar 2020 20:35:50 +0300 From: Alexey Dobriyan To: Jaewon Kim Cc: akpm@linux-foundation.org, labbott@redhat.com, sumit.semwal@linaro.org, minchan@kernel.org, ngupta@vflare.org, sergey.senozhatsky.work@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, jaewon31.kim@gmail.com Subject: Re: [RFC PATCH 1/3] proc/meminfo: introduce extra meminfo Message-ID: <20200311173550.GA2170@avx2> References: <20200311034441.23243-1-jaewon31.kim@samsung.com> <20200311034441.23243-2-jaewon31.kim@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200311034441.23243-2-jaewon31.kim@samsung.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 11, 2020 at 12:44:39PM +0900, Jaewon Kim wrote: > Provide APIs to drivers so that they can show its memory usage on > /proc/meminfo. > > int register_extra_meminfo(atomic_long_t *val, int shift, > const char *name); > int unregister_extra_meminfo(atomic_long_t *val); > + show_val_kb(m, memtemp->name_pad, nr_page); I have 3 issues. Can this be printed without "KB" piece and without useless whitespace, like /proc/vmstat does? I don't know how do you parse /proc/meminfo. Do you search for specific string or do you use some kind of map[k] = v interface? 2) zsmalloc can create top-level symlink and resolve it to necessary value. It will be only 1 readlink(2) system call to fetch it. 3) android can do the same For simple values there is no need to register stuff and create mini subsystems. /proc/alexey