From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 799E0C2BB1D for ; Wed, 11 Mar 2020 18:54:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3636620736 for ; Wed, 11 Mar 2020 18:54:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Xu0YYNq6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3636620736 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D4A3D6B0006; Wed, 11 Mar 2020 14:54:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CD39A6B0007; Wed, 11 Mar 2020 14:54:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B74826B0008; Wed, 11 Mar 2020 14:54:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0144.hostedemail.com [216.40.44.144]) by kanga.kvack.org (Postfix) with ESMTP id 9AD326B0006 for ; Wed, 11 Mar 2020 14:54:07 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 56E0F8248047 for ; Wed, 11 Mar 2020 18:54:07 +0000 (UTC) X-FDA: 76583981334.15.bee66_7b43be9638122 X-HE-Tag: bee66_7b43be9638122 X-Filterd-Recvd-Size: 5521 Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Mar 2020 18:54:06 +0000 (UTC) Received: by mail-pf1-f194.google.com with SMTP id x2so1469233pfn.9 for ; Wed, 11 Mar 2020 11:54:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+NFtzlNIubXyKkT0aaqAyTYGNu2hBMxpytJJLWrkR+w=; b=Xu0YYNq6iL3XItsLJITZiAfw7pQ55+Wan446ePi0MQv+K8wkXn4aRCAf4e5Emt+HlC hKXOCC/w+kuvCqACGDt+jTb/a6HCI7Gwm6wXsgSTYmC6M16yXJO58tUwc7cQNtetwc/Z JdAJWbhaOAvARZcMbagpxGBlTJO9eEMDFM22E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+NFtzlNIubXyKkT0aaqAyTYGNu2hBMxpytJJLWrkR+w=; b=NglgpjbaTJ0BAWODmEvMOyVmKQzaF5Un5FOZcSECNwip3wzeilWcoUeXg+6xjcW34T nPRWiM+E1kE/Tan8GMHvP5hpSkbzDahagzyfJj8ZJ8HEvMY6PqlwYBav9giJ+jgg2bX2 tcUBz2OlYiFdosUNSeHs443Xvt3/cLc8VQsKad2EZNHCua4R9K5w05SFuhn7oYKKoNlU YtUbLAU3fUgE3+QYdeUa4gqu3T2lZWeeuLtD0DOFcU9i9J8OH9O7/b/J/lCBU+UonXQK wNuIAf9RCEqrPN4qSVZgksxOdlx225qvQ8f1KqwaGZtIh6bYibgPzZxeo7qhAYnM4ldr AvGg== X-Gm-Message-State: ANhLgQ1/fI3lreasNlsXnvEEaLelGrV//N13CxLEincq6pInLy/TMLJD AtnS7iA3YKaTYDAl1MOyrtrm6w== X-Google-Smtp-Source: ADFU+vtdcKOyGaZUfwI5+MQMZZomjwrU/L0V+T9gd4shCDOL0PoNkiwaShk91h0o8jLRtEUWUh1JTA== X-Received: by 2002:a63:b04f:: with SMTP id z15mr4044123pgo.58.1583952845893; Wed, 11 Mar 2020 11:54:05 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id z24sm19444621pfk.46.2020.03.11.11.54.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2020 11:54:05 -0700 (PDT) Date: Wed, 11 Mar 2020 11:54:04 -0700 From: Kees Cook To: Bernd Edlinger Cc: "Eric W. Biederman" , Christian Brauner , Jann Horn , Jonathan Corbet , Alexander Viro , Andrew Morton , Alexey Dobriyan , Thomas Gleixner , Oleg Nesterov , Frederic Weisbecker , Andrei Vagin , Ingo Molnar , "Peter Zijlstra (Intel)" , Yuyang Du , David Hildenbrand , Sebastian Andrzej Siewior , Anshuman Khandual , David Howells , James Morris , Greg Kroah-Hartman , Shakeel Butt , Jason Gunthorpe , Christian Kellner , Andrea Arcangeli , Aleksa Sarai , "Dmitry V. Levin" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "stable@vger.kernel.org" , "linux-api@vger.kernel.org" Subject: Re: [PATCH 4/4] kernel: doc: remove outdated comment cred.c Message-ID: <202003111154.AEA9260278@keescook> References: <878sk94eay.fsf@x220.int.ebiederm.org> <87r1y12yc7.fsf@x220.int.ebiederm.org> <87k13t2xpd.fsf@x220.int.ebiederm.org> <87d09l2x5n.fsf@x220.int.ebiederm.org> <871rq12vxu.fsf@x220.int.ebiederm.org> <877dzt1fnf.fsf@x220.int.ebiederm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 10, 2020 at 02:44:18PM +0100, Bernd Edlinger wrote: > This removes an outdated comment in prepare_kernel_cred. > > There is no "cred_replace_mutex" any more, so the comment must > go away. > > Signed-off-by: Bernd Edlinger Reviewed-by: Kees Cook -Kees > --- > kernel/cred.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/kernel/cred.c b/kernel/cred.c > index 809a985..71a7926 100644 > --- a/kernel/cred.c > +++ b/kernel/cred.c > @@ -675,8 +675,6 @@ void __init cred_init(void) > * The caller may change these controls afterwards if desired. > * > * Returns the new credentials or NULL if out of memory. > - * > - * Does not take, and does not return holding current->cred_replace_mutex. > */ > struct cred *prepare_kernel_cred(struct task_struct *daemon) > { > -- > 1.9.1 -- Kees Cook