From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F3EDC10F27 for ; Wed, 11 Mar 2020 09:27:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E2F9D21655 for ; Wed, 11 Mar 2020 09:27:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2F9D21655 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 88A8C6B0003; Wed, 11 Mar 2020 05:27:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8138A6B0006; Wed, 11 Mar 2020 05:27:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B4386B0007; Wed, 11 Mar 2020 05:27:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0139.hostedemail.com [216.40.44.139]) by kanga.kvack.org (Postfix) with ESMTP id 50F316B0003 for ; Wed, 11 Mar 2020 05:27:22 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id C2E5C180EE3E9 for ; Wed, 11 Mar 2020 09:27:21 +0000 (UTC) X-FDA: 76582553082.20.star07_7a714fb5dc558 X-HE-Tag: star07_7a714fb5dc558 X-Filterd-Recvd-Size: 3511 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Mar 2020 09:27:21 +0000 (UTC) Received: by mail-wr1-f66.google.com with SMTP id 6so1611976wre.4 for ; Wed, 11 Mar 2020 02:27:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6HDgqWtxzx0YdOe7/T+nmkFIQiMnqZT0BKBTXUpjOCU=; b=ID9rKvC/cDHcVu0USvjVP2g+cVZxw1IzA3IMf1XQbybVwXTvZw7kksGuiUWPHyLSmk XhDBHg8EiwhdzA2QTau1PdoPD0GIVWNguTBL5GDZFbISfrGvlOYms+lh/OdqHjtZiooQ UO+4FtQ1lmcmKLKgvFJNA6so1ilEJbxfC5JlHL3FRkJ7bHM9oS0bKQIiF7lfkMaWlorX 8byWFAzqnLBBQlxn0O7SbgyW8HEe13CRZWyCjsNTLxh1DkEqRmI7qVdY85x/Te2gpvKz IZHJhItPzkwxXBXglEHsKFS8WAxIkBqmioNxlU5Q2sIm6scqBBRFAuy3S+KhfJxlC4Hy NmbA== X-Gm-Message-State: ANhLgQ3GtJLpoQ5KaRilKXyw7ZYEkYsumKuQr1sQC0/0irzwwM93ka2l kS7Umihi4thYC4u0eRJXIuI= X-Google-Smtp-Source: ADFU+vuDpsVvLkTM3Nb0UuQU+CfWyUONSVBwVo++oOV/H5y+feN1kM/a62ZA/aQlB3IMgq9t/5e1Yg== X-Received: by 2002:adf:e98f:: with SMTP id h15mr3475093wrm.263.1583918839739; Wed, 11 Mar 2020 02:27:19 -0700 (PDT) Received: from localhost (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id a26sm7815970wmm.18.2020.03.11.02.27.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2020 02:27:19 -0700 (PDT) Date: Wed, 11 Mar 2020 10:27:18 +0100 From: Michal Hocko To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, akpm@linux-foundation.org Subject: Re: [PATCH v2] x86/mm: Remove the redundant conditional check Message-ID: <20200311092718.GG23944@dhcp22.suse.cz> References: <20200311011823.27740-1-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200311011823.27740-1-bhe@redhat.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 11-03-20 09:18:23, Baoquan He wrote: > In commit f70029bbaacb ("mm, memory_hotplug: drop CONFIG_MOVABLE_NODE"), > the dependency on CONFIG_MOVABLE_NODE was removed for N_MEMORY. Before > commit f70029bbaacb, CONFIG_HIGHMEM && !CONFIG_MOVABLE_NODE could make > (N_MEMORY == N_NORMAL_MEMORY) be true. After commit f70029bbaacb, N_MEMORY > doesn't have any chance to be equal to N_NORMAL_MEMORY. So the conditional > check in paging_init() doesn't make sense any more. Let's remove it. > > Signed-off-by: Baoquan He Acked-by: Michal Hocko Thanks! > --- > v1->v2: > Update patch log to make the description clearer per Michal's > suggestion. > > arch/x86/mm/init_64.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c > index abbdecb75fad..0a14711d3a93 100644 > --- a/arch/x86/mm/init_64.c > +++ b/arch/x86/mm/init_64.c > @@ -818,8 +818,7 @@ void __init paging_init(void) > * will not set it back. > */ > node_clear_state(0, N_MEMORY); > - if (N_MEMORY != N_NORMAL_MEMORY) > - node_clear_state(0, N_NORMAL_MEMORY); > + node_clear_state(0, N_NORMAL_MEMORY); > > zone_sizes_init(); > } > -- > 2.17.2 -- Michal Hocko SUSE Labs