From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 465A8C10F27 for ; Wed, 11 Mar 2020 04:21:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CF8FC2071B for ; Wed, 11 Mar 2020 04:21:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YF5xfMfX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CF8FC2071B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3A23C6B0003; Wed, 11 Mar 2020 00:21:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 353656B0006; Wed, 11 Mar 2020 00:21:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2438A6B0007; Wed, 11 Mar 2020 00:21:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0197.hostedemail.com [216.40.44.197]) by kanga.kvack.org (Postfix) with ESMTP id 0F27A6B0003 for ; Wed, 11 Mar 2020 00:21:04 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id C9CCB8248047 for ; Wed, 11 Mar 2020 04:21:03 +0000 (UTC) X-FDA: 76581781206.11.start77_43700f464a32c X-HE-Tag: start77_43700f464a32c X-Filterd-Recvd-Size: 3156 Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Mar 2020 04:21:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583900462; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9QRoyoaeYNQzjCfMEswOWDCgRYflsRAo3xvL3LOE1VY=; b=YF5xfMfXGksDRLwat1UzFLMNwTg+mrMLiQrsMlp/aPn4jTgXwsC5idgfxVWsF4ogmv7nPD +C3sxqk97nUtESusO2CljTBSLDWFqGeHW479ABQZ34yHGrJQ0fhECuoVxMh9EzI23kl5EV gsx5f2hv9p1HRrdBtqTrmEqFJRRye2U= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-481-MrMI8VG2NNqzBbZ_2nkZXQ-1; Wed, 11 Mar 2020 00:21:00 -0400 X-MC-Unique: MrMI8VG2NNqzBbZ_2nkZXQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2CDE718A6EC0; Wed, 11 Mar 2020 04:20:59 +0000 (UTC) Received: from localhost (ovpn-12-39.pek2.redhat.com [10.72.12.39]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9744F8B74D; Wed, 11 Mar 2020 04:20:55 +0000 (UTC) Date: Wed, 11 Mar 2020 12:20:52 +0800 From: Baoquan He To: Michal Hocko Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, david@redhat.com, richardw.yang@linux.intel.com, dan.j.williams@intel.com, osalvador@suse.de, rppt@linux.ibm.com Subject: Re: [PATCH v3 5/7] mm/sparse.c: add note about only VMEMMAP supporting sub-section support Message-ID: <20200311042052.GI27711@MiWiFi-R3L-srv> References: <20200307084229.28251-1-bhe@redhat.com> <20200307084229.28251-6-bhe@redhat.com> <20200310144616.GM8447@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200310144616.GM8447@dhcp22.suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 03/10/20 at 03:46pm, Michal Hocko wrote: > On Sat 07-03-20 16:42:27, Baoquan He wrote: > > And tell check_pfn_span() gating the porper alignment and size of > > hot added memory region. > > > > And also move the code comments from inside section_deactivate() > > to being above it. The code comments are reasonable for the whole > > function, and the moving makes code cleaner. > > > > Signed-off-by: Baoquan He > > Acked-by: Michal Hocko > > I have glanced through other patches and they seem sane but I do not > have time to go deeper to give an ack. I like this one though because it > really makes the intention clearer. Thanks for your reviewing and providing ack on this patch. I will post a new version to rebase on the top of patch 1 and its appended fix, then address those concerns from David.