From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ED97C10F27 for ; Tue, 10 Mar 2020 14:39:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C326120848 for ; Tue, 10 Mar 2020 14:39:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EiD3dysb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C326120848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4839F6B0005; Tue, 10 Mar 2020 10:39:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 434FE6B0006; Tue, 10 Mar 2020 10:39:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2FBAF6B0007; Tue, 10 Mar 2020 10:39:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0035.hostedemail.com [216.40.44.35]) by kanga.kvack.org (Postfix) with ESMTP id 14EC16B0005 for ; Tue, 10 Mar 2020 10:39:18 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id DE534878D for ; Tue, 10 Mar 2020 14:39:17 +0000 (UTC) X-FDA: 76579710354.17.pen80_16ec5f7f05b2e X-HE-Tag: pen80_16ec5f7f05b2e X-Filterd-Recvd-Size: 7184 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Tue, 10 Mar 2020 14:39:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583851156; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VCKQRu/V4OQWUGIr/zEfp8pvu1OX2E0QvMvab4wr1kY=; b=EiD3dysbgdOQGjMjJWEZIUOwp89G3vPSPkBVaV585ADRFHPnK/1Af2mkqIDSPTZ2vZYn+d V5WneOFwp9J6ttqSnM7ikvx5nD5dYAcpvf7mxs+pzt7Fd+0sh5aS6f+mCljElAW/Vw7aw3 nDeb9mzQxFcZXmOtqCaHFbfOh6qLPs0= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-269-cKfH1bU3MguIPCdQmMofRw-1; Tue, 10 Mar 2020 10:39:13 -0400 X-MC-Unique: cKfH1bU3MguIPCdQmMofRw-1 Received: by mail-qv1-f69.google.com with SMTP id l16so9216130qvo.15 for ; Tue, 10 Mar 2020 07:39:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zyh0c/lQXUeQJxXiokEAQhoyttnF7k+G9zDnREDUBOk=; b=RUysnrdoUNNLNCzNK+D5WlYBV0es+4TqxOExcWIMV7gGxYdc3zxNf69zCI62zqmSTg kd4sVBKcqp8dmuL4Cq79SyIaqy3HF6wB0/MZK293QqRUAnv+hNBNifZjxwv1yyfqAHMX atHicSlIZXJW9Mw0lCtXDdS+d6I5TarSBbKS3q8rCxORQGIYiQQnajGtXvbxwJuTV/cR eVmZrvZUHTAhPAMr+JuzDuOQvvggzDhYoPnXuPmgWalX4Ana/NwiA6imFogKL673PV8u 7QVNwNIWm+j9ZXlFuaPC7asUs4FRzBYhrVsae9WFBgrHqZ8wuyTQWYKjxnYgLWbs4+b+ 03ZQ== X-Gm-Message-State: ANhLgQ0R7dXTF0u0dcDpe7B7QDJpzNuimbzXvx+5yjQbRgMYrh3+k1F4 W/JKEvYBKPv30vk+v+s1RVgXlwr7Xlff5pNnp6AUzEc7LOt26YJYcL4U1nHvdZEq+aSeHTNiNmY nd43vcT0EpuY= X-Received: by 2002:ac8:7290:: with SMTP id v16mr19428287qto.197.1583851153136; Tue, 10 Mar 2020 07:39:13 -0700 (PDT) X-Google-Smtp-Source: ADFU+vulOJdmZBLs4oHFm/dptYsavRskgrPGpfAsnAbHUBMXeEl9zOKzYp9VIsSKOWS8AeDVB+LSFA== X-Received: by 2002:ac8:7290:: with SMTP id v16mr19428260qto.197.1583851152845; Tue, 10 Mar 2020 07:39:12 -0700 (PDT) Received: from xz-x1 ([2607:9880:19c0:32::2]) by smtp.gmail.com with ESMTPSA id g8sm15115308qke.1.2020.03.10.07.39.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2020 07:39:11 -0700 (PDT) Date: Tue, 10 Mar 2020 10:39:10 -0400 From: Peter Xu To: kbuild test robot , Andrew Morton Cc: kbuild-all@lists.01.org, Johannes Weiner , Andrew Morton , Linux Memory Management List Subject: Re: [hnaz-linux-mm:master 89/340] include/linux/sched/signal.h:381:9: note: in expansion of macro 'unlikely' Message-ID: <20200310143910.GF326977@xz-x1> References: <202003101445.tXceNw3F%lkp@intel.com> MIME-Version: 1.0 In-Reply-To: <202003101445.tXceNw3F%lkp@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 10, 2020 at 02:45:50PM +0800, kbuild test robot wrote: > tree: https://github.com/hnaz/linux-mm master > head: 5d9ee416b5701096536c7a63c04dbe25012baa9e > commit: 133f884fbe299145671d583f255f71b63d9ad63f [89/340] mm: introduce f= ault_signal_pending() > config: xtensa-randconfig-a001-20200309 (attached as .config) > compiler: xtensa-linux-gcc (GCC) 9.2.0 > reproduce: > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbi= n/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > git checkout 133f884fbe299145671d583f255f71b63d9ad63f > # save the attached .config to linux build tree > GCC_VERSION=3D9.2.0 make.cross ARCH=3Dxtensa=20 >=20 > If you fix the issue, kindly add following tag > Reported-by: kbuild test robot >=20 > All warnings (new ones prefixed by >>): >=20 > In file included from arch/xtensa/include/asm/processor.h:15, > from arch/xtensa/kernel/asm-offsets.c:15: > include/linux/sched/signal.h: In function 'fault_signal_pending': > include/linux/sched/signal.h:381:33: error: 'VM_FAULT_RETRY' undeclare= d (first use in this function) > 381 | return unlikely((fault_flags & VM_FAULT_RETRY) && > | ^~~~~~~~~~~~~~ Hi, Andrew, Thanks for queuing the two series, and sorry for breaking the builds. I received 6 build errors this morning after you queued the two series on mm page fault retries and userfault-wp. They are: [hnaz-linux-mm:master 89/340] include/linux/sched/signal.h:381:9: note: in = expansion of macro 'unlikely' [hnaz-linux-mm:master 89/340] include/linux/sched/signal.h:381:33: error: '= VM_FAULT_RETRY' undeclared [hnaz-linux-mm:master 95/340] include/linux/sched/signal.h:383:6: error: im= plicit declaration of function 'user_mode' [hnaz-linux-mm:master 89/340] include/linux/sched/signal.h:381:33: error: '= VM_FAULT_RETRY' undeclared [hnaz-linux-mm:master 89/340] arch/mips/mm/fault.c:157:27: error: passing a= rgument 1 of 'fault_signal_pending' makes integer from pointer without a ca= st [hnaz-linux-mm:master 95/340] include/linux/sched/signal.h:383:6: error: im= plicit declaration of function 'user_mode' If I'm correct, it's all caused by the patch 3 with subject "mm: Introduce fault_signal_pending()" in the mm page fault retry series. And IIUC below should be able to fix if squashed into the same patch: ------------8<---------------- diff --git a/arch/mips/mm/fault.c b/arch/mips/mm/fault.c index fd64b135fd7b..4a0eafe3d932 100644 --- a/arch/mips/mm/fault.c +++ b/arch/mips/mm/fault.c @@ -154,7 +154,7 @@ static void __kprobes __do_page_fault(struct pt_regs *r= egs, unsigned long write, */ fault =3D handle_mm_fault(vma, address, flags); =20 - if (fault_signal_pending(regs)) + if (fault_signal_pending(fault, regs)) return; =20 perf_sw_event(PERF_COUNT_SW_PAGE_FAULTS, 1, regs, address); diff --git a/include/linux/sched/signal.h b/include/linux/sched/signal.h index 09d40ce6a162..c8e0e4f801e4 100644 --- a/include/linux/sched/signal.h +++ b/include/linux/sched/signal.h @@ -10,6 +10,8 @@ #include #include #include +#include +#include =20 /* * Types defining task->signal and task->sighand and APIs using them: ------------>8---------------- I'm sorry I still don't have proper hosts to test build these, so this code clip is only test-compile on x86. May need your help to see how to move on and improve this. Thanks! --=20 Peter Xu