From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 044AEC10F27 for ; Tue, 10 Mar 2020 11:43:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C036824655 for ; Tue, 10 Mar 2020 11:43:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C036824655 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4BA5A6B0005; Tue, 10 Mar 2020 07:43:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 46AFB6B0006; Tue, 10 Mar 2020 07:43:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 331426B0007; Tue, 10 Mar 2020 07:43:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0187.hostedemail.com [216.40.44.187]) by kanga.kvack.org (Postfix) with ESMTP id 18D426B0005 for ; Tue, 10 Mar 2020 07:43:16 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 1D2AD8248D7C for ; Tue, 10 Mar 2020 11:43:16 +0000 (UTC) X-FDA: 76579266792.29.skate42_56b4ce3878343 X-HE-Tag: skate42_56b4ce3878343 X-Filterd-Recvd-Size: 3742 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Tue, 10 Mar 2020 11:43:15 +0000 (UTC) Received: by mail-wm1-f65.google.com with SMTP id 11so705814wmo.2 for ; Tue, 10 Mar 2020 04:43:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hMBSAZ2w6rHBlgdOMKsoKxalij10II+RdrF1ljWYIAk=; b=ZSSeA/KzUKMued9MswC+eqDQSNfwKwq5TILT1yvNzZ/acOVqkEFYvJXtYfgT7f30mT kDR3MvnRKxtyToDIpqG4Jl9AMMn8p0f48kSuKNYWggxR+mpEitNxXLHEgBaJtKwnLoW1 WwNWZoLPEaUK3NWdcQhS7pTmJUrZT4SLTfYsLIFcdEWs8oPra5nxPPp8+vBaWofcY1UX 85IjASfKHv1TVhPfXmbwvxfuSXO5xfsK0zlnjlfdgUiNHKG4PjSIxQ1xGh5wuBBhr9kU 26vHM/MG1HEObZicwUB0wUA2LGrotpmVlQR8d2VraQAljlJSOpW0BVySCAWWHJ6uAFuX 0XLA== X-Gm-Message-State: ANhLgQ2+NeED7+c2wKviwlFtVIJN+lT6UaEflvEmtlmgli6iST6NjmvU 815XGrEeMaUGiKr+XauavJ8= X-Google-Smtp-Source: ADFU+vuKZ/41TrYfhsXloC/F2fawinzqxCwHUoA7MsTg/Xb+5sVoVBhrkM90t/0amNfG09qJHc1Ixg== X-Received: by 2002:a05:600c:d8:: with SMTP id u24mr1820247wmm.165.1583840594393; Tue, 10 Mar 2020 04:43:14 -0700 (PDT) Received: from localhost (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id e20sm4703596wrc.97.2020.03.10.04.43.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2020 04:43:13 -0700 (PDT) Date: Tue, 10 Mar 2020 12:43:12 +0100 From: Michal Hocko To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtio-dev@lists.oasis-open.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, Andrew Morton , "Michael S . Tsirkin" , Jason Wang , Oscar Salvador , Igor Mammedov , Dave Young , Dan Williams , Pavel Tatashin , Stefan Hajnoczi , Vlastimil Babka Subject: Re: [PATCH v1 07/11] virtio-mem: Allow to offline partially unplugged memory blocks Message-ID: <20200310114312.GG8447@dhcp22.suse.cz> References: <20200302134941.315212-1-david@redhat.com> <20200302134941.315212-8-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200302134941.315212-8-david@redhat.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000152, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 02-03-20 14:49:37, David Hildenbrand wrote: [...] > +static void virtio_mem_notify_going_offline(struct virtio_mem *vm, > + unsigned long mb_id) > +{ > + const unsigned long nr_pages = PFN_DOWN(vm->subblock_size); > + unsigned long pfn; > + int sb_id, i; > + > + for (sb_id = 0; sb_id < vm->nb_sb_per_mb; sb_id++) { > + if (virtio_mem_mb_test_sb_plugged(vm, mb_id, sb_id, 1)) > + continue; > + /* > + * Drop our reference to the pages so the memory can get > + * offlined and add the unplugged pages to the managed > + * page counters (so offlining code can correctly subtract > + * them again). > + */ > + pfn = PFN_DOWN(virtio_mem_mb_id_to_phys(mb_id) + > + sb_id * vm->subblock_size); > + adjust_managed_page_count(pfn_to_page(pfn), nr_pages); > + for (i = 0; i < nr_pages; i++) > + page_ref_dec(pfn_to_page(pfn + i)); Is there ever situation this might be a different than 1->0 transition? -- Michal Hocko SUSE Labs