From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AF2DC10F27 for ; Tue, 10 Mar 2020 07:41:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A946C24677 for ; Tue, 10 Mar 2020 07:41:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A946C24677 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivo.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 633A66B0005; Tue, 10 Mar 2020 03:41:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E4106B0006; Tue, 10 Mar 2020 03:41:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D3C26B0007; Tue, 10 Mar 2020 03:41:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0050.hostedemail.com [216.40.44.50]) by kanga.kvack.org (Postfix) with ESMTP id 353EE6B0005 for ; Tue, 10 Mar 2020 03:41:12 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id C97C7180AD815 for ; Tue, 10 Mar 2020 07:41:11 +0000 (UTC) X-FDA: 76578656742.04.card16_a55233f24635 X-HE-Tag: card16_a55233f24635 X-Filterd-Recvd-Size: 2037 Received: from m17617.mail.qiye.163.com (m17617.mail.qiye.163.com [59.111.176.17]) by imf25.hostedemail.com (Postfix) with SMTP for ; Tue, 10 Mar 2020 07:41:10 +0000 (UTC) Received: from ubuntu.localdomain (unknown [58.251.74.226]) by m17617.mail.qiye.163.com (Hmail) with ESMTPA id 909DA260F0C; Tue, 10 Mar 2020 15:41:05 +0800 (CST) From: WANG Wenhu To: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: wenhu.pku@gmail.com, WANG Wenhu Subject: [PATCH] mm: clarify a confusing comment of remap_pfn_range Date: Tue, 10 Mar 2020 00:39:54 -0700 Message-Id: <20200310073955.43415-1-wenhu.wang@vivo.com> X-Mailer: git-send-email 2.17.1 X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgYFAkeWUFZT1VCQ0lCQkJDS0pNSE5MT1lXWShZQU hPN1dZLVlBSVdZCQ4XHghZQVk1NCk2OjckKS43PlkG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6Pio6Pjo6Szg4PDwCNU9RGisK NCwKFD5VSlVKTkNIQ0lNS01MQkhIVTMWGhIXVQweFRMOVQwaFRw7DRINFFUYFBZFWVdZEgtZQVlO Q1VJTkpVTE9VSUlNWVdZCAFZQUpNT0o3Bg++ X-HM-Tid: 0a70c363d9669375kuws909da260f0c X-Bogosity: Ham, tests=bogofilter, spamicity=0.003429, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: It really made me scratching my head. Replace the comment with an accurate and consistent description. The parameter pfn actually referes to the page frame number which is right-shifted by PAGE_SHIFT from the physical address. Signed-off-by: WANG Wenhu --- mm/memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memory.c b/mm/memory.c index e8bfdf0d9d1d..583f84519870 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -1939,7 +1939,7 @@ static inline int remap_p4d_range(struct mm_struct *mm, pgd_t *pgd, * remap_pfn_range - remap kernel memory to userspace * @vma: user vma to map to * @addr: target user address to start at - * @pfn: physical address of kernel memory + * @pfn: page frame number of kernel physical memory address * @size: size of map area * @prot: page protection flags for this mapping * -- 2.17.1