From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F0BCC10F27 for ; Mon, 9 Mar 2020 15:19:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 61A8220578 for ; Mon, 9 Mar 2020 15:19:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="S0WJlUx+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 61A8220578 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0D4156B0005; Mon, 9 Mar 2020 11:19:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 086D16B0006; Mon, 9 Mar 2020 11:19:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E8F306B0007; Mon, 9 Mar 2020 11:19:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0037.hostedemail.com [216.40.44.37]) by kanga.kvack.org (Postfix) with ESMTP id CD40A6B0005 for ; Mon, 9 Mar 2020 11:19:40 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 887708248047 for ; Mon, 9 Mar 2020 15:19:40 +0000 (UTC) X-FDA: 76576183320.16.balls09_1a3a81b28cb54 X-HE-Tag: balls09_1a3a81b28cb54 X-Filterd-Recvd-Size: 5867 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Mon, 9 Mar 2020 15:19:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583767179; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1TYQHzGcsmSTzkgdiPEpKAMjBEXYWQX7oIetSjkV3rs=; b=S0WJlUx+StpE4fTDTEZhFmERQKAHvaQNWjQaBoKiSVW83ZmeNntk67vRWZCMcWQ6YB8C4a VJomdEc7pUi3ntqNyeKqyx5lMBrhOkqcrd5/dWpeDsd746bk7/r8XHzsah1CuAVgOHansN 3eV9DxeKKn1gNj54QtSAAM0tKnCvgt0= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-315-Bxrk5FNFOY21kzV-4XXC4A-1; Mon, 09 Mar 2020 11:19:35 -0400 X-MC-Unique: Bxrk5FNFOY21kzV-4XXC4A-1 Received: by mail-wm1-f70.google.com with SMTP id 20so593382wmk.1 for ; Mon, 09 Mar 2020 08:19:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=h/SV7acAIkFFySVIGC5SqbEA3QLMLQnR0tuQ2YopQFU=; b=EnkhlROfCQaXfGperbCleLvOCLUQ8ovx2eyOChRNJHe7WEi97b33Y4bQjOj6MymfjS 5im4F2nck6uK0uwg+O8G10Uvxsn0p6PUyONng1L7sbrrZLpMCLaBiNeXD25mYern2VOi 6LZARJtUe17eKLQnYKQiKUyOfgylWm5nd7NRYgtkIc42fZHRuZjZHk1sKSgPcn3D2Ihx AiFIcF2Xn2DII/S6cu0xVPJmZ93tEyTp5aA+3mvflQByYPUEESxGn3NAWuFdTTRV3GIe //3fN8+0HYDBkXu58jDvqAGXV7WsmVbkrioDTzY8FDTIXgiQrUECNuCmhe7hc2zWq3zd oOnA== X-Gm-Message-State: ANhLgQ0oU03wR9GLk8SqeAT0j8U7rdCNMAT0wTZDFLS/zw0otPwKCBNq 4HjuBb7K6Y32H1hmbpKCmI2DZi7op1VsOr/OcVICl35UbkMd3Xm1Umjh/FSJQnkmkFyGQYi/cmE vKA6M2NvMFeo= X-Received: by 2002:adf:e98f:: with SMTP id h15mr22025429wrm.263.1583767174028; Mon, 09 Mar 2020 08:19:34 -0700 (PDT) X-Google-Smtp-Source: ADFU+vupWYccqwQBjzSfnUgk4+BX0LlUz3VDK06jTEhXknfwI3x2Zp+MMN6uNViGZIUpuFxVlxzn9g== X-Received: by 2002:adf:e98f:: with SMTP id h15mr22025397wrm.263.1583767173814; Mon, 09 Mar 2020 08:19:33 -0700 (PDT) Received: from localhost (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id f127sm26539134wma.4.2020.03.09.08.19.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2020 08:19:33 -0700 (PDT) Date: Mon, 9 Mar 2020 16:19:32 +0100 From: Oleksandr Natalenko To: Michal Hocko Cc: Vlastimil Babka , Minchan Kim , Andrew Morton , LKML , linux-mm , linux-api@vger.kernel.org, Suren Baghdasaryan , Tim Murray , Daniel Colascione , Sandeep Patil , Sonny Rao , Brian Geffon , Johannes Weiner , Shakeel Butt , John Dias , Joel Fernandes , Jann Horn , alexander.h.duyck@linux.intel.com, sj38.park@gmail.com, SeongJae Park Subject: Re: [PATCH v7 7/7] mm/madvise: allow KSM hints for remote API Message-ID: <20200309151932.6sjwq6bucbu6zsea@butterfly.localdomain> References: <20200302193630.68771-1-minchan@kernel.org> <20200302193630.68771-8-minchan@kernel.org> <2a66abd8-4103-f11b-06d1-07762667eee6@suse.cz> <20200306134146.mqiyvsdnqty7so53@butterfly.localdomain> <20200309131117.anvyjszaigpoz2kp@butterfly.localdomain> <20200309150815.GR8447@dhcp22.suse.cz> MIME-Version: 1.0 In-Reply-To: <20200309150815.GR8447@dhcp22.suse.cz> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 09, 2020 at 04:08:15PM +0100, Michal Hocko wrote: > On Mon 09-03-20 14:11:17, Oleksandr Natalenko wrote: > > On Fri, Mar 06, 2020 at 05:08:18PM +0100, Vlastimil Babka wrote: > [...] > > > Dunno, it's nice to react to signals quickly, for any proces that get= s them, no? > >=20 > > So, do you mean something like this? > >=20 > > =3D=3D=3D > > diff --git a/mm/ksm.c b/mm/ksm.c > > index 363ec8189561..b39c237cfcf4 100644 > > --- a/mm/ksm.c > > +++ b/mm/ksm.c > > @@ -849,7 +849,8 @@ static int unmerge_ksm_pages(struct vm_area_struct = *vma, > > =09for (addr =3D start; addr < end && !err; addr +=3D PAGE_SIZE) { > > =09=09if (ksm_test_exit(vma->vm_mm)) > > =09=09=09break; > > -=09=09if (signal_pending(current)) > > +=09=09if (signal_pending(current) || > > +=09=09 signal_pending(rcu_dereference(vma->vm_mm->owner))) > > =09=09=09err =3D -ERESTARTSYS; > > =09=09else > > =09=09=09err =3D break_ksm(vma, addr); > > =3D=3D=3D >=20 > This is broken because mm might be attached to different tasks. > AFAIU this check is meant to allow quick backoff of the _calling_ > process so that it doesn't waste time when the context is killed > already. I do not understand why should we care about any other context > here? What is the actual problem this would solve? I agree with you, but still trying to understand what does Vlastimil mean :). >=20 > --=20 > Michal Hocko > SUSE Labs >=20 --=20 Best regards, Oleksandr Natalenko (post-factum) Principal Software Maintenance Engineer