From: Shaju Abraham <shajunutanix@gmail.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, shajunutanix@gmail.com,
Shaju Abraham <shaju.abraham@nutanix.com>
Subject: [PATCH] mm/vmpressure.c: Include GFP_KERNEL flag to vmpressure
Date: Mon, 9 Mar 2020 11:31:41 +0000 [thread overview]
Message-ID: <20200309113141.167289-1-shaju.abraham@nutanix.com> (raw)
The VM pressure notification flags have excluded GFP_KERNEL with the
reasoning that user land will not be able to take any action in case of
kernel memory being low. This is not true always. Consider the case of
a user land program managing all the huge memory pages. By including
GFP_KERNEL flag whenever the kernel memory is low, pressure notification
can be send, and the manager process can split huge pages to satisfy kernel
memory requirement.
This is a common scanario in cloud. Most of the host memory is reserved
as hugepages and can be broken down to small pages on demand. This is
done to minimise fragmentation so that Virtual Machine power on will be
successful always.
Signed-off-by: Shaju Abraham <shaju.abraham@nutanix.com>
---
mm/vmpressure.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/mm/vmpressure.c b/mm/vmpressure.c
index 4bac22fe1aa2..7ccfb3dd8173 100644
--- a/mm/vmpressure.c
+++ b/mm/vmpressure.c
@@ -253,7 +253,8 @@ void vmpressure(gfp_t gfp, struct mem_cgroup *memcg, bool tree,
* Indirect reclaim (kswapd) sets sc->gfp_mask to GFP_KERNEL, so
* we account it too.
*/
- if (!(gfp & (__GFP_HIGHMEM | __GFP_MOVABLE | __GFP_IO | __GFP_FS)))
+ if (!(gfp & (__GFP_HIGHMEM | __GFP_MOVABLE | __GFP_IO |
+ __GFP_FS | GFP_KERNEL)))
return;
/*
--
2.20.1
next reply other threads:[~2020-03-09 11:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 11:31 Shaju Abraham [this message]
2020-03-09 11:58 ` Michal Hocko
2020-03-09 15:32 ` Shaju Abraham
2020-03-09 16:12 ` Michal Hocko
2020-03-10 7:39 ` Shaju Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200309113141.167289-1-shaju.abraham@nutanix.com \
--to=shajunutanix@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shaju.abraham@nutanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox