From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 566B2C10F28 for ; Mon, 9 Mar 2020 04:15:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F3B9820727 for ; Mon, 9 Mar 2020 04:15:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sBKY5ixc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F3B9820727 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3B2456B0003; Mon, 9 Mar 2020 00:15:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 364726B0006; Mon, 9 Mar 2020 00:15:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 252596B0007; Mon, 9 Mar 2020 00:15:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0119.hostedemail.com [216.40.44.119]) by kanga.kvack.org (Postfix) with ESMTP id 0B3DA6B0003 for ; Mon, 9 Mar 2020 00:15:57 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C02A35DE6 for ; Mon, 9 Mar 2020 04:15:56 +0000 (UTC) X-FDA: 76574510712.13.story30_33e46b14c0a09 X-HE-Tag: story30_33e46b14c0a09 X-Filterd-Recvd-Size: 4095 Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Mon, 9 Mar 2020 04:15:56 +0000 (UTC) Received: by mail-pg1-f194.google.com with SMTP id 7so4115488pgr.2 for ; Sun, 08 Mar 2020 21:15:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=jAoReLNBniwrpa0uZH66RQ2ZZJ/sNHlyqQJ+mmk89mc=; b=sBKY5ixcRQOrBOp/pyft+S4zvUPqjKpmc1HKbQidmstpOHLfoLeJUB1bAXwWgVi69/ pj8YKammOpCOOeWyV1Xxbdv/T3MXi30h8eRzLa2mPwqNTAJb+gLZaopAGcW3uUeLI812 dMdtMcbJQ8HRq2UZj1N1Zi+t69UXv6EIX8g1b7sTXNHHrmRvJ2kgfR5MqM/9Y1q8UNof uYQIYzxhqeBGzDigDR6Wn8ClhubyphvMXYhQIXuwUuo4ZO7FrS6xBMn+oQsK1fNrtVtE XddnpDf4RfwwEI/eLAd43eEaVqe2VOWsY1xL8HM6rHNTAq4TaJFBfX8Ext1Sr/dfMQDw xv1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jAoReLNBniwrpa0uZH66RQ2ZZJ/sNHlyqQJ+mmk89mc=; b=en78o8DDrV6V4kMq4mT8T8NExyWv7OkXXXW7tgtu/ZvavWK29aCRtKGdC5ileiSMle hIHUB8pKVP91stbz6MNwCgAfH5sWgvRkZOylqG1U950kMHimeEC2RAlCZgXni25Fzo2u UlXx6142XP5kj+ypUGbC7BcZ+X3w4p/LgBYanjlQsEJlN1CoIosQpVmkciXMgrUC6BhW Y8CvRQ5lgj5R0h3nVmV9BfqISSBZIp1TZSG/7q/4bsfE7txfnpjUIji26cLfBR7Y88t1 g6fVscQgArEDMt88jskcJyEfuf1z3iZvSMIIh95M0VNO3Hr/icjfLqocHBiKmYvb1kq+ e0DQ== X-Gm-Message-State: ANhLgQ1yjTyMDrBEiOGM1GDDr3xDC1yJLQQ/ifyWG4uEFWFucVCf8Dsr eKfCROD4LuO2+gqfT85FR0g= X-Google-Smtp-Source: ADFU+vthYSO4whGtyJkvhi5ehKTwuNj8TmTNW7ywtWsnfm7afsf05M5urNVmcZjEuJEY90+DirFWAQ== X-Received: by 2002:a63:2701:: with SMTP id n1mr14600491pgn.332.1583727355102; Sun, 08 Mar 2020 21:15:55 -0700 (PDT) Received: from localhost ([2a00:79e1:abc:f604:6e29:95ff:fe2d:8f34]) by smtp.gmail.com with ESMTPSA id cq15sm16910709pjb.31.2020.03.08.21.15.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Mar 2020 21:15:54 -0700 (PDT) From: Sergey Senozhatsky X-Google-Original-From: Sergey Senozhatsky Date: Mon, 9 Mar 2020 13:15:51 +0900 To: Joe Perches Cc: Sergey Senozhatsky , Andrew Morton , Johannes Weiner , Michal Hocko , Vladimir Davydov , Hugh Dickins , Minchan Kim , Nitin Gupta , Sergey Senozhatsky , linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [PATCH] mm: Use fallthrough; Message-ID: <20200309041551.GA1765@jagdpanzerIV.localdomain> References: <20200308031825.GB1125@jagdpanzerIV.localdomain> <5f297e8995b22c9ccf06d4d0a04f7d9a37d3cd77.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5f297e8995b22c9ccf06d4d0a04f7d9a37d3cd77.camel@perches.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (20/03/07 19:54), Joe Perches wrote: > On Sun, 2020-03-08 at 12:18 +0900, Sergey Senozhatsky wrote: > > On (20/03/06 23:58), Joe Perches wrote: > > [..] > > > --- a/mm/mempolicy.c > > > +++ b/mm/mempolicy.c > > > @@ -907,7 +907,6 @@ static void get_policy_nodemask(struct mempolicy *p, nodemask_t *nodes) > > > > > > switch (p->mode) { > > > case MPOL_BIND: > > > - /* Fall through */ > > > case MPOL_INTERLEAVE: > > Consecutive case labels do not need an interleaving fallthrough; > > ie: ditto I see. Shall this be mentioned in the commit message, maybe? -ss