From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F21DC10DCE for ; Sun, 8 Mar 2020 13:27:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 308F320828 for ; Sun, 8 Mar 2020 13:27:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gjupkSqH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 308F320828 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A429D6B0005; Sun, 8 Mar 2020 09:27:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F21E6B0006; Sun, 8 Mar 2020 09:27:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B9BF6B0007; Sun, 8 Mar 2020 09:27:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0153.hostedemail.com [216.40.44.153]) by kanga.kvack.org (Postfix) with ESMTP id 712A86B0005 for ; Sun, 8 Mar 2020 09:27:13 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 2B5F9181AC9C6 for ; Sun, 8 Mar 2020 13:27:13 +0000 (UTC) X-FDA: 76572271146.28.face05_4c823d244e62 X-HE-Tag: face05_4c823d244e62 X-Filterd-Recvd-Size: 3574 Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by imf33.hostedemail.com (Postfix) with ESMTP for ; Sun, 8 Mar 2020 13:27:12 +0000 (UTC) Received: by mail-pf1-f194.google.com with SMTP id c144so3574977pfb.10 for ; Sun, 08 Mar 2020 06:27:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=s0MlRVvrbOm/yNbVkkZGrmqkM7hhHith0CEECkjL3hA=; b=gjupkSqHTaxfE3FhcTxeekBxgU6kevIYLFpyi+NIdwMKHGIlNUS6yU/JarRx3zW6ha yN8wzpMpmQwxwmIyV5kElGdYPIn/Svna0EUPPg4CDm29sQvL3+lgevsl0SyJvcR+flyG 0jmuNWSn9dDifQ3JcHISrlYuBmMS3cgLfqL+a0bBdf44RY8ybBp3Q2aShVk/amRAslJB jisxFkPph7xsM6dE0ifkdCaKStokPte1vhkPdnc8YQxDvxXUe6NLG9g5F6p3JlhEG5RE oTqNFWtSnPq1Sqxhd5CBAckoY5LSZ+uCH2DaUt/ITwLUdTKSvmgpKZHNVGj4x8fLJS95 UqNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=s0MlRVvrbOm/yNbVkkZGrmqkM7hhHith0CEECkjL3hA=; b=EwiCa5uX6NKJXGsedYcg7CxBTV6mu6ENCGpXevWxRE78o/la2Ybb9ocoQZqba8Kfrn AHAV0OVfXhYOW1eG0nH3daFdsCR4TsrgwP0VmBSRZRyKm4wGaMOqTwUxtxh/YVyWK/qf kkTv5jPSFq9M5ckO842K3f02yp8OqfstNNqBCbEDAZUBPJbc/gS1dM/XE+Kcn+6zMU9r b8tH6W7wy6CnF1tGt+Clnp8YWLR5I+G6CDw4P9ZUJvQohm1YOLvpBYt76HQbd66XZbTz n6tWIDq4x4HLvcugYBX0BB5v5z3HVWWqTm/uPrb8xHWBdcNGBDgZ6uLG11XNEt7fDgUV Qz4Q== X-Gm-Message-State: ANhLgQ3S0SerpT9Vc0tB5sVMvBc3l34dBPX+aJkzBZJPh5wg9Z+YEw1U RjE2vN8voWNgtBi0wDNY6Vw= X-Google-Smtp-Source: ADFU+vsmhaVn9EzuSu2WSgWYOoRxHJGxhTblg2S5nSdzpCqHcSovbLcHBgdZo8iavJHL2UATnRDQbw== X-Received: by 2002:a63:3712:: with SMTP id e18mr11184192pga.401.1583674031540; Sun, 08 Mar 2020 06:27:11 -0700 (PDT) Received: from localhost ([43.224.245.179]) by smtp.gmail.com with ESMTPSA id u19sm27715638pgf.11.2020.03.08.06.27.10 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Sun, 08 Mar 2020 06:27:11 -0700 (PDT) Date: Sun, 8 Mar 2020 21:27:08 +0800 From: chenqiwu To: Matthew Wilcox Cc: akpm@linux-foundation.org, linux-mm@kvack.org, chenqiwu Subject: Re: [PATCH] mm/page_alloc: use free_area_empty() instead of open-coding Message-ID: <20200308132708.GA7587@cqw-OptiPlex-7050> References: <1583668905-6569-1-git-send-email-qiwuchen55@gmail.com> <20200308122955.GG31215@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200308122955.GG31215@bombadil.infradead.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Mar 08, 2020 at 05:29:55AM -0700, Matthew Wilcox wrote: > On Sun, Mar 08, 2020 at 08:01:45PM +0800, qiwuchen55@gmail.com wrote: > > if (alloc_harder && > > - !list_empty(&area->free_list[MIGRATE_HIGHATOMIC])) > > + !free_area_empty(area, MIGRATE_HIGHATOMIC)) > > I think these can now be one line? > > Also, I think free_area_empty() and a number of related functions can move > from mmzone.h to mm/internal.h. This will benefit all of us since mmzone.h > is included from mm.h and so is widely seen throughout the kernel. I agree. Qiwu