From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C127C10DCE for ; Sun, 8 Mar 2020 12:30:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EA3A120663 for ; Sun, 8 Mar 2020 12:30:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="XgRMmCXv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA3A120663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7D38D6B0005; Sun, 8 Mar 2020 08:30:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 783276B0006; Sun, 8 Mar 2020 08:30:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BF9C6B0007; Sun, 8 Mar 2020 08:30:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 563936B0005 for ; Sun, 8 Mar 2020 08:30:01 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 187AF3ABA for ; Sun, 8 Mar 2020 12:30:01 +0000 (UTC) X-FDA: 76572127002.24.flame87_5771204f0960c X-HE-Tag: flame87_5771204f0960c X-Filterd-Recvd-Size: 2070 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf33.hostedemail.com (Postfix) with ESMTP for ; Sun, 8 Mar 2020 12:30:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=CjVzoleqnN3Z+UKEPmC+EaQiNhXSKOZ+cr58OQCFOrM=; b=XgRMmCXvyNk8P5wxmAFaB+ZuxL ZprORBiCjtAPzxxgLNxf1UW6ymowuZUSPRfB4fvTjHsOVkKX0RdDbd8ljtBIFyk4mccakLg4e8W9d heisBVJwS8fmVbbjCwRxttmhXV4tjYmpX+5jPtai9AAKTxIju7pDRu4c6s8yMouxyu3oKkB5sOQwK QnxyNWWl4wttW3ipsJbb5intMHPyK55kU3Mih86ePJ2NRfeN/vyQ9YEu9vIl8T44LJUX0zYorT8to WpP080G1vhuWymqy1HRHnQEhPyo9o832MbGTvzl0Yz22MRqx0C+d8OI+SuMu1iYUq+lcFp+hz5t5h nJ+7zHoQ==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jAv47-000706-HL; Sun, 08 Mar 2020 12:29:55 +0000 Date: Sun, 8 Mar 2020 05:29:55 -0700 From: Matthew Wilcox To: qiwuchen55@gmail.com Cc: akpm@linux-foundation.org, linux-mm@kvack.org, chenqiwu Subject: Re: [PATCH] mm/page_alloc: use free_area_empty() instead of open-coding Message-ID: <20200308122955.GG31215@bombadil.infradead.org> References: <1583668905-6569-1-git-send-email-qiwuchen55@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1583668905-6569-1-git-send-email-qiwuchen55@gmail.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Mar 08, 2020 at 08:01:45PM +0800, qiwuchen55@gmail.com wrote: > if (alloc_harder && > - !list_empty(&area->free_list[MIGRATE_HIGHATOMIC])) > + !free_area_empty(area, MIGRATE_HIGHATOMIC)) I think these can now be one line? Also, I think free_area_empty() and a number of related functions can move from mmzone.h to mm/internal.h. This will benefit all of us since mmzone.h is included from mm.h and so is widely seen throughout the kernel.