From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23963C10F25 for ; Sun, 8 Mar 2020 03:18:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CF1E8206D5 for ; Sun, 8 Mar 2020 03:18:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ECVc7jtB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CF1E8206D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7EF206B0005; Sat, 7 Mar 2020 22:18:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 79EBB6B0006; Sat, 7 Mar 2020 22:18:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 68E436B0007; Sat, 7 Mar 2020 22:18:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0110.hostedemail.com [216.40.44.110]) by kanga.kvack.org (Postfix) with ESMTP id 4F1DF6B0005 for ; Sat, 7 Mar 2020 22:18:30 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id DD5D88248047 for ; Sun, 8 Mar 2020 03:18:29 +0000 (UTC) X-FDA: 76570737138.13.lock34_4a27c1739133a X-HE-Tag: lock34_4a27c1739133a X-Filterd-Recvd-Size: 4226 Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Sun, 8 Mar 2020 03:18:29 +0000 (UTC) Received: by mail-pl1-f196.google.com with SMTP id f8so2569826plt.10 for ; Sat, 07 Mar 2020 19:18:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=YlUcTsthp1jT+o6f6NANQqT+eCJYTM4ae8wXuy/WzUk=; b=ECVc7jtBxuJMkBzqO7pgWcK0ajgrKB9b5cqpx18D9ofoE0+Ficc+pZhn2tDmOBGhHm ZVhdh2zoNOCi88ZF9Mo22agCA8qknCa0WBHft1UVXwcWfauUh7NKOp6/I5N8oDqe+IbM T7U3/kZubkFdMqZAAwtAY5bGj+38XnBreO/uZR1DDtlVYO46n0vozBkYqPVjnpvuDFV7 FLmKwafHM6gwYy3cQh4knRZVbDOWjPm2cuJUqwGUu1YiWDW+25SfuU+PnbXmL9ww3DQs vqmQJseyhqZ0wb56pQn33955HJBES20I2ZeOIVlmKIWrxHBLCqBE8k8kTO8hR10uL4lq Stdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YlUcTsthp1jT+o6f6NANQqT+eCJYTM4ae8wXuy/WzUk=; b=GY8yr26WKRmwQBYD9Lm99H21/Kg9RKof+A3X7dJ4gP54evKZgB0wcQaH7lQjchzwoy xhv1jzpReUnr3S9ZkVgbyXDMI1kHxSo1N36p7U36rg26XH6XVVGRcqgXxB0ZPnykBc2X +jw95II3mo30TvhtQdA5BnEKhQ6wvTPBTHUbNF/5TjB+7W2SKMsNv9aF5mSTqHwIV5j5 iNvwiKhsEHA4gwSF1c98mEdzjYNOBZJvzuV/7fRkHnmC4oxwBjmyDcgA7ouluFs/ax1K onZkd+NMH+emljVAP8eOQy+ViqZC38q6PVFXJ8xR708He6goVq/2nyy5IxT1e2nc569y Ks3A== X-Gm-Message-State: ANhLgQ2NL5N14hIWdlWjL4XeHmIqSbCLp1rTBUsXWRmcW7kB4LUtgsfa 7MI+Un71/eBMlX9kPj//3bA= X-Google-Smtp-Source: ADFU+vsTZipAN3SvKwN7VtGyO9BLqotNK0eK1y6C+EGAAdE5g2COWd703JhBPJtBCcVT1Sl0cyqrxw== X-Received: by 2002:a17:90b:3542:: with SMTP id lt2mr10788454pjb.96.1583637508436; Sat, 07 Mar 2020 19:18:28 -0800 (PST) Received: from localhost (194.99.30.125.dy.iij4u.or.jp. [125.30.99.194]) by smtp.gmail.com with ESMTPSA id 186sm26726915pfz.145.2020.03.07.19.18.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Mar 2020 19:18:27 -0800 (PST) From: Sergey Senozhatsky X-Google-Original-From: Sergey Senozhatsky Date: Sun, 8 Mar 2020 12:18:25 +0900 To: Joe Perches Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Vladimir Davydov , Hugh Dickins , Minchan Kim , Nitin Gupta , Sergey Senozhatsky , linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [PATCH] mm: Use fallthrough; Message-ID: <20200308031825.GB1125@jagdpanzerIV.localdomain> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (20/03/06 23:58), Joe Perches wrote: [..] > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -907,7 +907,6 @@ static void get_policy_nodemask(struct mempolicy *p, nodemask_t *nodes) > > switch (p->mode) { > case MPOL_BIND: > - /* Fall through */ > case MPOL_INTERLEAVE: > *nodes = p->v.nodes; > break; > @@ -2092,7 +2091,6 @@ bool init_nodemask_of_mempolicy(nodemask_t *mask) > break; > > case MPOL_BIND: > - /* Fall through */ > case MPOL_INTERLEAVE: > *mask = mempolicy->v.nodes; > break; > @@ -2359,7 +2357,6 @@ bool __mpol_equal(struct mempolicy *a, struct mempolicy *b) > > switch (a->mode) { > case MPOL_BIND: > - /* Fall through */ > case MPOL_INTERLEAVE: > return !!nodes_equal(a->v.nodes, b->v.nodes); > case MPOL_PREFERRED: Ditto. This doesn't convert /* Fall through */ to fallthrough; -ss