From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDE62C10F25 for ; Sun, 8 Mar 2020 03:16:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 58C4021739 for ; Sun, 8 Mar 2020 03:16:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gyNFz1js" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 58C4021739 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AFD2E6B0005; Sat, 7 Mar 2020 22:16:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AAD976B0006; Sat, 7 Mar 2020 22:16:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C3176B0007; Sat, 7 Mar 2020 22:16:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0171.hostedemail.com [216.40.44.171]) by kanga.kvack.org (Postfix) with ESMTP id 813286B0005 for ; Sat, 7 Mar 2020 22:16:40 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 185B6180AD806 for ; Sun, 8 Mar 2020 03:16:40 +0000 (UTC) X-FDA: 76570732560.12.yard78_3a2fc2ad42214 X-HE-Tag: yard78_3a2fc2ad42214 X-Filterd-Recvd-Size: 3746 Received: from mail-pj1-f66.google.com (mail-pj1-f66.google.com [209.85.216.66]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Sun, 8 Mar 2020 03:16:39 +0000 (UTC) Received: by mail-pj1-f66.google.com with SMTP id s8so2901017pjq.0 for ; Sat, 07 Mar 2020 19:16:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1Nb+0eCJ+RmZWTIi/A28JTvkScuDbfRdl791J3v1ybU=; b=gyNFz1js4P3o2fO/Z1TjzVYoqZoqx1LLxetnlManqDFo7XnMcpxZihlmGqOGBDbrbo 77+5HSZQ5rEo9o06ipb2DYJpyy97T/f8n8DI1fK/AxVr38p/w5nREwHd8W0C5mwYbo5N fKAq9qk1qOmVlHcc3vCwUU6TJki/1mKOkx5PkdMBkke4PCWhtz6MF5DjrQgBY4aOKiJK bydU0stJCgmMNFiH3vYn6FxdnIhqm8Z2DMGzuuUhNRQV8hLpq/8Y+fqCXmanPBsyFl+o Izra9FkQJisCTFoZ8wuvbg5xqiSD9QehRlKbVOeXqaQbCKuNqxaJvcH+e3kFUa//u061 o3dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1Nb+0eCJ+RmZWTIi/A28JTvkScuDbfRdl791J3v1ybU=; b=jo0F2EhgcGzZLdsOWvsquf980OMkRMbVCwLzYmxBqIEq8DFcf03USQ56BhL5ypalvg TtKP7d5MRhASXXih0Pvko4BusbGV3kaS0ylgHq18BP3GSno9HZdZsuA93xTarbyvD4Vr HCbPxhcnC7St8+L6j0zR2nSgM/FUYIgddoCoxqT8ozZZDBW/hSfveq3+62aLLQLhxFSm ukChDJ6PLuWQwkb+RmjPK1AoTsMYwCN7fimzvST9TG7gdfdp762X7Ou0WLZlPi9xZxwR oqYB/INxc2E8eYZsb09l349WlkKc6zyS0uIUCi4GvF68taDgi5tyCIAMe2iOXa1VnYe3 df+w== X-Gm-Message-State: ANhLgQ3DhwioVDIevYCon3VJC9QBtqZuzTg+w5JcKyDYxU98ZIEJz264 9cKCuiqSU7ud3CFwM0QrWZ0= X-Google-Smtp-Source: ADFU+vts8NPW5NBCO1lUnAWQ7WDcIE6VGZBSRZMrlz6A1oA0ssnEhcatOqsJVHJlRZxqXyJO5QQeDQ== X-Received: by 2002:a17:902:8d8a:: with SMTP id v10mr9810813plo.90.1583637398563; Sat, 07 Mar 2020 19:16:38 -0800 (PST) Received: from localhost (194.99.30.125.dy.iij4u.or.jp. [125.30.99.194]) by smtp.gmail.com with ESMTPSA id s18sm13679394pjp.24.2020.03.07.19.16.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Mar 2020 19:16:37 -0800 (PST) From: Sergey Senozhatsky X-Google-Original-From: Sergey Senozhatsky Date: Sun, 8 Mar 2020 12:16:34 +0900 To: Joe Perches Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Vladimir Davydov , Hugh Dickins , Minchan Kim , Nitin Gupta , Sergey Senozhatsky , linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [PATCH] mm: Use fallthrough; Message-ID: <20200308031634.GA1125@jagdpanzerIV.localdomain> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (20/03/06 23:58), Joe Perches wrote: [..] > --- a/mm/zsmalloc.c > +++ b/mm/zsmalloc.c > @@ -424,7 +424,7 @@ static void *zs_zpool_map(void *pool, unsigned long handle, > case ZPOOL_MM_WO: > zs_mm = ZS_MM_WO; > break; > - case ZPOOL_MM_RW: /* fall through */ > + case ZPOOL_MM_RW: > default: > zs_mm = ZS_MM_RW; > break; Seems like missing fallthrough; for ZPOOL_MM_RW? -ss