From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E44EDC10F25 for ; Sat, 7 Mar 2020 22:55:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 707862070A for ; Sat, 7 Mar 2020 22:55:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ck+sA0a7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 707862070A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C5D1C6B0005; Sat, 7 Mar 2020 17:55:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C0DBD6B0006; Sat, 7 Mar 2020 17:55:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B4A006B0007; Sat, 7 Mar 2020 17:55:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0118.hostedemail.com [216.40.44.118]) by kanga.kvack.org (Postfix) with ESMTP id 9A8346B0005 for ; Sat, 7 Mar 2020 17:55:15 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 79916180AD806 for ; Sat, 7 Mar 2020 22:55:15 +0000 (UTC) X-FDA: 76570073790.09.knot46_6810c217e7b49 X-HE-Tag: knot46_6810c217e7b49 X-Filterd-Recvd-Size: 3737 Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Sat, 7 Mar 2020 22:55:15 +0000 (UTC) Received: by mail-lf1-f68.google.com with SMTP id v6so4636392lfo.13 for ; Sat, 07 Mar 2020 14:55:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=Lmy6sY3BuY2QrfOC8Hp11UcSzO3l1+fu6BuIO/tde+s=; b=Ck+sA0a7Bh2+pT36DNBhLArjI2fLXSF/EZjL9wt60mmEoSudbOckrVquBxL/qTLzaE CO+6bSfYguhj1lGXyoGJMd4YzPlqr3r0xUYL3ABWtqA2OMZk+AuoeBUYnqqe7eR26Mp4 XNVuDgfdBTSaoXmPgx0DoBvrxDcSPNpGifQIkOWWFu7GzHP8yLT9oItbDSuszECtssaw vmEFhWd48gBi9rLYFZPA34FLbW877lQa4TENNPzTA3D08JNTiJR6tctceuEPudp4KUuS FQihQ4KMLKPuOdHkgj4V7G3ze5k8gI5KZ1+EWSyNVhuaBfepmXcgndR9p/y0Xq5UZZnN 9tCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Lmy6sY3BuY2QrfOC8Hp11UcSzO3l1+fu6BuIO/tde+s=; b=Ngu0HOD2ZKIPi9EjuKr/Hj5gCuyLpWJssN/8CgZOniYNTKhbMIqMCxKlDtb9TzC2j6 GDW8nwycW3E7ErCdZst7ZpW7Jtdmks0WA+2UcHPb0ppbAUwYuoHfNVHm6z3gQK7hg/Dw r5xMheje0kg76x9lvVutbrtbTaum90xwLeAQyabPEviNOLYSgcTHqqVIh+URn0vR8j1/ hc+UgktsZ5cxWUpWYztcb+C7QXrl6M0UaZiV74hphjWAjJtlrwaHyWZoyq1FeERa4r7c iZyYjf6Ea+0Bwv7dQ3oFWDzLCphsIAyAyHrMo1qtKjAD9EcV6WPpcMH+Xdh2O++vIGqt POLw== X-Gm-Message-State: ANhLgQ0VIv9dT/LkNniCN7WgDXigK+ND7y4dijfqfZE9RoF4c2HFAtrP 5nB9uLjn0tZgvy+cfo1gUtDYgg5Y X-Google-Smtp-Source: ADFU+vvWUa6/pPaqj/uFb25zlxb/uzdMqLjlzAPRBdX5/0+xW5Z9ge5inaMikdZA35Gr9e9M+fQe3Q== X-Received: by 2002:a05:6512:3089:: with SMTP id z9mr193983lfd.15.1583621713144; Sat, 07 Mar 2020 14:55:13 -0800 (PST) Received: from localhost.localdomain (188.146.98.10.nat.umts.dynamic.t-mobile.pl. [188.146.98.10]) by smtp.gmail.com with ESMTPSA id v10sm19777324lfb.61.2020.03.07.14.55.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Mar 2020 14:55:12 -0800 (PST) From: mateusznosek0@gmail.com To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Mateusz Nosek , akpm@linux-foundation.org Subject: [RFC PATCH] mm/page_alloc.c: Micro-optimisation Remove unnecessary branch Date: Sat, 7 Mar 2020 23:53:35 +0100 Message-Id: <20200307225335.31300-1-mateusznosek0@gmail.com> X-Mailer: git-send-email 2.17.1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.036134, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Mateusz Nosek Previously if branch condition was false, the assignment was not executed. The assignment can be safely executed even when the condition is false and it is not incorrect as it assigns the value of 'nodemask' to 'ac.nodemask' which already has the same value. So as the assignment can be executed unconditionally, the branch can be removed. Signed-off-by: Mateusz Nosek --- mm/page_alloc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 79e950d76ffc..75456d04b5c5 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -4819,8 +4819,7 @@ __alloc_pages_nodemask(gfp_t gfp_mask, unsigned int order, int preferred_nid, * Restore the original nodemask if it was potentially replaced with * &cpuset_current_mems_allowed to optimize the fast-path attempt. */ - if (unlikely(ac.nodemask != nodemask)) - ac.nodemask = nodemask; + ac.nodemask = nodemask; page = __alloc_pages_slowpath(alloc_mask, order, &ac); -- 2.17.1