From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 071ABC3F2D7 for ; Thu, 5 Mar 2020 18:36:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C101020705 for ; Thu, 5 Mar 2020 18:36:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="RR6nLtAN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C101020705 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chrisdown.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 69B4D6B0005; Thu, 5 Mar 2020 13:36:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 64BC96B0006; Thu, 5 Mar 2020 13:36:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 562686B0007; Thu, 5 Mar 2020 13:36:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0164.hostedemail.com [216.40.44.164]) by kanga.kvack.org (Postfix) with ESMTP id 425DA6B0005 for ; Thu, 5 Mar 2020 13:36:17 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 2117F180AD801 for ; Thu, 5 Mar 2020 18:36:17 +0000 (UTC) X-FDA: 76562163594.19.hat42_36d76c7204912 X-HE-Tag: hat42_36d76c7204912 X-Filterd-Recvd-Size: 4405 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Thu, 5 Mar 2020 18:36:16 +0000 (UTC) Received: by mail-wr1-f66.google.com with SMTP id j16so8297000wrt.3 for ; Thu, 05 Mar 2020 10:36:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=NuoA3fuPswQR3q6MZEyPSq0NTYh8WVfp4GhRULEWRIY=; b=RR6nLtANxW9IiN4v3USYLxGNCnrYUqcerZ41dSbNfgtylvE//xJdTrZEBL+kNgm39E GW38qiN3bLqBFwcftKaWbuQrsZfUGSiWHD1yTQOF/wl6lElGraB+5LU/2usxQN+DFhcE oci1LJb9PY8XkR1F4BEGDEgap7+++0Iv12xcc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=NuoA3fuPswQR3q6MZEyPSq0NTYh8WVfp4GhRULEWRIY=; b=Xjqd1G72PVQwxU4ivaMle7nMdx9QArRogAvN3I56df65oeqwoYKjDtNkpdfKFUQkQ+ zh3Vi+mm6xvhwkNpXrBLZj3EHuUO16h6rsrtJQCxcxcHVoii0cVwscHKK1qcQ4GpBmOY 80G18/Hqh4omp/YCaaNiZS3LRflQhems9fgi+701iLMwYujkrrFmL/5Rjq3hSf0CZxrv acEZSKmEGxFqS8T0rh53ZtQ27ZMb3NQmYtC/kWLttg9eLgTrQj7b+9eMJIat7aECoHTS 1WGmNCy+YsXzVuNSSsi1ADypoZrBiY7ydYMs3iOWmQeDq6XfCrqGz1JlTLQN82oOLnuX ZviA== X-Gm-Message-State: ANhLgQ1nT28EOZhHfk2Smgs9Vc55QgoAFxZ+Nw5Mzl1qOJUWaAQAbh7N fYjGwEJ4uE8XIBlnGImZHOqJlQ== X-Google-Smtp-Source: ADFU+vtdNZNZmPNSsajXjWtBz/3Labc+zWb3NvUh2WOyO/hINkn6LFD5bSu91HFy6qp5a616NzYT4w== X-Received: by 2002:a05:6000:100d:: with SMTP id a13mr258226wrx.330.1583433375392; Thu, 05 Mar 2020 10:36:15 -0800 (PST) Received: from localhost ([2620:10d:c092:180::1:6808]) by smtp.gmail.com with ESMTPSA id x17sm5432831wrt.31.2020.03.05.10.36.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2020 10:36:15 -0800 (PST) Date: Thu, 5 Mar 2020 18:36:14 +0000 From: Chris Down To: Vincenzo Frascino Cc: cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton Subject: Re: [PATCH v2] mm: Make mem_cgroup_id_get_many() __maybe_unused Message-ID: <20200305183614.GB752201@chrisdown.name> References: <20200305164354.48147-1-vincenzo.frascino@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline In-Reply-To: <20200305164354.48147-1-vincenzo.frascino@arm.com> Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Vincenzo Frascino writes: >mem_cgroup_id_get_many() is currently used only when MMU or MEMCG_SWAP >configuration options are enabled. Having them disabled triggers the >following warning at compile time: > >linux/mm/memcontrol.c:4797:13: warning: =E2=80=98mem_cgroup_id_get_many=E2= =80=99 defined >but not used [-Wunused-function] > static void mem_cgroup_id_get_many(struct mem_cgroup *memcg, unsigned > int n) > >Make mem_cgroup_id_get_many() __maybe_unused to address the issue. > >Cc: Johannes Weiner >Cc: Michal Hocko >Cc: Vladimir Davydov >Cc: Andrew Morton >Signed-off-by: Vincenzo Frascino Thanks, I didn't notice you've already posted it before replying on v1 :-= ) Acked-by: Chris Down >--- > mm/memcontrol.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/mm/memcontrol.c b/mm/memcontrol.c >index d09776cd6e10..2b9533ed52f5 100644 >--- a/mm/memcontrol.c >+++ b/mm/memcontrol.c >@@ -4794,7 +4794,8 @@ static void mem_cgroup_id_remove(struct mem_cgroup= *memcg) > } > } > >-static void mem_cgroup_id_get_many(struct mem_cgroup *memcg, unsigned i= nt n) >+static void __maybe_unused mem_cgroup_id_get_many(struct mem_cgroup *me= mcg, >+ unsigned int n) > { > refcount_add(n, &memcg->id.ref); > } >--=20 >2.25.1 > >