From: Michal Hocko <mhocko@kernel.org>
To: Vincenzo Frascino <vincenzo.frascino@arm.com>
Cc: cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Johannes Weiner <hannes@cmpxchg.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mm: Make mem_cgroup_id_get_many dependent on MMU and MEMCG_SWAP
Date: Thu, 5 Mar 2020 11:00:23 +0100 [thread overview]
Message-ID: <20200305100023.GR16139@dhcp22.suse.cz> (raw)
In-Reply-To: <8c489836-b824-184e-7cfe-25e55ab73000@arm.com>
On Thu 05-03-20 09:49:23, Vincenzo Frascino wrote:
> Hi Michal,
>
> On 3/4/20 4:53 PM, Michal Hocko wrote:
> > On Wed 04-03-20 14:23:48, Vincenzo Frascino wrote:
> >> mem_cgroup_id_get_many() is currently used only when MMU or MEMCG_SWAP
> >> configuration options are enabled. Having them disabled triggers the
> >> following warning at compile time:
> >>
> >> linux/mm/memcontrol.c:4797:13: warning: ‘mem_cgroup_id_get_many’ defined
> >> but not used [-Wunused-function]
> >> static void mem_cgroup_id_get_many(struct mem_cgroup *memcg, unsigned
> >> int n)
> >>
> >> Make mem_cgroup_id_get_many() dependent on MMU and MEMCG_SWAP to address
> >> the issue.
> >
> > A similar patch has been proposed recently
> > http://lkml.kernel.org/r/87fthjh2ib.wl-kuninori.morimoto.gx@renesas.com.
> > The conclusion was that the warning is not really worth adding code.
> >
>
> Thank you for pointing this out, I was not aware of it. I understand that you
> are against "#ifdeffery" in this case, but isn't it the case of adding at least
> __maybe_unused? This would prevent people from reporting it over and over again
> and you to have to push them back :) Let me know what do you think, in case I am
> happy to change my patch accordingly.
We have discussed __maybe_unused in the email thread as well. I am not a
great fan of that as mentioed there.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2020-03-05 10:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 14:23 Vincenzo Frascino
2020-03-04 16:53 ` Michal Hocko
2020-03-05 9:49 ` Vincenzo Frascino
2020-03-05 10:00 ` Michal Hocko [this message]
2020-03-05 10:46 ` Vincenzo Frascino
2020-03-05 14:18 ` Michal Hocko
2020-03-05 16:09 ` Johannes Weiner
2020-03-05 16:21 ` Vincenzo Frascino
2020-03-05 18:34 ` Chris Down
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200305100023.GR16139@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vdavydov.dev@gmail.com \
--cc=vincenzo.frascino@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox