From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5703BC3F2CE for ; Wed, 4 Mar 2020 20:38:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2307021741 for ; Wed, 4 Mar 2020 20:38:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="CV3tHRwr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2307021741 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D0E556B0003; Wed, 4 Mar 2020 15:38:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CBE456B0005; Wed, 4 Mar 2020 15:38:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BFB496B0007; Wed, 4 Mar 2020 15:38:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0043.hostedemail.com [216.40.44.43]) by kanga.kvack.org (Postfix) with ESMTP id A9A686B0003 for ; Wed, 4 Mar 2020 15:38:34 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 43C6D40E1 for ; Wed, 4 Mar 2020 20:38:34 +0000 (UTC) X-FDA: 76558842948.01.use31_2da87d43b2331 X-HE-Tag: use31_2da87d43b2331 X-Filterd-Recvd-Size: 1735 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Wed, 4 Mar 2020 20:38:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=SVkvjM1MPfhLD+3fBtgZoSoUtIpJPCdgmmmpu7MmHF0=; b=CV3tHRwrljymamNDaIucuInZ8k OCkLLCqRlbum2LQK9XKLqUQIp9xHAHggUZEza7iRW7oaSIxo/x2G36efPKJdjaMImBeZXFwDKrp9H P/znjhu4oGam1R8YHbt/kmKwoOU22H1am2MbBVItrcINTQICbzgnkZJi/FIO6cml/M1bw7E3cKOrh l8vlBlrCufCfBfPlD5XwoCt3sEyak4EwQqxlBrMpWYsr828dJityneutfWVCJXV4Ly6cmgv4l/Flo KqlK/pKxNXjjfLd+KICrGpgGbOhQowrvSH4zJ3Mpmx2UsvsHnQUh4n9E/MZzmqsq1rNfhZcSkNmeB 9k54eyCw==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1j9amh-00064m-L0; Wed, 04 Mar 2020 20:38:27 +0000 Date: Wed, 4 Mar 2020 12:38:27 -0800 From: Matthew Wilcox To: Adam Jackson Cc: linux-mm@kvack.org Subject: Re: [PATCH] mm/vmscan: Prioritize anonymous executable pages like we do file-backed Message-ID: <20200304203827.GK29971@bombadil.infradead.org> References: <20200304203235.3623103-1-ajax@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200304203235.3623103-1-ajax@redhat.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 04, 2020 at 03:32:35PM -0500, Adam Jackson wrote: > - if ((vm_flags & VM_EXEC) && page_is_file_cache(page)) { > + if ((vm_flags & VM_EXEC)) { You can drop one set of parens here