From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11A07C3F2D1 for ; Wed, 4 Mar 2020 16:53:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D27CB215A4 for ; Wed, 4 Mar 2020 16:53:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D27CB215A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 442036B0003; Wed, 4 Mar 2020 11:53:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CBA16B0005; Wed, 4 Mar 2020 11:53:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 293316B0007; Wed, 4 Mar 2020 11:53:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0054.hostedemail.com [216.40.44.54]) by kanga.kvack.org (Postfix) with ESMTP id 0BB5B6B0003 for ; Wed, 4 Mar 2020 11:53:45 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 81E612DFA for ; Wed, 4 Mar 2020 16:53:44 +0000 (UTC) X-FDA: 76558276368.13.girl52_77f1bf657c600 X-HE-Tag: girl52_77f1bf657c600 X-Filterd-Recvd-Size: 4084 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Wed, 4 Mar 2020 16:53:44 +0000 (UTC) Received: by mail-wm1-f68.google.com with SMTP id a132so2914221wme.1 for ; Wed, 04 Mar 2020 08:53:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=9rthIHoO9WYjIeblpibGccs1Xx6gpCOxnW4ZP2a/gaI=; b=ViE02/GhLRVI2KsCzELF0KAdDUozgaWP81WyivrwsPiICxjBeBQcirVVqRSPw+3vWv HX90MYezgnVm3K7XQ0PLbd6jqMX8pg1XC4fz6dM7NUGRPL7UZCQAoxI0gIYsUCMBNdyt T/9fhqcrgYIcULVjfowpicB/6z6wzjnpTe7VLfioXtftERfHdvmzWUJl8b2gxdWt0d+5 Hn1uw2UNv3WrnNnLrEa5MjpcdjWp3yRjVabV715wI4fuy8HR2CGzbj21t2lerfNi4Q8F d4FxE/u/OqiPqhY6udyGXvrCxCWV09Enxl7FjziP646ILPcT8xLVyx304YFdngzoenLr RV7A== X-Gm-Message-State: ANhLgQ0oPBtaRmtoLcveKhLeIvIyGhwQpQ39MsGhky5wPsYtP7oKI9PP FqeAU0MLFsMWvZzv6TeK9ds= X-Google-Smtp-Source: ADFU+vvadTAwlgWmHKFUQufY81fr5wffpBTL2DPa8yHmyED8QcKerjwMWDGiTqW5s9WFSaAyOPO1qg== X-Received: by 2002:a1c:2d4f:: with SMTP id t76mr4412820wmt.60.1583340819177; Wed, 04 Mar 2020 08:53:39 -0800 (PST) Received: from localhost (ip-37-188-250-99.eurotel.cz. [37.188.250.99]) by smtp.gmail.com with ESMTPSA id n11sm6649329wrw.11.2020.03.04.08.53.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2020 08:53:38 -0800 (PST) Date: Wed, 4 Mar 2020 17:53:36 +0100 From: Michal Hocko To: Vincenzo Frascino Cc: cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Johannes Weiner , Vladimir Davydov , Andrew Morton Subject: Re: [PATCH] mm: Make mem_cgroup_id_get_many dependent on MMU and MEMCG_SWAP Message-ID: <20200304165336.GO16139@dhcp22.suse.cz> References: <20200304142348.48167-1-vincenzo.frascino@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200304142348.48167-1-vincenzo.frascino@arm.com> Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 04-03-20 14:23:48, Vincenzo Frascino wrote: > mem_cgroup_id_get_many() is currently used only when MMU or MEMCG_SWAP > configuration options are enabled. Having them disabled triggers the > following warning at compile time: >=20 > linux/mm/memcontrol.c:4797:13: warning: =E2=80=98mem_cgroup_id_get_many= =E2=80=99 defined > but not used [-Wunused-function] > static void mem_cgroup_id_get_many(struct mem_cgroup *memcg, unsigned > int n) >=20 > Make mem_cgroup_id_get_many() dependent on MMU and MEMCG_SWAP to addres= s > the issue. A similar patch has been proposed recently http://lkml.kernel.org/r/87fthjh2ib.wl-kuninori.morimoto.gx@renesas.com. The conclusion was that the warning is not really worth adding code. > Cc: Johannes Weiner > Cc: Michal Hocko > Cc: Vladimir Davydov > Cc: Andrew Morton > Signed-off-by: Vincenzo Frascino > --- > mm/memcontrol.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index d09776cd6e10..628cebeb4bdd 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -4794,10 +4794,12 @@ static void mem_cgroup_id_remove(struct mem_cgr= oup *memcg) > } > } > =20 > +#if defined(CONFIG_MEMCG_SWAP) || defined(CONFIG_MMU) > static void mem_cgroup_id_get_many(struct mem_cgroup *memcg, unsigned = int n) > { > refcount_add(n, &memcg->id.ref); > } > +#endif > =20 > static void mem_cgroup_id_put_many(struct mem_cgroup *memcg, unsigned = int n) > { > --=20 > 2.25.1 --=20 Michal Hocko SUSE Labs