From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0FE4C3F2D1 for ; Wed, 4 Mar 2020 15:45:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id ACFF3215A4 for ; Wed, 4 Mar 2020 15:45:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="HVNocEWc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ACFF3215A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3FFB66B0003; Wed, 4 Mar 2020 10:45:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B0856B0005; Wed, 4 Mar 2020 10:45:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29EE16B0006; Wed, 4 Mar 2020 10:45:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0108.hostedemail.com [216.40.44.108]) by kanga.kvack.org (Postfix) with ESMTP id 0E02E6B0003 for ; Wed, 4 Mar 2020 10:45:43 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 6D31B4DBD for ; Wed, 4 Mar 2020 15:45:42 +0000 (UTC) X-FDA: 76558104924.02.end53_6bef7c8195e5b X-HE-Tag: end53_6bef7c8195e5b X-Filterd-Recvd-Size: 5537 Received: from userp2120.oracle.com (userp2120.oracle.com [156.151.31.85]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Wed, 4 Mar 2020 15:45:41 +0000 (UTC) Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 024Fcxht136784; Wed, 4 Mar 2020 15:45:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=5R0S7uIbNZ//QmYKr6djkngdjgqrJsZKHvkfc8zEFoo=; b=HVNocEWcrpek7+5OjIjM1SQOqL1ZOdOl5/HF7VD/T479MNSOd0oCg5A9R5RasrBYGf03 zCWfiKThvqT71ZleEvkydgqqrkwn5Ci7ntCaI26TKsjfGzZt6HgaSzV3Py+szSyKjbPZ avkYPUp9E+/S6KoNW9yIBSqR9xch+PsQrvV1WfYdMPF0zOqufFmJhZP4mfNuuUJgUPvW f7LoSowUWA5N5UMmhXh4M13pm9pfy1xr+U7dkmyYfi+zAAYZJOVyobwVd8xRqMioy+Vz Hf6ZXMB8AmoRtk9/bqBazkFk0kV+LG1jv4eZC+Q0pLQ32i2YPBhGJZuQAmJ475Fyl4n8 aQ== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 2yghn3aw73-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 Mar 2020 15:45:32 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 024Fgphw173547; Wed, 4 Mar 2020 15:45:32 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3020.oracle.com with ESMTP id 2yg1rrb65j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 Mar 2020 15:45:31 +0000 Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 024FjSWa014082; Wed, 4 Mar 2020 15:45:28 GMT Received: from localhost (/67.169.218.210) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 04 Mar 2020 07:45:27 -0800 Date: Wed, 4 Mar 2020 07:45:26 -0800 From: "Darrick J. Wong" To: Domenico Andreoli Cc: "Rafael J. Wysocki" , Linux PM , Linux Memory Management List , linux-fsdevel@vger.kernel.org, mkleinsoft@gmail.com, Christoph Hellwig , Andrew Morton , "Rafael J. Wysocki" , Len Brown , Pavel Machek Subject: Re: [PATCH] hibernate: Allow uswsusp to write to swap Message-ID: <20200304154526.GH8036@magnolia> References: <20200229170825.GX8045@magnolia> <20200229180716.GA31323@dumbo> <20200229183820.GA8037@magnolia> <20200229200200.GA10970@dumbo> <20200303190212.GC8037@magnolia> <9E4A0457-39B1-45E2-AEA2-22C730BF2C4F@gmail.com> <20200304011840.GD1752567@magnolia> <20200304082327.GA14236@dumbo> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200304082327.GA14236@dumbo> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9549 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 mlxlogscore=999 suspectscore=0 malwarescore=0 adultscore=0 spamscore=0 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2003040115 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9549 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0 spamscore=0 impostorscore=0 mlxscore=0 adultscore=0 mlxlogscore=999 lowpriorityscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2003040115 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 04, 2020 at 09:23:27AM +0100, Domenico Andreoli wrote: > From: Domenico Andreoli > > It turns out that there is one use case for programs being able to > write to swap devices, and that is the userspace hibernation code. You might want to start a separate thread for this... :) > Quick fix: disable the S_SWAPFILE check if hibernation is configured. > > Fixes: 1638045c3677 ("mm: set S_SWAPFILE on blockdev swap devices") Also, this should be Fixes: dc617f29dbe5 ("vfs: don't allow writes to swap files") since we still want to set S_SWAPFILE on active swap devices. > Reported-by: Domenico Andreoli > Reported-by: Marian Klein > Signed-off-by: Domenico Andreoli > > --- > fs/block_dev.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > Index: b/fs/block_dev.c > =================================================================== > --- a/fs/block_dev.c > +++ b/fs/block_dev.c > @@ -2001,7 +2001,8 @@ ssize_t blkdev_write_iter(struct kiocb * > if (bdev_read_only(I_BDEV(bd_inode))) > return -EPERM; > > - if (IS_SWAPFILE(bd_inode)) > + /* uswsusp needs to write to the swap */ > + if (IS_SWAPFILE(bd_inode) && !IS_ENABLED(CONFIG_HIBERNATION)) ...&& hibernation_available() ? That way we can configure this dynamically. Thanks for taking this on, I'll go self-NAK the revert patch I sent yesterday. --D > return -ETXTBSY; > > if (!iov_iter_count(from))