From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B23BC3F2D1 for ; Wed, 4 Mar 2020 14:24:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D916520866 for ; Wed, 4 Mar 2020 14:24:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D916520866 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 74A6C6B0006; Wed, 4 Mar 2020 09:24:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6FAAA6B0005; Wed, 4 Mar 2020 09:24:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C2EA6B0007; Wed, 4 Mar 2020 09:24:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0128.hostedemail.com [216.40.44.128]) by kanga.kvack.org (Postfix) with ESMTP id 466456B0005 for ; Wed, 4 Mar 2020 09:24:05 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id E38B68248047 for ; Wed, 4 Mar 2020 14:24:04 +0000 (UTC) X-FDA: 76557899208.07.key74_7ae483b728823 X-HE-Tag: key74_7ae483b728823 X-Filterd-Recvd-Size: 2517 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Wed, 4 Mar 2020 14:24:04 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BC3FF31B; Wed, 4 Mar 2020 06:24:03 -0800 (PST) Received: from e119884-lin.cambridge.arm.com (e119884-lin.cambridge.arm.com [10.1.196.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9D5D63F6CF; Wed, 4 Mar 2020 06:24:02 -0800 (PST) From: Vincenzo Frascino To: cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Vincenzo Frascino , Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton Subject: [PATCH] mm: Make mem_cgroup_id_get_many dependent on MMU and MEMCG_SWAP Date: Wed, 4 Mar 2020 14:23:48 +0000 Message-Id: <20200304142348.48167-1-vincenzo.frascino@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: mem_cgroup_id_get_many() is currently used only when MMU or MEMCG_SWAP configuration options are enabled. Having them disabled triggers the following warning at compile time: linux/mm/memcontrol.c:4797:13: warning: =E2=80=98mem_cgroup_id_get_many=E2= =80=99 defined but not used [-Wunused-function] static void mem_cgroup_id_get_many(struct mem_cgroup *memcg, unsigned int n) Make mem_cgroup_id_get_many() dependent on MMU and MEMCG_SWAP to address the issue. Cc: Johannes Weiner Cc: Michal Hocko Cc: Vladimir Davydov Cc: Andrew Morton Signed-off-by: Vincenzo Frascino --- mm/memcontrol.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index d09776cd6e10..628cebeb4bdd 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -4794,10 +4794,12 @@ static void mem_cgroup_id_remove(struct mem_cgrou= p *memcg) } } =20 +#if defined(CONFIG_MEMCG_SWAP) || defined(CONFIG_MMU) static void mem_cgroup_id_get_many(struct mem_cgroup *memcg, unsigned in= t n) { refcount_add(n, &memcg->id.ref); } +#endif =20 static void mem_cgroup_id_put_many(struct mem_cgroup *memcg, unsigned in= t n) { --=20 2.25.1