From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81214C3F2CD for ; Wed, 4 Mar 2020 12:32:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4C24620838 for ; Wed, 4 Mar 2020 12:32:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C24620838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C5ABC6B0003; Wed, 4 Mar 2020 07:32:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BE3E86B0005; Wed, 4 Mar 2020 07:32:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD2F46B0006; Wed, 4 Mar 2020 07:32:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0030.hostedemail.com [216.40.44.30]) by kanga.kvack.org (Postfix) with ESMTP id 9170B6B0003 for ; Wed, 4 Mar 2020 07:32:20 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 139D6181AEF0B for ; Wed, 4 Mar 2020 12:32:20 +0000 (UTC) X-FDA: 76557617640.13.trade57_145a33e476b5c X-HE-Tag: trade57_145a33e476b5c X-Filterd-Recvd-Size: 3148 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Wed, 4 Mar 2020 12:32:19 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id r17so2168983wrj.7 for ; Wed, 04 Mar 2020 04:32:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oOoIMe4ipuObrP+M1ytu6BXg4FmUGi1YFKtc9FzmxHk=; b=tZ5BV1aTD4UL1hf2PY4/eDZUEfUJ3FB1MlDpVJ7JpiaOqE53KiQ/ukdwVu+DirE2j7 aPawyRujoqh0BsUeY9zNWqTJBWIAh6PbW572tB+XzYG2Sp+Tmf1kFednacIZpjfVFwQn CRXSGYE+l7O+wrf3Ahj4o9+B04nI6Ob9TkSu5b1ojQQxPyPplGCr/kILfbDMvdV2HOpA hIaLgR8Zv37EOWaU9kDHpxnefiicV9xxykYv58MAt1lnZa/RmcFJWCXKD0dTv8g8Fg/2 Qp3y3f8aZ4nZljtS7YYpSjmuCdK39A49FBmUAULNwqfxwfgYfCqUvZ/yzOgvSoolpW1s iI9A== X-Gm-Message-State: ANhLgQ0YNM3BS7ZRE1qYqs+jBp9zkWa486C9/Hib9CWjRvAiHwv4K0oF FBWLhIGtq74hjrWF/kdI9EI= X-Google-Smtp-Source: ADFU+vu2v6UTlvfB5gN7rglYo5YNbLmHFipxXKL6wWNpjacyXl05jHGXC9Tow/qo/wLCBkMUNsWsHQ== X-Received: by 2002:a5d:6141:: with SMTP id y1mr3739043wrt.146.1583325138786; Wed, 04 Mar 2020 04:32:18 -0800 (PST) Received: from localhost (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id i204sm4029964wma.44.2020.03.04.04.32.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2020 04:32:17 -0800 (PST) Date: Wed, 4 Mar 2020 13:32:17 +0100 From: Michal Hocko To: Shakeel Butt Cc: Roman Gushchin , Johannes Weiner , Andrew Morton , Linux MM , Cgroups , LKML Subject: Re: [PATCH v2] memcg: css_tryget_online cleanups Message-ID: <20200304123217.GK16139@dhcp22.suse.cz> References: <20200302203109.179417-1-shakeelb@google.com> <20200303093251.GD4380@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 03-03-20 15:49:41, Shakeel Butt wrote: > On Tue, Mar 3, 2020 at 1:32 AM Michal Hocko wrote: [...] > > Could you be more specific about the swap in case please? > > > > With swap accounting enabled, if the memcg of the swapped out page is > not online then the memcg extracted from the given 'mm' will be > charged and if 'mm' is NULL then root memcg will be charged. However I > could not find a code path where the given 'mm' will be NULL for > swap-in case. Yes, this is my understanding as well. All the paths are getting mm from a vma AFAICS. This is a valuable information for the changelog. -- Michal Hocko SUSE Labs