From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0D00C3F2D1 for ; Wed, 4 Mar 2020 09:25:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9391E20732 for ; Wed, 4 Mar 2020 09:25:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9391E20732 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 40D636B0005; Wed, 4 Mar 2020 04:25:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3BE3A6B0006; Wed, 4 Mar 2020 04:25:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D3906B0007; Wed, 4 Mar 2020 04:25:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0111.hostedemail.com [216.40.44.111]) by kanga.kvack.org (Postfix) with ESMTP id 157E26B0005 for ; Wed, 4 Mar 2020 04:25:44 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A9EBD23112 for ; Wed, 4 Mar 2020 09:25:43 +0000 (UTC) X-FDA: 76557147366.14.wren66_894239e9afe46 X-HE-Tag: wren66_894239e9afe46 X-Filterd-Recvd-Size: 2450 Received: from Galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Wed, 4 Mar 2020 09:25:43 +0000 (UTC) Received: from bigeasy by Galois.linutronix.de with local (Exim 4.80) (envelope-from ) id 1j9QHb-0007pN-KO; Wed, 04 Mar 2020 10:25:39 +0100 Date: Wed, 4 Mar 2020 10:25:39 +0100 From: Sebastian Andrzej Siewior To: Vlastimil Babka Cc: Andrew Morton , linux-mm@kvack.org, Thomas Gleixner , Luis Chamberlain , Kees Cook , Iurii Zaikin , Mel Gorman , Linux API Subject: Re: [PATCH 2/2 v3] mm/compaction: Disable compact_unevictable_allowed on RT Message-ID: <20200304092539.tku4tuvlzvrmfnep@linutronix.de> References: <20200115161035.893221-1-bigeasy@linutronix.de> <4cf4507b-0632-34e6-5985-df933559af9f@suse.cz> <20200302173516.iysuejilava37psk@linutronix.de> <20200302132531.59a2c9dffe2515d78abaf909@linux-foundation.org> <20200303175910.ichnkjkgmz5y2ipb@linutronix.de> <20200303202054.gsosv7fsx2ma3cic@linutronix.de> <20200303202225.nhqc3v5gwlb7x6et@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2020-03-04 09:18:21 [+0100], Vlastimil Babka wrote: > > @@ -2572,6 +2577,26 @@ int proc_dointvec(struct ctl_table *table, int w= rite, > > return do_proc_dointvec(table, write, buffer, lenp, ppos, NULL, NULL); > > } > > =20 > > +#ifdef CONFIG_COMPACTION > > +static int proc_dointvec_warn_RT_change(struct ctl_table *table, int w= rite, > > + void __user *buffer, size_t *lenp, > > + loff_t *ppos) > > +{ > > + int ret, old; > > + > > + if (!IS_ENABLED(CONFIG_PREEMPT_RT) || !write) > > + return proc_dointvec(table, write, buffer, lenp, ppos); >=20 > Shouldn't you use her proc_dointvec_minmax() per Patch 1/2 ? >=20 > > + > > + old =3D *(int *)table->data; > > + ret =3D proc_dointvec(table, write, buffer, lenp, ppos); >=20 > And here. Yes, thank you for noticing. It didn't make from editor to disk after rebasing=E2=80=A6 Sebastian