From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Thomas Gleixner <tglx@linutronix.de>,
Luis Chamberlain <mcgrof@kernel.org>,
Kees Cook <keescook@chromium.org>,
Iurii Zaikin <yzaikin@google.com>,
Mel Gorman <mgorman@techsingularity.net>,
Linux API <linux-api@vger.kernel.org>
Subject: Re: [PATCH 2/2 v3] mm/compaction: Disable compact_unevictable_allowed on RT
Date: Wed, 4 Mar 2020 10:25:39 +0100 [thread overview]
Message-ID: <20200304092539.tku4tuvlzvrmfnep@linutronix.de> (raw)
In-Reply-To: <f3a9d2ce-1e19-c4cb-3c53-9e118ebc86fb@suse.cz>
On 2020-03-04 09:18:21 [+0100], Vlastimil Babka wrote:
> > @@ -2572,6 +2577,26 @@ int proc_dointvec(struct ctl_table *table, int write,
> > return do_proc_dointvec(table, write, buffer, lenp, ppos, NULL, NULL);
> > }
> >
> > +#ifdef CONFIG_COMPACTION
> > +static int proc_dointvec_warn_RT_change(struct ctl_table *table, int write,
> > + void __user *buffer, size_t *lenp,
> > + loff_t *ppos)
> > +{
> > + int ret, old;
> > +
> > + if (!IS_ENABLED(CONFIG_PREEMPT_RT) || !write)
> > + return proc_dointvec(table, write, buffer, lenp, ppos);
>
> Shouldn't you use her proc_dointvec_minmax() per Patch 1/2 ?
>
> > +
> > + old = *(int *)table->data;
> > + ret = proc_dointvec(table, write, buffer, lenp, ppos);
>
> And here.
Yes, thank you for noticing. It didn't make from editor to disk after
rebasing…
Sebastian
next prev parent reply other threads:[~2020-03-04 9:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 16:10 [PATCH] " Sebastian Andrzej Siewior
2020-01-15 22:04 ` Vlastimil Babka
2020-01-16 10:22 ` Sebastian Andrzej Siewior
2020-03-02 17:35 ` [PATCH v2] " Sebastian Andrzej Siewior
2020-03-02 21:25 ` Andrew Morton
2020-03-03 17:59 ` Sebastian Andrzej Siewior
2020-03-03 20:20 ` [PATCH 1/2] =?UTF-8?q?mm/compaction:=20Really=20limit=20compact?= =?UTF-8?q?=5Funevictable=5Fallowed=20to=200=E2=80=A61?= Sebastian Andrzej Siewior
2020-03-03 20:22 ` [PATCH 2/2 v3] mm/compaction: Disable compact_unevictable_allowed on RT Sebastian Andrzej Siewior
2020-03-03 23:56 ` Andrew Morton
2020-03-04 8:19 ` Vlastimil Babka
2020-03-04 9:27 ` Sebastian Andrzej Siewior
2020-03-19 16:39 ` [PATCH 2/2 v4] " Sebastian Andrzej Siewior
2020-03-19 16:49 ` Vlastimil Babka
2020-03-19 16:55 ` [PATCH 2/2 v5] " Sebastian Andrzej Siewior
2020-03-04 8:18 ` [PATCH 2/2 v3] " Vlastimil Babka
2020-03-04 9:25 ` Sebastian Andrzej Siewior [this message]
2020-03-04 9:11 ` Mel Gorman
2020-03-04 8:12 ` [PATCH 1/2] mm/compaction: Really limit compact_unevictable_allowed to 0…1 Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200304092539.tku4tuvlzvrmfnep@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=keescook@chromium.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=mgorman@techsingularity.net \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox