From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2EEEC3F2D1 for ; Wed, 4 Mar 2020 05:58:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6EB902166E for ; Wed, 4 Mar 2020 05:58:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6EB902166E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 088806B0003; Wed, 4 Mar 2020 00:58:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 03A9C6B0005; Wed, 4 Mar 2020 00:58:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E93006B0006; Wed, 4 Mar 2020 00:58:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0104.hostedemail.com [216.40.44.104]) by kanga.kvack.org (Postfix) with ESMTP id CDF646B0003 for ; Wed, 4 Mar 2020 00:58:01 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 949998248D52 for ; Wed, 4 Mar 2020 05:58:01 +0000 (UTC) X-FDA: 76556623962.11.stage61_4605161b85931 X-HE-Tag: stage61_4605161b85931 X-Filterd-Recvd-Size: 9250 Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Wed, 4 Mar 2020 05:58:01 +0000 (UTC) Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0245scw2146784 for ; Wed, 4 Mar 2020 00:58:00 -0500 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0a-001b2d01.pphosted.com with ESMTP id 2yhr4hepkq-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 04 Mar 2020 00:58:00 -0500 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 4 Mar 2020 05:57:58 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp03.uk.ibm.com (192.168.101.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 4 Mar 2020 05:57:54 -0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0245vsjc58654736 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 4 Mar 2020 05:57:54 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DD2ECAE06E; Wed, 4 Mar 2020 05:57:53 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 56277AE074; Wed, 4 Mar 2020 05:57:53 +0000 (GMT) Received: from linux.ibm.com (unknown [9.148.8.115]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Wed, 4 Mar 2020 05:57:53 +0000 (GMT) Date: Wed, 4 Mar 2020 07:57:51 +0200 From: Mike Rapoport To: Andrew Morton Cc: kbuild test robot , kbuild-all@lists.01.org, clang-built-linux@googlegroups.com, Linux Memory Management List , Mike Rapoport , Catalin Marinas Subject: Re: [linux-next:master 5946/5967] arch/arm64/mm/mmu.c:827:21: error: incompatible pointer types passing 'pgd_t *' to parameter of type 'p4d_t *' References: <202003031105.xcoYRe6W%lkp@intel.com> <20200303170314.9a6684e8191250275b1d8bdf@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200303170314.9a6684e8191250275b1d8bdf@linux-foundation.org> X-TM-AS-GCONF: 00 x-cbid: 20030405-0012-0000-0000-0000038CF8F8 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20030405-0013-0000-0000-000021C9B1FA Message-Id: <20200304055751.GA6202@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572 definitions=2020-03-03_08:2020-03-03,2020-03-03 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 mlxscore=0 phishscore=0 mlxlogscore=913 suspectscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 spamscore=0 adultscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2003040044 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 03, 2020 at 05:03:14PM -0800, Andrew Morton wrote: > On Tue, 3 Mar 2020 11:18:12 +0800 kbuild test robot wrote: > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > head: b56557c8e5210c25b008da636ef804b228967aa6 > > commit: 87d900aef3e229a891438c88debc533a8a1fa976 [5946/5967] arm/arm64: add support for folded p4d page tables > > config: arm64-allyesconfig (attached as .config) > > compiler: clang version 11.0.0 (git://gitmirror/llvm_project 211fb91f1067ecdf7c0b8a019bcf76554d813129) > > reproduce: > > # FIXME the reproduce steps for clang is not ready yet > > > > If you fix the issue, kindly add following tag > > Reported-by: kbuild test robot > > > > All errors (new ones prefixed by >>): > > (cc Mike & Catalin) > > Did we already fix this? > arm-arm64-add-support-for-folded-p4d-page-tables-fix-fix.patch > (http://lkml.kernel.org/r/20200302174553.GC4166275@arrakis.emea.arm.com) > seems to be fixing a different issue? It's the same issue. Besides, Anshuman updated the hot-remove series [1] to include p4d walk, so it should get fixed in arm64 tree. > > >> arch/arm64/mm/mmu.c:827:21: error: incompatible pointer types passing 'pgd_t *' to parameter of type 'p4d_t *' [-Werror,-Wincompatible-pointer-types] > > pudp = pud_offset(pgdp, addr); > > ^~~~ > > include/asm-generic/pgtable-nopud.h:45:40: note: passing argument to parameter 'p4d' here > > static inline pud_t *pud_offset(p4d_t *p4d, unsigned long address) > > ^ > > arch/arm64/mm/mmu.c:955:21: error: incompatible pointer types passing 'pgd_t *' to parameter of type 'p4d_t *' [-Werror,-Wincompatible-pointer-types] > > pudp = pud_offset(pgdp, addr); > > ^~~~ > > include/asm-generic/pgtable-nopud.h:45:40: note: passing argument to parameter 'p4d' here > > static inline pud_t *pud_offset(p4d_t *p4d, unsigned long address) > > ^ > > arch/arm64/mm/mmu.c:975:20: error: incompatible pointer types passing 'pgd_t *' to parameter of type 'p4d_t *' [-Werror,-Wincompatible-pointer-types] > > pudp = pud_offset(pgdp, 0UL); > > ^~~~ > > include/asm-generic/pgtable-nopud.h:45:40: note: passing argument to parameter 'p4d' here > > static inline pud_t *pud_offset(p4d_t *p4d, unsigned long address) > > ^ > > 3 errors generated. > > > > vim +827 arch/arm64/mm/mmu.c > > > > de323e651df4680 Anshuman Khandual 2020-02-13 818 > > de323e651df4680 Anshuman Khandual 2020-02-13 819 static void unmap_hotplug_pud_range(pgd_t *pgdp, unsigned long addr, > > de323e651df4680 Anshuman Khandual 2020-02-13 820 unsigned long end, bool free_mapped) > > de323e651df4680 Anshuman Khandual 2020-02-13 821 { > > de323e651df4680 Anshuman Khandual 2020-02-13 822 unsigned long next; > > de323e651df4680 Anshuman Khandual 2020-02-13 823 pud_t *pudp, pud; > > de323e651df4680 Anshuman Khandual 2020-02-13 824 > > de323e651df4680 Anshuman Khandual 2020-02-13 825 do { > > de323e651df4680 Anshuman Khandual 2020-02-13 826 next = pud_addr_end(addr, end); > > de323e651df4680 Anshuman Khandual 2020-02-13 @827 pudp = pud_offset(pgdp, addr); > > de323e651df4680 Anshuman Khandual 2020-02-13 828 pud = READ_ONCE(*pudp); > > de323e651df4680 Anshuman Khandual 2020-02-13 829 if (pud_none(pud)) > > de323e651df4680 Anshuman Khandual 2020-02-13 830 continue; > > de323e651df4680 Anshuman Khandual 2020-02-13 831 > > de323e651df4680 Anshuman Khandual 2020-02-13 832 WARN_ON(!pud_present(pud)); > > de323e651df4680 Anshuman Khandual 2020-02-13 833 if (pud_sect(pud)) { > > de323e651df4680 Anshuman Khandual 2020-02-13 834 pud_clear(pudp); > > de323e651df4680 Anshuman Khandual 2020-02-13 835 > > de323e651df4680 Anshuman Khandual 2020-02-13 836 /* > > de323e651df4680 Anshuman Khandual 2020-02-13 837 * One TLBI should be sufficient here as the PUD_SIZE > > de323e651df4680 Anshuman Khandual 2020-02-13 838 * range is mapped with a single block entry. > > de323e651df4680 Anshuman Khandual 2020-02-13 839 */ > > de323e651df4680 Anshuman Khandual 2020-02-13 840 flush_tlb_kernel_range(addr, addr + PAGE_SIZE); > > de323e651df4680 Anshuman Khandual 2020-02-13 841 if (free_mapped) > > de323e651df4680 Anshuman Khandual 2020-02-13 842 free_hotplug_page_range(pud_page(pud), > > de323e651df4680 Anshuman Khandual 2020-02-13 843 PUD_SIZE); > > de323e651df4680 Anshuman Khandual 2020-02-13 844 continue; > > de323e651df4680 Anshuman Khandual 2020-02-13 845 } > > de323e651df4680 Anshuman Khandual 2020-02-13 846 WARN_ON(!pud_table(pud)); > > de323e651df4680 Anshuman Khandual 2020-02-13 847 unmap_hotplug_pmd_range(pudp, addr, next, free_mapped); > > de323e651df4680 Anshuman Khandual 2020-02-13 848 } while (addr = next, addr < end); > > de323e651df4680 Anshuman Khandual 2020-02-13 849 } > > de323e651df4680 Anshuman Khandual 2020-02-13 850 > > > > :::::: The code at line 827 was first introduced by commit > > :::::: de323e651df46808081eeb17268054f77932a119 arm64/mm: Enable memory hot remove > > > > :::::: TO: Anshuman Khandual > > :::::: CC: Catalin Marinas > > > > --- > > 0-DAY CI Kernel Test Service, Intel Corporation > > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org -- Sincerely yours, Mike.