From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9FC6C3F2C6 for ; Wed, 4 Mar 2020 00:47:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A3A60206E2 for ; Wed, 4 Mar 2020 00:47:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="gZdLAc3W" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A3A60206E2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 51BA06B0003; Tue, 3 Mar 2020 19:47:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4CC1F6B0005; Tue, 3 Mar 2020 19:47:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36CCE6B0006; Tue, 3 Mar 2020 19:47:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0005.hostedemail.com [216.40.44.5]) by kanga.kvack.org (Postfix) with ESMTP id 1B43E6B0003 for ; Tue, 3 Mar 2020 19:47:02 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id DDBFF1AB72 for ; Wed, 4 Mar 2020 00:47:01 +0000 (UTC) X-FDA: 76555840242.04.crush47_778c03c5b8f44 X-HE-Tag: crush47_778c03c5b8f44 X-Filterd-Recvd-Size: 3541 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Wed, 4 Mar 2020 00:47:01 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1B8A8206D5; Wed, 4 Mar 2020 00:47:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583282820; bh=0+z7LmhvpR+/tgnsx78xZlf6Xtp1MPhvcA49EP7cCI8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gZdLAc3WmWRNXUh+LZD6fQ5PyaHfnkDYaLIo61uBfxx0u8qzP2R4ycU1QbdfHqXGt J+vL7N6dGXfyeVQAmdm1/Q/isaW3dosacn6BLaG1+8JZhMSJt2zoPP+NvcFbOtPJVU ReV40WQ5Vda3VQTcXJHT1TrT5dMjuCAkxdt0+EEg= Date: Tue, 3 Mar 2020 16:46:59 -0800 From: Andrew Morton To: Alex Shi Cc: cgroups@vger.kernel.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, yang.shi@linux.alibaba.com, willy@infradead.org, hannes@cmpxchg.org, lkp@intel.com, Michal Hocko , Vladimir Davydov , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v9 07/20] mm/lru: introduce TestClearPageLRU Message-Id: <20200303164659.b3a30ab9d68c9ed82299a29c@linux-foundation.org> In-Reply-To: <9cacdc21-9c1f-2a17-05cb-e9cf2959cef5@linux.alibaba.com> References: <1583146830-169516-1-git-send-email-alex.shi@linux.alibaba.com> <1583146830-169516-8-git-send-email-alex.shi@linux.alibaba.com> <20200302141144.b30abe0d89306fd387e13a92@linux-foundation.org> <9cacdc21-9c1f-2a17-05cb-e9cf2959cef5@linux.alibaba.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 3 Mar 2020 12:11:34 +0800 Alex Shi w= rote: >=20 >=20 > =E5=9C=A8 2020/3/3 =E4=B8=8A=E5=8D=886:11, Andrew Morton =E5=86=99=E9=81= =93: > >> - if (PageLRU(page)) { > >> + if (TestClearPageLRU(page)) { > >> lruvec =3D mem_cgroup_page_lruvec(page, pgdat); > >> - ClearPageLRU(page); > >> del_page_from_lru_list(page, lruvec, page_lru(page)); > >> } else > >=20 > > The code will now get exclusive access of the page->flags cacheline a= nd > > will dirty that cacheline, even for !PageLRU() pages. What is the > > performance impact of this? > >=20 >=20 > Hi Andrew, >=20 > Thanks a lot for comments! >=20 > I was tested the whole patchset with fengguang's case-lru-file-readtwic= e > https://git.kernel.org/pub/scm/linux/kernel/git/wfg/vm-scalability.git/ > which is most sensitive case on PageLRU I found. There are no clear per= formance > drop. >=20 > On this single patch, I just test the same case again, there is still n= o perf > drop. some data is here on my 96 threads machine: >=20 > no lock_dep w lock_dep and few other debug option > w this patch, 50.96MB/s 32.93MB/s > w/o this patch, 50.50MB/s 33.53MB/s >=20 >=20 Well, any difference would be small and the numbers did get a bit lower, albeit probably within the margin of error. But you know, if someone were to send a patch which micro-optimized some code by replacing 'TestClearXXX()' with `if PageXXX() ClearPageXXX()', I would happily merge it! Is this change essential to the overall patchset? If not, I'd be inclined to skip it?