From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A27A2C3F2D1 for ; Mon, 2 Mar 2020 14:03:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 612B52166E for ; Mon, 2 Mar 2020 14:03:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 612B52166E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0FD1F6B000E; Mon, 2 Mar 2020 09:03:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D50E6B0032; Mon, 2 Mar 2020 09:03:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F2BF56B0036; Mon, 2 Mar 2020 09:03:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0210.hostedemail.com [216.40.44.210]) by kanga.kvack.org (Postfix) with ESMTP id D8A9F6B000E for ; Mon, 2 Mar 2020 09:03:14 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 8622C8245571 for ; Mon, 2 Mar 2020 14:03:14 +0000 (UTC) X-FDA: 76550589108.29.stem89_7386c687bae55 X-HE-Tag: stem89_7386c687bae55 X-Filterd-Recvd-Size: 3530 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Mon, 2 Mar 2020 14:03:13 +0000 (UTC) Received: by mail-wr1-f68.google.com with SMTP id x7so12773037wrr.0 for ; Mon, 02 Mar 2020 06:03:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Z+UglYKv1Dwx2e9r/aDCnJWSItXjpOM15W1jiZYfefY=; b=XV/ABs1JFlKern44/29GSJLnzi3TzdD5zQsvx7GZFa3IomQSjCw4gpPGWGj/OCKncr k49vseo+22qbG7dSdwKwh7+D47GhNhfmiOyyinWC/3zy3+ow1VsHYvH3Wg9P496f6Ta4 fAK6E2DwCEIGu8MPJ7henAMIbzWuig0lF/ma+7QhSySX5bjkADGISFc1CLHH1klQe7w9 JJf12i7nJYeLU6DYsS5OIC027yFiVM2QqixKhRUxZkwaTurNxIs9YOVmS4wFGCdNwg1r X1RAyxT9+v69Xw+lffuV/XyI+vqdYKq2psLvHoU80KcGhhT85ZdVgA56EHQf9u/gDHk3 uKPQ== X-Gm-Message-State: APjAAAXpv1+lmQSnOkU1k6dUPvZYVR+BS2iW9VErhM5mRbtFOWPnU3/W 594D81x97mO4ZvZO5XmqiCM= X-Google-Smtp-Source: APXvYqzNlCJ57BpY/mMPxIq3KUzXka2/8lIi9TR4CaC2Gp0sGaxqiJbgkHNQYdBVahmYIfvhPV/tig== X-Received: by 2002:adf:fe0a:: with SMTP id n10mr23857788wrr.229.1583157792337; Mon, 02 Mar 2020 06:03:12 -0800 (PST) Received: from localhost (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id j4sm17021673wrr.0.2020.03.02.06.03.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2020 06:03:11 -0800 (PST) Date: Mon, 2 Mar 2020 15:03:09 +0100 From: Michal Hocko To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtio-dev@lists.oasis-open.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, Andrew Morton , "Michael S . Tsirkin" , "Rafael J. Wysocki" , Len Brown , linux-acpi@vger.kernel.org Subject: Re: [PATCH v1 01/11] ACPI: NUMA: export pxm_to_node Message-ID: <20200302140309.GM4380@dhcp22.suse.cz> References: <20200302134941.315212-1-david@redhat.com> <20200302134941.315212-2-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200302134941.315212-2-david@redhat.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 02-03-20 14:49:31, David Hildenbrand wrote: > Will be needed by virtio-mem to identify the node from a pxm. No objection to export the symbol. But it is almost always better to add the export in the patch that actually uses it. The intention is much more clear that way. > Acked-by: "Rafael J. Wysocki" > Cc: Len Brown > Cc: linux-acpi@vger.kernel.org > Signed-off-by: David Hildenbrand Acked-by: Michal Hocko # for the export > --- > drivers/acpi/numa/srat.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/acpi/numa/srat.c b/drivers/acpi/numa/srat.c > index 47b4969d9b93..5be5a977da1b 100644 > --- a/drivers/acpi/numa/srat.c > +++ b/drivers/acpi/numa/srat.c > @@ -35,6 +35,7 @@ int pxm_to_node(int pxm) > return NUMA_NO_NODE; > return pxm_to_node_map[pxm]; > } > +EXPORT_SYMBOL(pxm_to_node); > > int node_to_pxm(int node) > { > -- > 2.24.1 > -- Michal Hocko SUSE Labs