From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C35BC3F2C6 for ; Sun, 1 Mar 2020 03:18:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 13EF42192A for ; Sun, 1 Mar 2020 03:18:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="WQcmxm3z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 13EF42192A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 370066B0005; Sat, 29 Feb 2020 22:18:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 320B56B0006; Sat, 29 Feb 2020 22:18:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 23DC26B0007; Sat, 29 Feb 2020 22:18:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0142.hostedemail.com [216.40.44.142]) by kanga.kvack.org (Postfix) with ESMTP id 0976A6B0005 for ; Sat, 29 Feb 2020 22:18:11 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id C886A824556B for ; Sun, 1 Mar 2020 03:18:10 +0000 (UTC) X-FDA: 76545334740.03.fish64_643c072e38e16 X-HE-Tag: fish64_643c072e38e16 X-Filterd-Recvd-Size: 2928 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf10.hostedemail.com (Postfix) with ESMTP for ; Sun, 1 Mar 2020 03:18:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=47pI80o+nmPEpw9SqeWhAgVhlT0osz03Mg5aZK6ytPk=; b=WQcmxm3z4JUztW5f0xH1b2/A7e XCweIIsURg3QpMcQJ6yr/K9eYOQxWGYucchtbcfZ0RO/XbPQMO+8dzwMDRkK1TqRYnaqexIHGSXf7 siA/0lCGkjYlyufLbFSfV7mbpESUbIGqU9dM5cd/JpW+BDehqsFV7Z7kpJnTvXnyYgtVkzBYpni5P IvyBYj7il3FJgznj/93uf3+50XktwUp00dxvVKeFFMZbCFqTR0UME8pkMEDAX2DNAk85+TTOgYrpe LoOJ6s/kM+IfOBDbhRsZPdZrEfOG/iipZkC/m68J2xYVYE1pdgJ9DKVEDvGW/gS14TRVLb5I+fEhE Copb3ecA==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1j8F6t-0007D6-6A; Sun, 01 Mar 2020 03:17:43 +0000 Date: Sat, 29 Feb 2020 19:17:43 -0800 From: Matthew Wilcox To: chenqiwu Cc: akpm@linux-foundation.org, jgg@ziepe.ca, mhocko@suse.com, kirill.shutemov@linux.intel.com, vbabka@suse.cz, yang.shi@linux.alibaba.com, dan.j.williams@intel.com, jhubbard@nvidia.com, thellstrom@vmware.com, jrdr.linux@gmail.com, mathieu.desnoyers@efficios.com, rcampbell@nvidia.com, linux-mm@kvack.org, chenqiwu Subject: Re: [PATCH] mm: fix ambiguous comments for better code readability Message-ID: <20200301031743.GN29971@bombadil.infradead.org> References: <1582989949-9939-1-git-send-email-qiwuchen55@gmail.com> <20200229153123.GL29971@bombadil.infradead.org> <20200229154317.GA10067@cqw-OptiPlex-7050> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200229154317.GA10067@cqw-OptiPlex-7050> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Feb 29, 2020 at 11:43:17PM +0800, chenqiwu wrote: > On Sat, Feb 29, 2020 at 07:31:23AM -0800, Matthew Wilcox wrote: > > On Sat, Feb 29, 2020 at 11:25:49PM +0800, qiwuchen55@gmail.com wrote: > > > +++ b/mm/memory.c > > > @@ -1948,8 +1948,8 @@ static inline int remap_p4d_range(struct mm_struct *mm, pgd_t *pgd, > > > * remap_pfn_range - remap kernel memory to userspace > > > * @vma: user vma to map to > > > * @addr: target user address to start at > > > - * @pfn: physical address of kernel memory > > > - * @size: size of map area > > > + * @pfn: remap pfn converted by physical address of kernel memory > > > > I think that's actually worse. How about: > > > > * @pfn: Page Frame Number of memory. > > Hmm... I think "Page Frame Number of kernel memory" should be better. I disagree. We already know the memory is kernel memory from the first line. Repeating this information in the parameter description isn't particularly helpful.