From: Matthew Wilcox <willy@infradead.org>
To: chenqiwu <qiwuchen55@gmail.com>
Cc: akpm@linux-foundation.org, jgg@ziepe.ca, mhocko@suse.com,
kirill.shutemov@linux.intel.com, vbabka@suse.cz,
yang.shi@linux.alibaba.com, dan.j.williams@intel.com,
jhubbard@nvidia.com, thellstrom@vmware.com, jrdr.linux@gmail.com,
mathieu.desnoyers@efficios.com, rcampbell@nvidia.com,
linux-mm@kvack.org, chenqiwu <chenqiwu@xiaomi.com>
Subject: Re: [PATCH] mm: fix ambiguous comments for better code readability
Date: Sat, 29 Feb 2020 19:17:43 -0800 [thread overview]
Message-ID: <20200301031743.GN29971@bombadil.infradead.org> (raw)
In-Reply-To: <20200229154317.GA10067@cqw-OptiPlex-7050>
On Sat, Feb 29, 2020 at 11:43:17PM +0800, chenqiwu wrote:
> On Sat, Feb 29, 2020 at 07:31:23AM -0800, Matthew Wilcox wrote:
> > On Sat, Feb 29, 2020 at 11:25:49PM +0800, qiwuchen55@gmail.com wrote:
> > > +++ b/mm/memory.c
> > > @@ -1948,8 +1948,8 @@ static inline int remap_p4d_range(struct mm_struct *mm, pgd_t *pgd,
> > > * remap_pfn_range - remap kernel memory to userspace
> > > * @vma: user vma to map to
> > > * @addr: target user address to start at
> > > - * @pfn: physical address of kernel memory
> > > - * @size: size of map area
> > > + * @pfn: remap pfn converted by physical address of kernel memory
> >
> > I think that's actually worse. How about:
> >
> > * @pfn: Page Frame Number of memory.
>
> Hmm... I think "Page Frame Number of kernel memory" should be better.
I disagree. We already know the memory is kernel memory from the first
line. Repeating this information in the parameter description isn't
particularly helpful.
prev parent reply other threads:[~2020-03-01 3:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-29 15:25 qiwuchen55
2020-02-29 15:31 ` Matthew Wilcox
2020-02-29 15:43 ` chenqiwu
2020-03-01 3:17 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200301031743.GN29971@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=chenqiwu@xiaomi.com \
--cc=dan.j.williams@intel.com \
--cc=jgg@ziepe.ca \
--cc=jhubbard@nvidia.com \
--cc=jrdr.linux@gmail.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-mm@kvack.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhocko@suse.com \
--cc=qiwuchen55@gmail.com \
--cc=rcampbell@nvidia.com \
--cc=thellstrom@vmware.com \
--cc=vbabka@suse.cz \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox