From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80072C3F2C6 for ; Sat, 29 Feb 2020 15:43:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 40DC224699 for ; Sat, 29 Feb 2020 15:43:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R5O8eHSc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 40DC224699 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CF0FB6B0005; Sat, 29 Feb 2020 10:43:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CA1C46B0006; Sat, 29 Feb 2020 10:43:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE12A6B0007; Sat, 29 Feb 2020 10:43:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0199.hostedemail.com [216.40.44.199]) by kanga.kvack.org (Postfix) with ESMTP id A859D6B0005 for ; Sat, 29 Feb 2020 10:43:22 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 43D034DD7 for ; Sat, 29 Feb 2020 15:43:22 +0000 (UTC) X-FDA: 76543583844.01.bear62_49c09648d1b X-HE-Tag: bear62_49c09648d1b X-Filterd-Recvd-Size: 3977 Received: from mail-pj1-f66.google.com (mail-pj1-f66.google.com [209.85.216.66]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Sat, 29 Feb 2020 15:43:21 +0000 (UTC) Received: by mail-pj1-f66.google.com with SMTP id i11so2488082pju.3 for ; Sat, 29 Feb 2020 07:43:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=WikdfDFja4UUa4z1KUV+siMukHRcbMahI0eDc4jt9tE=; b=R5O8eHSclWoscE/xOeO04IccUEdjGemn61WToac9IMV1bLxHIB2k96KUyChP7NIIdA T0oFLlBV7Yi8rdshsYs+uoM4nOOKXzfj7EiyNkpn1lCBRBnTIiphb47amTOBF6tM/43f KnJUNuRMJ/VMzzLB4TjXBzZ6WM0L7gbsYEhcAdtCqg297Tqfkzc2yXoooDeMpGwyCKMx S/Tcz28FCNojS7UsEXwhnSaybJpV8UAAmtT+6hFFz313TgTBIo4GPS+ChEJi7BtZq6px iQGgox+4k0KQleGZDfBexSKrSJl4TxqEAZ3xvEvfywV+dC3MjpzwAmebNhn3iawb6jpA cVtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=WikdfDFja4UUa4z1KUV+siMukHRcbMahI0eDc4jt9tE=; b=R5pO2aTO4opC4zagiUKqOCJOewC8PffwDVZM2cE0VqupmLakW+CV6sDqLHvb/XocAN waPefaqq71xMn8sc/FuAxf3M0LTv6UWq1IpEOU8r+730yg+1iEJaTf07cP7Z47hrg//7 li8Wsr4iclR/VlMfyhInEYdx9Ho6geW+ZRrPmTvVwh5DlUOovhU3ejihIcYY4yMldfXd +NEyQ+vHoDkMVnoxSoh5lmuMssIYhPgQ5oBMkD/n3Ex7GVKklKa9nnRrck4YpgBZ5fjn ee+u2NZzbUcPVgsTPvP+UnyDg9gc3FVOXttVIKfwjkYhfGo/6NZmCAjcZhxYJHpYloG8 fjew== X-Gm-Message-State: APjAAAUk+CW/GPtzbnG5rrTsKNIyhXeLEocRc6V1a7Gi0DO3mYHJtxqk AdFKJEaVFY7ldUoC+cP9Owk= X-Google-Smtp-Source: APXvYqzMHErM+B4deASoexXlFouZinoQawymiLCNks68+m5DP+fZfXetXElJzhKYI07S4xBqBWZpow== X-Received: by 2002:a17:90a:1e63:: with SMTP id w90mr10674508pjw.36.1582991000917; Sat, 29 Feb 2020 07:43:20 -0800 (PST) Received: from localhost ([43.224.245.179]) by smtp.gmail.com with ESMTPSA id j12sm6579668pjd.4.2020.02.29.07.43.20 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Sat, 29 Feb 2020 07:43:20 -0800 (PST) Date: Sat, 29 Feb 2020 23:43:17 +0800 From: chenqiwu To: Matthew Wilcox Cc: akpm@linux-foundation.org, jgg@ziepe.ca, mhocko@suse.com, kirill.shutemov@linux.intel.com, vbabka@suse.cz, yang.shi@linux.alibaba.com, dan.j.williams@intel.com, jhubbard@nvidia.com, thellstrom@vmware.com, jrdr.linux@gmail.com, mathieu.desnoyers@efficios.com, rcampbell@nvidia.com, linux-mm@kvack.org, chenqiwu Subject: Re: [PATCH] mm: fix ambiguous comments for better code readability Message-ID: <20200229154317.GA10067@cqw-OptiPlex-7050> References: <1582989949-9939-1-git-send-email-qiwuchen55@gmail.com> <20200229153123.GL29971@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200229153123.GL29971@bombadil.infradead.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Feb 29, 2020 at 07:31:23AM -0800, Matthew Wilcox wrote: > On Sat, Feb 29, 2020 at 11:25:49PM +0800, qiwuchen55@gmail.com wrote: > > +++ b/mm/memory.c > > @@ -1948,8 +1948,8 @@ static inline int remap_p4d_range(struct mm_struct *mm, pgd_t *pgd, > > * remap_pfn_range - remap kernel memory to userspace > > * @vma: user vma to map to > > * @addr: target user address to start at > > - * @pfn: physical address of kernel memory > > - * @size: size of map area > > + * @pfn: remap pfn converted by physical address of kernel memory > > I think that's actually worse. How about: > > * @pfn: Page Frame Number of memory. Hmm... I think "Page Frame Number of kernel memory" should be better. >