From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F08DFC3F2C6 for ; Sat, 29 Feb 2020 15:31:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AC73C24680 for ; Sat, 29 Feb 2020 15:31:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="NronbLVZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC73C24680 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5A64E6B0005; Sat, 29 Feb 2020 10:31:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5574F6B0006; Sat, 29 Feb 2020 10:31:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46C906B0007; Sat, 29 Feb 2020 10:31:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0097.hostedemail.com [216.40.44.97]) by kanga.kvack.org (Postfix) with ESMTP id 2F7136B0005 for ; Sat, 29 Feb 2020 10:31:37 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id DA7A44DCD for ; Sat, 29 Feb 2020 15:31:36 +0000 (UTC) X-FDA: 76543554192.15.arch43_2b1859a4d1b38 X-HE-Tag: arch43_2b1859a4d1b38 X-Filterd-Recvd-Size: 2414 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Sat, 29 Feb 2020 15:31:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=QcQyggpAzHNDWvjdwonGb/UF9QmKujjyGLXrMkwnWkw=; b=NronbLVZUTA1vLU9x/R7Fzmm4u 2q78uyDaXvb1lGRz/dzfHCT0oq3F0ohoYUUVzjmhgIaMfrHT2F5F2mTvQiB1rDghWQoWLDRuIeLmG qnekxZYZ4vW0W9B/imLum5Lf7VYZZllZJ98CKIM1ITbsyPXdU6bFMgZgKP+SIv7HKMbSTwHTq00J8 hWl6IH08PXnI2LfVZ3qC7oD+Al4ETWfAmdYjEw6fYrm8fQVedQ9J7cLNKr9QRh37INmKApVXcO8yN JThD2tjPNBhboTTCCzkMgarXxnmBG96y9TGPDZQgE/lcZi8AIY7fg+FsOyI+7u2uW85/y/P4+oZH7 rqJbjrvg==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1j845L-00034G-6J; Sat, 29 Feb 2020 15:31:23 +0000 Date: Sat, 29 Feb 2020 07:31:23 -0800 From: Matthew Wilcox To: qiwuchen55@gmail.com Cc: akpm@linux-foundation.org, jgg@ziepe.ca, mhocko@suse.com, kirill.shutemov@linux.intel.com, vbabka@suse.cz, yang.shi@linux.alibaba.com, dan.j.williams@intel.com, jhubbard@nvidia.com, thellstrom@vmware.com, jrdr.linux@gmail.com, mathieu.desnoyers@efficios.com, rcampbell@nvidia.com, linux-mm@kvack.org, chenqiwu Subject: Re: [PATCH] mm: fix ambiguous comments for better code readability Message-ID: <20200229153123.GL29971@bombadil.infradead.org> References: <1582989949-9939-1-git-send-email-qiwuchen55@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1582989949-9939-1-git-send-email-qiwuchen55@gmail.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Feb 29, 2020 at 11:25:49PM +0800, qiwuchen55@gmail.com wrote: > +++ b/mm/memory.c > @@ -1948,8 +1948,8 @@ static inline int remap_p4d_range(struct mm_struct *mm, pgd_t *pgd, > * remap_pfn_range - remap kernel memory to userspace > * @vma: user vma to map to > * @addr: target user address to start at > - * @pfn: physical address of kernel memory > - * @size: size of map area > + * @pfn: remap pfn converted by physical address of kernel memory I think that's actually worse. How about: * @pfn: Page Frame Number of memory.