From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Arjun Roy <arjunroy.kdev@gmail.com>
Cc: davem@davemloft.net, akpm@linux-foundation.org,
linux-mm@kvack.org, arjunroy@google.com, soheil@google.com,
edumazet@google.com, geert@linux-m68k.org
Subject: Re: [PATCH mm 1/2] mm: Define pte_index as macro for x86
Date: Fri, 28 Feb 2020 11:57:19 +1100 [thread overview]
Message-ID: <20200228115719.01c1cf57@canb.auug.org.au> (raw)
In-Reply-To: <20200228004657.79943-1-arjunroy.kdev@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 800 bytes --]
Hi Arjun,
On Thu, 27 Feb 2020 16:46:56 -0800 Arjun Roy <arjunroy.kdev@gmail.com> wrote:
>
> diff --git a/arch/x86/include/asm/pgtable.h b/arch/x86/include/asm/pgtable.h
> index 7e118660bbd9..6658c04bce83 100644
> --- a/arch/x86/include/asm/pgtable.h
> +++ b/arch/x86/include/asm/pgtable.h
> @@ -823,6 +823,9 @@ static inline unsigned long pmd_index(unsigned long address)
> */
> #define mk_pte(page, pgprot) pfn_pte(page_to_pfn(page), (pgprot))
>
> +/* Degenerative definition so we can test if pte_index is defined for arch. */
> +#define pte_index pte_index
You should put this definition directly above the static inline function.
i.e.
#define pte_index pte_index
static inline unsigned long pte_index(unsigned long address)
...
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-02-28 0:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 0:46 Arjun Roy
2020-02-28 0:46 ` [PATCH mm 2/2] mm: vm_insert_pages() checks if pte_index defined Arjun Roy
2020-02-28 0:57 ` Stephen Rothwell [this message]
2020-02-28 3:04 ` [PATCH mm 1/2] mm: Define pte_index as macro for x86 Arjun Roy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200228115719.01c1cf57@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=akpm@linux-foundation.org \
--cc=arjunroy.kdev@gmail.com \
--cc=arjunroy@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geert@linux-m68k.org \
--cc=linux-mm@kvack.org \
--cc=soheil@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox