From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E174DC3F2D1 for ; Fri, 28 Feb 2020 10:21:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9EEB32469F for ; Fri, 28 Feb 2020 10:21:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UYW1mZna" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9EEB32469F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 461FF6B0005; Fri, 28 Feb 2020 05:21:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3EBCF6B0006; Fri, 28 Feb 2020 05:21:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 28C156B0007; Fri, 28 Feb 2020 05:21:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0219.hostedemail.com [216.40.44.219]) by kanga.kvack.org (Postfix) with ESMTP id 0E50E6B0005 for ; Fri, 28 Feb 2020 05:21:55 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id C6F383ABC for ; Fri, 28 Feb 2020 10:21:54 +0000 (UTC) X-FDA: 76539144948.07.swing23_2dc3b50c82818 X-HE-Tag: swing23_2dc3b50c82818 X-Filterd-Recvd-Size: 5539 Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Fri, 28 Feb 2020 10:21:54 +0000 (UTC) Received: by mail-pf1-f194.google.com with SMTP id 15so1488114pfo.9 for ; Fri, 28 Feb 2020 02:21:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=N6TCEHm0t+T1F6MJAG0DPrUF8K05yR9M0Jle2wO7TKU=; b=UYW1mZnaWynD7nepJ1HtYW4Enz/baJNzBmKlqs0DUhcTHB1Gdrinr8Tkh6yVLxkz1c nM8ODYkCrI1FKN2IansKH/XEFNs8EOZqvjBCArWc7Qut7UhhwUEWZNMDKF3YFqUQy6rQ KgVkh2xx3idcy9RW1IToS9PXbIJUhi8faQ1gGSIx0aoMtXnbelIxkxundwpcaFo3HZ14 MxHH/bMq4btSW+o8TVnk1eYFE4yy0Yu+YP75I3vHbGtzZI6Ymy0eRS9QWaib+gHeFvf3 Ny/ZLrFTLlbpOQZER44NCh5FqmbZfsdq//rTmHHuH/DtIFMq9HpU/5Wmxx5YD8+yHJr9 w1qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=N6TCEHm0t+T1F6MJAG0DPrUF8K05yR9M0Jle2wO7TKU=; b=TcdZs4rmn8byqKoQdFwFzj953I6p6XBw3bNi1yGtA7aUYYoGo4CTR4rKAthEswdyrq +vZpt4SatQ2HOSFZXBCUGHzM6RKzzhWHgrDzKtR+7zRPamOSw9lIcvc0sTyPqfRCzBJK jNJUiI+O0pyQ/9m64DYjh5zRY+s/2HsmokBEeDhvdi8VD/aar2Tq+f1WOLI9d/6G4ST5 kRoLPyxm+rfrhx5Vwtg5E/+g00D3WgmF/TYkkuFesFx4dDnOXpvPgMP6jQjMCroc7H+N KEdPwChhSQW7IH08wsq7qtAtin3RpeLebK7+4cYAfGzsS7lO8Kk+bMlOGEZtTep7kGvO +rTA== X-Gm-Message-State: APjAAAXM1X2TBei/Op7arv0DF313Y8pNhdP65l5KOdekFD8wuVzPgoAd XDV0Kc6Bg20+IiLPpm4IU2s= X-Google-Smtp-Source: APXvYqz3FN8m0n1/35+yyffg8jjeLhb5fWZ4W6y5h5Mth7w881chRhjMgNvBAvfyDn3uH7yV9LJZQQ== X-Received: by 2002:a62:e30f:: with SMTP id g15mr3699325pfh.124.1582885313244; Fri, 28 Feb 2020 02:21:53 -0800 (PST) Received: from ziqianlu-desktop.localdomain ([47.89.83.64]) by smtp.gmail.com with ESMTPSA id h3sm10552162pfo.102.2020.02.28.02.21.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2020 02:21:52 -0800 (PST) Date: Fri, 28 Feb 2020 18:21:45 +0800 From: Aaron Lu To: Joonsoo Kim Cc: Johannes Weiner , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko , Hugh Dickins , Minchan Kim , Vlastimil Babka , Mel Gorman , kernel-team@lge.com, Huang Ying Subject: Re: [PATCH v2 0/9] workingset protection/detection on the anonymous LRU list Message-ID: <20200228102145.GA675897@ziqianlu-desktop.localdomain> References: <1582175513-22601-1-git-send-email-iamjoonsoo.kim@lge.com> <20200226193942.30049da9c090b466bdc5ec23@linux-foundation.org> <20200227134806.GC39625@cmpxchg.org> <20200228032358.GB634650@ziqianlu-desktop.localdomain> <20200228040214.GA21040@js1304-desktop> <20200228055726.GA674737@ziqianlu-desktop.localdomain> <20200228065214.GA17349@js1304-desktop> <20200228091700.GA675567@ziqianlu-desktop.localdomain> <20200228095534.GA30796@js1304-desktop> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20200228095534.GA30796@js1304-desktop> Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 28, 2020 at 06:56:11PM +0900, Joonsoo Kim wrote: > On Fri, Feb 28, 2020 at 05:17:00PM +0800, Aaron Lu wrote: > > I think LKP robot has captured these two metrics but the report didn'= t > > show them, which means the number is about the same with or without > > patch #1. >=20 > robot showed these two metrics. See below. >=20 > 50190319 =B1 31% -35.7% 32291856 =B1 14% proc-vmstat.pswpin > 56429784 =B1 21% -42.6% 32386842 =B1 14% proc-vmstat.pswpout >=20 > pswpin/out are improved. Oh yes, I checked the vmstat part, while I should check proc-vmstat part...Sorry for missing this. >=20 > > > with patch #1. With large inactive list, we can easily find the > > > frequently referenced page and it would result in less swap in/out. > >=20 > > But with small inactive list, the pages that would be on inactive lis= t > > will stay on active list? I think the larger inactive list is mainly > > used to give the anon page a chance to be promoted to active list now > > that anon pages land on inactive list first, but on reclaim, I don't = see > > how a larger inactive list can cause fewer swap outs. >=20 > Point is that larger inactive LRU helps to find hot pages and these > hot pages leads to more cache hits. >=20 > When a cache hit happens, no swap outs happens. But, if a cache miss > happens, a new page is added to the LRU and then it causes the reclaim > and swap out. OK, I think I start to get your point. Your explanation makes sense. > > Forgive me for my curiosity and feel free to ignore my question as I > > don't want to waste your time on this. Your patchset looks a worthwhi= le > > thing to do, it's just the robot's report on patch1 seems er... >=20 > I appreciate your attention. Feel free to ask. :) Thanks a lot for your patience and nice explanation :-)