From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, FSL_HELO_FAKE,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D99F0C3F2C0 for ; Thu, 27 Feb 2020 21:54:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9B376246A1 for ; Thu, 27 Feb 2020 21:54:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="n2jzjZjw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9B376246A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3AAC76B0006; Thu, 27 Feb 2020 16:54:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 35A976B0007; Thu, 27 Feb 2020 16:54:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 270786B000A; Thu, 27 Feb 2020 16:54:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0177.hostedemail.com [216.40.44.177]) by kanga.kvack.org (Postfix) with ESMTP id 0BC7F6B0006 for ; Thu, 27 Feb 2020 16:54:26 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id CF7C998AC for ; Thu, 27 Feb 2020 21:54:25 +0000 (UTC) X-FDA: 76537261290.19.color09_43bae3d177628 X-HE-Tag: color09_43bae3d177628 X-Filterd-Recvd-Size: 3705 Received: from mail-pj1-f66.google.com (mail-pj1-f66.google.com [209.85.216.66]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Thu, 27 Feb 2020 21:54:25 +0000 (UTC) Received: by mail-pj1-f66.google.com with SMTP id a18so353332pjs.5 for ; Thu, 27 Feb 2020 13:54:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=aWQjRfD263PGFSWLYeye9fWJ9nZRg32z3KxjvyDZXrg=; b=n2jzjZjwu07thEgJQI35ioymXtHOwXo8lvcLzl9cFm9gu60A2HTlJznoMvuFXNQ8CV 36QsZg7nba3Am6zK2Id4yKIbCTcENut1Hg88TbIoSAtcn3/KjhnCDfZBfclCx/0LfLqE tnXsfFxhkwZ8yjF50zmXsoQUTD1pADesZWJLZsMBC6OCbgxlBpUnbwlY5ZJxOctBtYj0 L0W8ndd3c6JrSc8LvVIw/OHUHqqXAMuOkM9/qUKkb6RmfFtX3d5FvnVI/aeoA5wNj3sX V8okCYs+RH0Jq45Hir6Vt8ysQ44eTJNoV2PUjATwkO6w38gdoqrKcGzxAx9WHTsJ8aKM eODQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=aWQjRfD263PGFSWLYeye9fWJ9nZRg32z3KxjvyDZXrg=; b=syq/WoG9NyoE/tvKaa36fQU0KOe24zEtb24MH6IuuHHvnhU1G3TxoQg9wBhtX+R+Xz 0FmrbHlQgEkPh49qjQesRN9By1gIYb+TlQ8xndrYvHiBRBlOQPdyZCBhKj6ziEPOH0g+ GSJYNlznJb6OSldaDW6CIZWr9bUV5/sCYfWRy71CqFQvdCxnxPIh52ICNOvYXmbmmYEG DiWSi6iW8/mGvm0vx/haYSbXPrCmTIQUX6PAzGPVzV6AZwz3Y3PZ18XujKpTrPVkjL7+ yJ6pFqO9F5ZlW8w3vUTil1l/fO6vSlecx4h7W4kSm1py2LL8387ziManHJ3XP7WJTA+k gpSg== X-Gm-Message-State: APjAAAU2bJUN926H1AmcfZe48h2JXAjy7zVjVVLhV/RnyUSX2AefCukH fhiLEaPkl6B2UDXrnxiAmL4= X-Google-Smtp-Source: APXvYqy3UpbSi7+joaMTcmQ9dyBtZUaB+9jKUOQHTWEJ8rUv4VLKJ85g3UIczW/iruCNAotCfhXwOA== X-Received: by 2002:a17:902:444:: with SMTP id 62mr751742ple.209.1582840464193; Thu, 27 Feb 2020 13:54:24 -0800 (PST) Received: from google.com ([2620:15c:211:1:3e01:2939:5992:52da]) by smtp.gmail.com with ESMTPSA id t189sm8248302pfd.168.2020.02.27.13.54.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2020 13:54:23 -0800 (PST) Date: Thu, 27 Feb 2020 13:54:21 -0800 From: Minchan Kim To: Jules Irenge Cc: linux-kernel@vger.kernel.org, boqun.feng@gmail.com, Nitin Gupta , Sergey Senozhatsky , Andrew Morton , "open list:ZSMALLOC COMPRESSED SLAB MEMORY ALLOCATOR" Subject: Re: [PATCH 11/30] mm/zsmalloc: Add missing annotation for migrate_read_unlock() Message-ID: <20200227215421.GF215068@google.com> References: <0/30> <20200214204741.94112-1-jbi.octave@gmail.com> <20200214204741.94112-12-jbi.octave@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200214204741.94112-12-jbi.octave@gmail.com> User-Agent: Mutt/1.12.2 (2019-09-21) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000275, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 14, 2020 at 08:47:22PM +0000, Jules Irenge wrote: > Sparse reports a warning at migrate_read_unlock()() > > warning: context imbalance in migrate_read_unlock() - unexpected unlock > > The root cause is the missing annotation at migrate_read_unlock() > Add the missing __releases(&zspage->lock) annotation > > Signed-off-by: Jules Irenge Acked-by: Minchan Kim