From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, FSL_HELO_FAKE,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6D6EC3F2C0 for ; Thu, 27 Feb 2020 21:53:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A6B132469F for ; Thu, 27 Feb 2020 21:53:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MfQRdUQK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6B132469F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4BD4A6B0007; Thu, 27 Feb 2020 16:53:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 494CE6B0008; Thu, 27 Feb 2020 16:53:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3AA846B000A; Thu, 27 Feb 2020 16:53:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0136.hostedemail.com [216.40.44.136]) by kanga.kvack.org (Postfix) with ESMTP id 1F6046B0007 for ; Thu, 27 Feb 2020 16:53:04 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D3F4C181AEF10 for ; Thu, 27 Feb 2020 21:53:03 +0000 (UTC) X-FDA: 76537257846.28.bone93_37d04d8eb1712 X-HE-Tag: bone93_37d04d8eb1712 X-Filterd-Recvd-Size: 3704 Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Thu, 27 Feb 2020 21:53:03 +0000 (UTC) Received: by mail-pl1-f196.google.com with SMTP id a6so355170plm.3 for ; Thu, 27 Feb 2020 13:53:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=a8tz7pn6WYS1zSkKOSE65k1PsuDxpcFOThMRyfGsXzE=; b=MfQRdUQKcxxCrSC/WgIvIRxxrgpxV4pEVJPD3KSrjnKCyYy1DtH9YuIfwvrtkZ0rkk e4esIL0/td3cexwfwTcB+MjGYmUdyP2PENKFZHJXLbZ8P5sU2fQUWPMaAQNctsOmX/dn AGGGt2bWXaZ764Yldgf2q8QPMh3XvoJ+g+TgeVups/3GdaMKbXMo0HgCmxzqY1FTvObw ZS21j2nQUsw3IBJ/8oLQ0Ft4UE0vlIXUbL8hA6mFMLKAUbJi+Q1PvnSb6F7+9CIIG1yA n6d796AOcxL/rwXWH4RzSJPusTkXOFxW3IfwCAkvkkeZes83mGpiJDZkhS5JoMG+7JAG GIzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=a8tz7pn6WYS1zSkKOSE65k1PsuDxpcFOThMRyfGsXzE=; b=ENTZmr4hQ62QXWzBRDLkgcsW/wTCEdRqf5kNyNSvroYSY6cMDclZLqh724Ek6DPejM HPLwW2PTxGvMweJeWm4aRVhDV93uFYNxo9EtJ92+C03Bs2gx5tMdn52Yx0HDXVll4tfP Aqa6MzGX3OJHMOVbDjovAYipBL+nmXahNV+/3nAJ5n+SqXHUzzHc8lqSvpwEao4W1KVO fduCjrROThywaNV4zGEnATbbIydcQK7Sdw7TgAldEeYDwSpDwwVYdU5sBFIyZCMcrEWl VIr8NHEcLqaLEhAKUNwQwho40gWlxl/q+PGnQjoBFiUutgGP2VQFKsDobvPE+tKWwi+9 uiKA== X-Gm-Message-State: APjAAAW13wZZ7VTRVvaBuhiuAmEpCKnX93VIzGyrqgO49M67q08yzmaq tUxql+ncJMcTEDRn6/I6eSsMCut1 X-Google-Smtp-Source: APXvYqyBBSbhpwNl/y+B0CAz1QiXE9Xx9EaqVrkHv47pjZ+aPpztqa7IRVjA8W5qXes4DslEDVWfpw== X-Received: by 2002:a17:902:b718:: with SMTP id d24mr896192pls.80.1582840382216; Thu, 27 Feb 2020 13:53:02 -0800 (PST) Received: from google.com ([2620:15c:211:1:3e01:2939:5992:52da]) by smtp.gmail.com with ESMTPSA id d4sm7399843pjg.19.2020.02.27.13.53.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2020 13:53:01 -0800 (PST) Date: Thu, 27 Feb 2020 13:52:59 -0800 From: Minchan Kim To: Jules Irenge Cc: linux-kernel@vger.kernel.org, boqun.feng@gmail.com, Nitin Gupta , Sergey Senozhatsky , Andrew Morton , "open list:ZSMALLOC COMPRESSED SLAB MEMORY ALLOCATOR" Subject: Re: [PATCH 10/30] mm/zsmalloc: Add missing annotation for migrate_read_lock() Message-ID: <20200227215259.GC215068@google.com> References: <0/30> <20200214204741.94112-1-jbi.octave@gmail.com> <20200214204741.94112-11-jbi.octave@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200214204741.94112-11-jbi.octave@gmail.com> User-Agent: Mutt/1.12.2 (2019-09-21) X-Bogosity: Ham, tests=bogofilter, spamicity=0.019380, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 14, 2020 at 08:47:21PM +0000, Jules Irenge wrote: > Sparse reports a warning at migrate_read_lock()() > > warning: context imbalance in migrate_read_lock() - wrong count at exit > > The root cause is the missing annotation at migrate_read_lock() > Add the missing __acquires(&zspage->lock) annotation > > Signed-off-by: Jules Irenge Acked-by: Minchan Kim