From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EC99C11D3D for ; Thu, 27 Feb 2020 18:22:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 65A042469C for ; Thu, 27 Feb 2020 18:22:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 65A042469C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=Huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F23086B0007; Thu, 27 Feb 2020 13:22:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EA7E26B0008; Thu, 27 Feb 2020 13:22:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D6F856B000A; Thu, 27 Feb 2020 13:22:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0003.hostedemail.com [216.40.44.3]) by kanga.kvack.org (Postfix) with ESMTP id BC41A6B0007 for ; Thu, 27 Feb 2020 13:22:12 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 8BB24181AEF1A for ; Thu, 27 Feb 2020 18:22:12 +0000 (UTC) X-FDA: 76536726504.07.match04_6a84da3965a2e X-HE-Tag: match04_6a84da3965a2e X-Filterd-Recvd-Size: 6966 Received: from huawei.com (lhrrgout.huawei.com [185.176.76.210]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Thu, 27 Feb 2020 18:22:11 +0000 (UTC) Received: from LHREML710-CAH.china.huawei.com (unknown [172.18.7.106]) by Forcepoint Email with ESMTP id 99F00611DC9F15BD25C9; Thu, 27 Feb 2020 18:22:08 +0000 (GMT) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by LHREML710-CAH.china.huawei.com (10.201.108.33) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 27 Feb 2020 18:22:07 +0000 Received: from localhost (10.202.226.57) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 27 Feb 2020 18:22:07 +0000 Date: Thu, 27 Feb 2020 18:22:06 +0000 From: Jonathan Cameron To: Jean-Philippe Brucker CC: , , , , , , , , , , , , , , , , Subject: Re: [PATCH v4 00/26] iommu: Shared Virtual Addressing and SMMUv3 support Message-ID: <20200227182206.000075aa@Huawei.com> In-Reply-To: <20200224182401.353359-1-jean-philippe@linaro.org> References: <20200224182401.353359-1-jean-philippe@linaro.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.226.57] X-ClientProxiedBy: lhreml721-chm.china.huawei.com (10.201.108.72) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 24 Feb 2020 19:23:35 +0100 Jean-Philippe Brucker wrote: > Shared Virtual Addressing (SVA) allows to share process page tables with > devices using the IOMMU. Add a generic implementation of the IOMMU SVA > API, and add support in the Arm SMMUv3 driver. > > Previous versions of this patchset were sent over a year ago [1][2] but > we've made a lot of progress since then: > > * ATS support for SMMUv3 was merged in v5.2. > * The bind() and fault reporting APIs have been merged in v5.3. > * IOASID were added in v5.5. > * SMMUv3 PASID was added in v5.6, with some pending for v5.7. > > * The first user of the bind() API will be merged in v5.7 [3]. The zip > accelerator is also the first piece of hardware that I've been able to > use for testing (previous versions were developed with software models) > and I now have tools for evaluating SVA performance. Unfortunately I > still don't have hardware that supports ATS and PRI; the zip accelerator > uses stall. > > These are the remaining changes for SVA support in SMMUv3. Since v3 [1] > I fixed countless bugs and - I think - addressed everyone's comments. > Thanks to recent MMU notifier rework, iommu-sva.c is a lot more > straightforward. I'm still unhappy with the complicated locking in the > SMMUv3 driver resulting from patch 12 (Seize private ASID), but I > haven't found anything better. > > Please find all SVA patches on branches sva/current and sva/zip-devel at > https://jpbrucker.net/git/linux > > [1] https://lore.kernel.org/linux-iommu/20180920170046.20154-1-jean-philippe.brucker@arm.com/ > [2] https://lore.kernel.org/linux-iommu/20180511190641.23008-1-jean-philippe.brucker@arm.com/ > [3] https://lore.kernel.org/linux-iommu/1581407665-13504-1-git-send-email-zhangfei.gao@linaro.org/ Hi Jean-Phillippe. Great to see this progressing. Other than the few places I've commented it all looks good to me. Thanks, Jonathan > > Jean-Philippe Brucker (26): > mm/mmu_notifiers: pass private data down to alloc_notifier() > iommu/sva: Manage process address spaces > iommu: Add a page fault handler > iommu/sva: Search mm by PASID > iommu/iopf: Handle mm faults > iommu/sva: Register page fault handler > arm64: mm: Pin down ASIDs for sharing mm with devices > iommu/io-pgtable-arm: Move some definitions to a header > iommu/arm-smmu-v3: Manage ASIDs with xarray > arm64: cpufeature: Export symbol read_sanitised_ftr_reg() > iommu/arm-smmu-v3: Share process page tables > iommu/arm-smmu-v3: Seize private ASID > iommu/arm-smmu-v3: Add support for VHE > iommu/arm-smmu-v3: Enable broadcast TLB maintenance > iommu/arm-smmu-v3: Add SVA feature checking > iommu/arm-smmu-v3: Add dev_to_master() helper > iommu/arm-smmu-v3: Implement mm operations > iommu/arm-smmu-v3: Hook up ATC invalidation to mm ops > iommu/arm-smmu-v3: Add support for Hardware Translation Table Update > iommu/arm-smmu-v3: Maintain a SID->device structure > iommu/arm-smmu-v3: Ratelimit event dump > dt-bindings: document stall property for IOMMU masters > iommu/arm-smmu-v3: Add stall support for platform devices > PCI/ATS: Add PRI stubs > PCI/ATS: Export symbols of PRI functions > iommu/arm-smmu-v3: Add support for PRI > > .../devicetree/bindings/iommu/iommu.txt | 18 + > arch/arm64/include/asm/mmu.h | 1 + > arch/arm64/include/asm/mmu_context.h | 11 +- > arch/arm64/kernel/cpufeature.c | 1 + > arch/arm64/mm/context.c | 103 +- > drivers/iommu/Kconfig | 13 + > drivers/iommu/Makefile | 2 + > drivers/iommu/arm-smmu-v3.c | 1354 +++++++++++++++-- > drivers/iommu/io-pgfault.c | 533 +++++++ > drivers/iommu/io-pgtable-arm.c | 27 +- > drivers/iommu/io-pgtable-arm.h | 30 + > drivers/iommu/iommu-sva.c | 596 ++++++++ > drivers/iommu/iommu-sva.h | 64 + > drivers/iommu/iommu.c | 1 + > drivers/iommu/of_iommu.c | 5 +- > drivers/misc/sgi-gru/grutlbpurge.c | 4 +- > drivers/pci/ats.c | 4 + > include/linux/iommu.h | 73 + > include/linux/mmu_notifier.h | 10 +- > include/linux/pci-ats.h | 8 + > mm/mmu_notifier.c | 6 +- > 21 files changed, 2699 insertions(+), 165 deletions(-) > create mode 100644 drivers/iommu/io-pgfault.c > create mode 100644 drivers/iommu/io-pgtable-arm.h > create mode 100644 drivers/iommu/iommu-sva.c > create mode 100644 drivers/iommu/iommu-sva.h >