* [PATCH] selftest/lkdtm: Use local .gitignore
@ 2020-02-27 14:07 Christophe Leroy
2020-02-27 16:17 ` Kees Cook
0 siblings, 1 reply; 4+ messages in thread
From: Christophe Leroy @ 2020-02-27 14:07 UTC (permalink / raw)
To: Kees Cook, Shuah Khan
Cc: linux-kernel, linuxppc-dev, linux-mm, linux-kselftest
Commit 68ca0fd272da ("selftest/lkdtm: Don't pollute 'git status'")
introduced patterns for git to ignore files generated in
tools/testing/selftests/lkdtm/
Use local .gitignore file instead of using the root one.
Fixes: 68ca0fd272da ("selftest/lkdtm: Don't pollute 'git status'")
Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
---
.gitignore | 4 ----
tools/testing/selftests/lkdtm/.gitignore | 2 ++
2 files changed, 2 insertions(+), 4 deletions(-)
create mode 100644 tools/testing/selftests/lkdtm/.gitignore
diff --git a/.gitignore b/.gitignore
index bb05dce58f8e..b849a72d69d5 100644
--- a/.gitignore
+++ b/.gitignore
@@ -100,10 +100,6 @@ modules.order
/include/ksym/
/arch/*/include/generated/
-# Generated lkdtm tests
-/tools/testing/selftests/lkdtm/*.sh
-!/tools/testing/selftests/lkdtm/run.sh
-
# stgit generated dirs
patches-*
diff --git a/tools/testing/selftests/lkdtm/.gitignore b/tools/testing/selftests/lkdtm/.gitignore
new file mode 100644
index 000000000000..f26212605b6b
--- /dev/null
+++ b/tools/testing/selftests/lkdtm/.gitignore
@@ -0,0 +1,2 @@
+*.sh
+!run.sh
--
2.25.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] selftest/lkdtm: Use local .gitignore
2020-02-27 14:07 [PATCH] selftest/lkdtm: Use local .gitignore Christophe Leroy
@ 2020-02-27 16:17 ` Kees Cook
2020-02-27 16:45 ` Shuah Khan
0 siblings, 1 reply; 4+ messages in thread
From: Kees Cook @ 2020-02-27 16:17 UTC (permalink / raw)
To: Christophe Leroy
Cc: Shuah Khan, linux-kernel, linuxppc-dev, linux-mm, linux-kselftest
On Thu, Feb 27, 2020 at 02:07:10PM +0000, Christophe Leroy wrote:
> Commit 68ca0fd272da ("selftest/lkdtm: Don't pollute 'git status'")
> introduced patterns for git to ignore files generated in
> tools/testing/selftests/lkdtm/
>
> Use local .gitignore file instead of using the root one.
>
> Fixes: 68ca0fd272da ("selftest/lkdtm: Don't pollute 'git status'")
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
Yeah, that's better. Thanks!
Acked-by: Kees Cook <keescook@chromium.org>
-Kees
> ---
> .gitignore | 4 ----
> tools/testing/selftests/lkdtm/.gitignore | 2 ++
> 2 files changed, 2 insertions(+), 4 deletions(-)
> create mode 100644 tools/testing/selftests/lkdtm/.gitignore
>
> diff --git a/.gitignore b/.gitignore
> index bb05dce58f8e..b849a72d69d5 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -100,10 +100,6 @@ modules.order
> /include/ksym/
> /arch/*/include/generated/
>
> -# Generated lkdtm tests
> -/tools/testing/selftests/lkdtm/*.sh
> -!/tools/testing/selftests/lkdtm/run.sh
> -
> # stgit generated dirs
> patches-*
>
> diff --git a/tools/testing/selftests/lkdtm/.gitignore b/tools/testing/selftests/lkdtm/.gitignore
> new file mode 100644
> index 000000000000..f26212605b6b
> --- /dev/null
> +++ b/tools/testing/selftests/lkdtm/.gitignore
> @@ -0,0 +1,2 @@
> +*.sh
> +!run.sh
> --
> 2.25.0
>
--
Kees Cook
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] selftest/lkdtm: Use local .gitignore
2020-02-27 16:17 ` Kees Cook
@ 2020-02-27 16:45 ` Shuah Khan
2020-02-27 16:53 ` Christophe Leroy
0 siblings, 1 reply; 4+ messages in thread
From: Shuah Khan @ 2020-02-27 16:45 UTC (permalink / raw)
To: Kees Cook, Christophe Leroy
Cc: linux-kernel, linuxppc-dev, linux-mm, linux-kselftest, Shuah Khan
On 2/27/20 9:17 AM, Kees Cook wrote:
> On Thu, Feb 27, 2020 at 02:07:10PM +0000, Christophe Leroy wrote:
>> Commit 68ca0fd272da ("selftest/lkdtm: Don't pollute 'git status'")
>> introduced patterns for git to ignore files generated in
>> tools/testing/selftests/lkdtm/
>>
>> Use local .gitignore file instead of using the root one.
>>
>> Fixes: 68ca0fd272da ("selftest/lkdtm: Don't pollute 'git status'")
>> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
>
> Yeah, that's better. Thanks!
>
> Acked-by: Kees Cook <keescook@chromium.org>
>
I will apply it for next rc.
Thanks. I should have noticed the problem in the previous version.
It slipped by me. :(
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] selftest/lkdtm: Use local .gitignore
2020-02-27 16:45 ` Shuah Khan
@ 2020-02-27 16:53 ` Christophe Leroy
0 siblings, 0 replies; 4+ messages in thread
From: Christophe Leroy @ 2020-02-27 16:53 UTC (permalink / raw)
To: Shuah Khan, Kees Cook
Cc: linux-kernel, linuxppc-dev, linux-mm, linux-kselftest
Le 27/02/2020 à 17:45, Shuah Khan a écrit :
> On 2/27/20 9:17 AM, Kees Cook wrote:
>> On Thu, Feb 27, 2020 at 02:07:10PM +0000, Christophe Leroy wrote:
>>> Commit 68ca0fd272da ("selftest/lkdtm: Don't pollute 'git status'")
>>> introduced patterns for git to ignore files generated in
>>> tools/testing/selftests/lkdtm/
>>>
>>> Use local .gitignore file instead of using the root one.
>>>
>>> Fixes: 68ca0fd272da ("selftest/lkdtm: Don't pollute 'git status'")
>>> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
>>
>> Yeah, that's better. Thanks!
>>
>> Acked-by: Kees Cook <keescook@chromium.org>
>>
>
> I will apply it for next rc.
>
> Thanks. I should have noticed the problem in the previous version.
> It slipped by me. :(
>
My fault, I didn't even know we could have .gitignore in subdirectories.
Christophe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-27 16:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-27 14:07 [PATCH] selftest/lkdtm: Use local .gitignore Christophe Leroy
2020-02-27 16:17 ` Kees Cook
2020-02-27 16:45 ` Shuah Khan
2020-02-27 16:53 ` Christophe Leroy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox