From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E367C4BA24 for ; Thu, 27 Feb 2020 01:49:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DCD1A208E4 for ; Thu, 27 Feb 2020 01:49:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DCD1A208E4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sina.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8B95C6B0003; Wed, 26 Feb 2020 20:49:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 890556B0005; Wed, 26 Feb 2020 20:49:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A6BD6B0006; Wed, 26 Feb 2020 20:49:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0209.hostedemail.com [216.40.44.209]) by kanga.kvack.org (Postfix) with ESMTP id 5E8FB6B0003 for ; Wed, 26 Feb 2020 20:49:06 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 0E580824934B for ; Thu, 27 Feb 2020 01:49:06 +0000 (UTC) X-FDA: 76534223892.02.brush52_150d881fe155c X-HE-Tag: brush52_150d881fe155c X-Filterd-Recvd-Size: 2138 Received: from mail3-163.sinamail.sina.com.cn (mail3-163.sinamail.sina.com.cn [202.108.3.163]) by imf37.hostedemail.com (Postfix) with SMTP for ; Thu, 27 Feb 2020 01:49:04 +0000 (UTC) Received: from unknown (HELO localhost.localdomain)([114.246.226.1]) by sina.com with ESMTP id 5E57200C00006A0D; Thu, 27 Feb 2020 09:49:01 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 77429449283347 From: Hillf Danton To: Shakeel Butt Cc: Hillf Danton , Sultan Alsawaf , Mel Gorman , Dave Hansen , Andrew Morton , Linux MM , LKML Subject: Re: [PATCH] mm: Stop kswapd early when nothing's waiting for it to free pages Date: Thu, 27 Feb 2020 09:48:50 +0800 Message-Id: <20200227014850.1600-1-hdanton@sina.com> In-Reply-To: <20200226105137.9088-1-hdanton@sina.com> References: <20200219194006.GA3075@sultan-book.localdomain> <20200219200527.GF11847@dhcp22.suse.cz> <20200219204220.GA3488@sultan-book.localdomain> <20200219214513.GL3420@suse.de> <20200219224231.GA5190@sultan-book.localdomain> <20200220101945.GN3420@suse.de> <20200221042232.GA2197@sultan-book.localdomain> <20200221080737.GK20509@dhcp22.suse.cz> <20200221210824.GA3605@sultan-book.localdomain> <20200225090945.GJ22443@dhcp22.suse.cz> <20200226105137.9088-1-hdanton@sina.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.271819, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Shakeel=20 On Wed, 26 Feb 2020 09:04:34 -0800 Shakeel Butt wrote: >=20 > Thanks for finding this. I think we also need to check sc->may_swap as > well. Can you please send a signed-off patch? It may or maynot help > kswapd but I think this is needed. I think I cann't do it without clear ideas of your use cases and/or workloads, so it may be better that you send Andrew and Mel a patch with may_swap check folded in, and a concise description of what you observed as well in log message. Thanks Hillf