From: Andrew Morton <akpm@linux-foundation.org>
To: Mel Gorman <mgorman@techsingularity.net>
Cc: Michal Hocko <mhocko@suse.com>, Vlastimil Babka <vbabka@suse.cz>,
Ivan Babrou <ivan@cloudflare.com>,
Rik van Riel <riel@surriel.com>, Linux-MM <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/3] Limit runaway reclaim due to watermark boosting
Date: Tue, 25 Feb 2020 18:51:30 -0800 [thread overview]
Message-ID: <20200225185130.6a32a8a6920d11b4c098e90e@linux-foundation.org> (raw)
In-Reply-To: <20200225141534.5044-1-mgorman@techsingularity.net>
On Tue, 25 Feb 2020 14:15:31 +0000 Mel Gorman <mgorman@techsingularity.net> wrote:
> Ivan Babrou reported the following
http://lkml.kernel.org/r/CABWYdi1eOUD1DHORJxTsWPMT3BcZhz++xP1pXhT=x4SgxtgQZA@mail.gmail.com
is helpful.
> Commit 1c30844d2dfe ("mm: reclaim small amounts of memory when
> an external fragmentation event occurs") introduced undesired
> effects in our environment.
>
> * NUMA with 2 x CPU
> * 128GB of RAM
> * THP disabled
> * Upgraded from 4.19 to 5.4
>
> Before we saw free memory hover at around 1.4GB with no
> spikes. After the upgrade we saw some machines decide that they
> need a lot more than that, with frequent spikes above 10GB,
> often only on a single numa node.
>
> There have been a few reports recently that might be watermark boost
> related. Unfortunately, finding someone that can reproduce the problem
> and test a patch has been problematic. This series intends to limit
> potential damage only.
It's problematic that we don't understand what's happening. And these
palliatives can only reduce our ability to do that.
Rik seems to have the means to reproduce this (or something similar)
and it seems Ivan can test patches three weeks hence. So how about a
debug patch which will help figure out what's going on in there?
next prev parent reply other threads:[~2020-02-26 2:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 14:15 Mel Gorman
2020-02-25 14:15 ` [PATCH 1/3] mm, page_alloc: Disable boosted watermark based reclaim on low-memory systems Mel Gorman
2020-02-25 14:15 ` [PATCH 2/3] mm, page_alloc: Disable watermark boosting if THP is disabled at boot Mel Gorman
2020-02-26 1:32 ` David Rientjes
2020-02-26 8:07 ` Mel Gorman
2020-02-25 14:15 ` [PATCH 3/3] mm, vmscan: Do not reclaim for boosted watermarks at high priority Mel Gorman
2020-02-26 2:51 ` Andrew Morton [this message]
2020-02-26 8:04 ` [PATCH 0/3] Limit runaway reclaim due to watermark boosting Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200225185130.6a32a8a6920d11b4c098e90e@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ivan@cloudflare.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=riel@surriel.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox