From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D104C35DF5 for ; Tue, 25 Feb 2020 09:57:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C2C80218AC for ; Tue, 25 Feb 2020 09:57:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C2C80218AC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 44A676B0003; Tue, 25 Feb 2020 04:57:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3DD796B0005; Tue, 25 Feb 2020 04:57:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29BB16B0006; Tue, 25 Feb 2020 04:57:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0062.hostedemail.com [216.40.44.62]) by kanga.kvack.org (Postfix) with ESMTP id 0CE996B0003 for ; Tue, 25 Feb 2020 04:57:16 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B9F7B82499B9 for ; Tue, 25 Feb 2020 09:57:15 +0000 (UTC) X-FDA: 76528196430.08.rifle19_5c6f7326f165e X-HE-Tag: rifle19_5c6f7326f165e X-Filterd-Recvd-Size: 6155 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Tue, 25 Feb 2020 09:57:15 +0000 (UTC) Received: by mail-wm1-f67.google.com with SMTP id m10so1837864wmc.0 for ; Tue, 25 Feb 2020 01:57:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=uuJgO70EZWRPhcWgOVoAzvPvh7CsKKHz+o1Wbgf3edU=; b=H1r1Iv5VukakNX4cNcg9NzLUnUkR7ng04r0o0lV6/i94R9TpxEERCDVTnpYs5TJuPh +0uwWR7vvyey7f3UeqRWFXP33yODlghpddV7Kc0PioCyz8BrZ/na8Ui6ho1xccd2VWGj hmxZ8PgyLdOrHlF8sItk/AMFd4zhcWHptLMNVkNMcgmtm4rA3GSGyBdAvNw41Ryvdz5j 9Ry7gGdp2T4+pwwDXQ9GuzlkrbCnADHtK6s2GRzx0KwOoOFkWcL/YLwppJ3bBro+DyKx okXNHbiX9qPX/wBG/7EZoGHXTZNwc8e8y2ifMt+Zl4+LKnysMiJcuq6p4Y1G0MH8QWZC /Yvg== X-Gm-Message-State: APjAAAVcQl3Qi9jlT7gvA0yY6yxbFyVBE8IQLmnqIyneXcpDTYEumtph 0IY/lopE2eXX/Gji9boAe0w= X-Google-Smtp-Source: APXvYqzl5Wa2LVoqcT0D6oC/HDPcFd6i5oM20HvD8fnByWa2WpdGoHn6VdH8PJ8QE2f/XOXaXrRDAQ== X-Received: by 2002:a7b:c651:: with SMTP id q17mr4555596wmk.5.1582624634022; Tue, 25 Feb 2020 01:57:14 -0800 (PST) Received: from localhost (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id p26sm3317403wmc.24.2020.02.25.01.57.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Feb 2020 01:57:13 -0800 (PST) Date: Tue, 25 Feb 2020 10:57:13 +0100 From: Michal Hocko To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, richardw.yang@linux.intel.com, david@redhat.com, osalvador@suse.de, dan.j.williams@intel.com, rppt@linux.ibm.com, robin.murphy@arm.com Subject: Re: [PATCH v2 4/7] mm/sparse.c: only use subsection map in VMEMMAP case Message-ID: <20200225095713.GL22443@dhcp22.suse.cz> References: <20200220043316.19668-1-bhe@redhat.com> <20200220043316.19668-5-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200220043316.19668-5-bhe@redhat.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 20-02-20 12:33:13, Baoquan He wrote: > Currently, subsection map is used when SPARSEMEM is enabled, including > VMEMMAP case and !VMEMMAP case. However, subsection hotplug is not > supported at all in SPARSEMEM|!VMEMMAP case, subsection map is unnecessary > and misleading. Let's adjust code to only allow subsection map being > used in VMEMMAP case. This really needs more explanation I believe. What exactly happens if somebody tries to hotremove a part of the section with !VMEMMAP? I can see that clear_subsection_map returns 0 but that is not an error code. Besides that section_deactivate doesn't propagate the error upwards. /me stares into the code OK, I can see it now. It is relying on check_pfn_span to use the proper subsection granularity. This really begs for a comment in the code somewhere. > > Signed-off-by: Baoquan He > --- > include/linux/mmzone.h | 2 ++ > mm/sparse.c | 20 ++++++++++++++++++++ > 2 files changed, 22 insertions(+) > > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > index 462f6873905a..fc0de3a9a51e 100644 > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -1185,7 +1185,9 @@ static inline unsigned long section_nr_to_pfn(unsigned long sec) > #define SUBSECTION_ALIGN_DOWN(pfn) ((pfn) & PAGE_SUBSECTION_MASK) > > struct mem_section_usage { > +#ifdef CONFIG_SPARSEMEM_VMEMMAP > DECLARE_BITMAP(subsection_map, SUBSECTIONS_PER_SECTION); > +#endif > /* See declaration of similar field in struct zone */ > unsigned long pageblock_flags[0]; > }; > diff --git a/mm/sparse.c b/mm/sparse.c > index df857ee9330c..66c497d6a229 100644 > --- a/mm/sparse.c > +++ b/mm/sparse.c > @@ -209,6 +209,7 @@ static inline unsigned long first_present_section_nr(void) > return next_present_section_nr(-1); > } > > +#ifdef CONFIG_SPARSEMEM_VMEMMAP > static void subsection_mask_set(unsigned long *map, unsigned long pfn, > unsigned long nr_pages) > { > @@ -243,6 +244,11 @@ void __init subsection_map_init(unsigned long pfn, unsigned long nr_pages) > nr_pages -= pfns; > } > } > +#else > +void __init subsection_map_init(unsigned long pfn, unsigned long nr_pages) > +{ > +} > +#endif > > /* Record a memory area against a node. */ > void __init memory_present(int nid, unsigned long start, unsigned long end) > @@ -726,6 +732,7 @@ static void free_map_bootmem(struct page *memmap) > } > #endif /* CONFIG_SPARSEMEM_VMEMMAP */ > > +#ifdef CONFIG_SPARSEMEM_VMEMMAP > /** > * clear_subsection_map - Clear subsection map of one memory region > * > @@ -764,6 +771,12 @@ static int clear_subsection_map(unsigned long pfn, unsigned long nr_pages) > > return 1; > } > +#else > +static int clear_subsection_map(unsigned long pfn, unsigned long nr_pages) > +{ > + return 0; > +} > +#endif > > static void section_deactivate(unsigned long pfn, unsigned long nr_pages, > struct vmem_altmap *altmap) > @@ -820,6 +833,7 @@ static void section_deactivate(unsigned long pfn, unsigned long nr_pages, > ms->section_mem_map = (unsigned long)NULL; > } > > +#ifdef CONFIG_SPARSEMEM_VMEMMAP > /** > * fill_subsection_map - fill subsection map of a memory region > * @pfn - start pfn of the memory range > @@ -854,6 +868,12 @@ static int fill_subsection_map(unsigned long pfn, unsigned long nr_pages) > > return rc; > } > +#else > +static int fill_subsection_map(unsigned long pfn, unsigned long nr_pages) > +{ > + return 0; > +} > +#endif > > static struct page * __meminit section_activate(int nid, unsigned long pfn, > unsigned long nr_pages, struct vmem_altmap *altmap) > -- > 2.17.2 > -- Michal Hocko SUSE Labs