From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17D95C35669 for ; Sat, 22 Feb 2020 01:58:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CFF44206D7 for ; Sat, 22 Feb 2020 01:58:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="e+VXmCns" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CFF44206D7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 75BDD6B0003; Fri, 21 Feb 2020 20:58:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 70BD86B0006; Fri, 21 Feb 2020 20:58:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 648D46B0007; Fri, 21 Feb 2020 20:58:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0134.hostedemail.com [216.40.44.134]) by kanga.kvack.org (Postfix) with ESMTP id 4A0C76B0003 for ; Fri, 21 Feb 2020 20:58:14 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 10FD452A0 for ; Sat, 22 Feb 2020 01:58:14 +0000 (UTC) X-FDA: 76516102908.27.drop46_64f5314e31d2c X-HE-Tag: drop46_64f5314e31d2c X-Filterd-Recvd-Size: 2485 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Sat, 22 Feb 2020 01:58:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ccaOP4I4V78xPVEeTBxRAsgWcL2Yr/VIZyU3H+gqcWw=; b=e+VXmCns31Mhywppcb6YGHa2IA G2UpuoM3puJvkqZ8sh0bp4s4PJJGqeviK/7IBrB+eg7h70NtDQxuHGD+T9Mhre35dVCyJv6aU4QCL MGhqC0BnOoWtug3PxEniEBiccOGiC1xNKTImVdYrDkpx9YSLLddaODLrkakU9XO24SUsVGVgah3ke aZpeh5U8V4SwX/xx8Lh8TlbFNMZVjhWPWMaS56z1hOyREYDmG0Kaiy0h4d6ezYHmzBRXu5sTpJQyn /ArXzPk3E7arH/f4PxD/Ts0Oh+j6ev8ewZwIAnen0qlxKUHaIN+6CnhTNisTaSsRx1Zhd2n6xuWqI mNZb17dg==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1j5K3W-0002HE-LZ; Sat, 22 Feb 2020 01:58:10 +0000 Date: Fri, 21 Feb 2020 17:58:10 -0800 From: Matthew Wilcox To: John Hubbard Cc: linux-doc@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm: Add pagemap.h to the fine documentation Message-ID: <20200222015810.GI24185@bombadil.infradead.org> References: <20200221220045.24989-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.012241, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 21, 2020 at 02:35:52PM -0800, John Hubbard wrote: > On 2/21/20 2:00 PM, Matthew Wilcox wrote: > > From: "Matthew Wilcox (Oracle)" > > > > The documentation currently does not include the deathless prose > > Yea, documentation! > > > written to describe functions in pagemap.h because it's not included > > in any rst file. Fix up the mismatches between parameter names and the > > Maybe "Fix up some of the mismatches"? ...below: Nono, it fixes up all the _sphinx warnings_. Not our grand plan to rename the world ;-) > Anyway, I also ran 'make htmldocs' on this and poked around, and everything looks > like it should, so: > > Reviewed-by: John Hubbard Thanks! Jon, do you want to take this through your tree? I know I tagged it as mm, but this seems more like a doc patch than an mm patch.