From: Matthew Wilcox <willy@infradead.org>
To: John Hubbard <jhubbard@nvidia.com>
Cc: linux-doc@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm: Add pagemap.h to the fine documentation
Date: Fri, 21 Feb 2020 17:58:10 -0800 [thread overview]
Message-ID: <20200222015810.GI24185@bombadil.infradead.org> (raw)
In-Reply-To: <dca6710c-fecc-9d5d-4ada-6a437811bacc@nvidia.com>
On Fri, Feb 21, 2020 at 02:35:52PM -0800, John Hubbard wrote:
> On 2/21/20 2:00 PM, Matthew Wilcox wrote:
> > From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
> >
> > The documentation currently does not include the deathless prose
>
> Yea, documentation!
>
> > written to describe functions in pagemap.h because it's not included
> > in any rst file. Fix up the mismatches between parameter names and the
>
> Maybe "Fix up some of the mismatches"? ...below:
Nono, it fixes up all the _sphinx warnings_. Not our grand plan to rename
the world ;-)
> Anyway, I also ran 'make htmldocs' on this and poked around, and everything looks
> like it should, so:
>
> Reviewed-by: John Hubbard <jhubbard@nvidia.com>
Thanks! Jon, do you want to take this through your tree? I know I
tagged it as mm, but this seems more like a doc patch than an mm patch.
prev parent reply other threads:[~2020-02-22 1:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 22:00 Matthew Wilcox
2020-02-21 22:33 ` Zi Yan
2020-02-21 22:35 ` John Hubbard
2020-02-22 1:58 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200222015810.GI24185@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=jhubbard@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox