From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BEEAC35646 for ; Fri, 21 Feb 2020 18:22:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DC87820722 for ; Fri, 21 Feb 2020 18:22:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC87820722 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7C8016B0006; Fri, 21 Feb 2020 13:22:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7780F6B0007; Fri, 21 Feb 2020 13:22:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6DCAB6B0008; Fri, 21 Feb 2020 13:22:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0121.hostedemail.com [216.40.44.121]) by kanga.kvack.org (Postfix) with ESMTP id 596E36B0006 for ; Fri, 21 Feb 2020 13:22:05 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 19EE11EF2 for ; Fri, 21 Feb 2020 18:22:05 +0000 (UTC) X-FDA: 76514953410.09.scene02_2f37a3d5e105e X-HE-Tag: scene02_2f37a3d5e105e X-Filterd-Recvd-Size: 2065 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Fri, 21 Feb 2020 18:22:04 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Feb 2020 10:22:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,469,1574150400"; d="scan'208";a="349431134" Received: from iweiny-desk2.sc.intel.com ([10.3.52.157]) by fmsmga001.fm.intel.com with ESMTP; 21 Feb 2020 10:22:02 -0800 Date: Fri, 21 Feb 2020 10:22:02 -0800 From: Ira Weiny To: Sultan Alsawaf Cc: ;, Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm: Stop kswapd early when nothing's waiting for it to free pages Message-ID: <20200221182201.GB4462@iweiny-DESK2.sc.intel.com> References: <20200219182522.1960-1-sultan@kerneltoast.com> <20200221043052.3305-1-sultan@kerneltoast.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200221043052.3305-1-sultan@kerneltoast.com> User-Agent: Mutt/1.11.1 (2018-12-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.002433, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 20, 2020 at 08:30:52PM -0800, Sultan Alsawaf wrote: > From: Sultan Alsawaf [snip] > @@ -4640,9 +4647,12 @@ __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int order, > goto retry; > } > fail: > - warn_alloc(gfp_mask, ac->nodemask, > - "page allocation failure: order:%u", order); > got_pg: I have no insight into if this is masking a deeper problem or if this fixes something but doesn't the above result in 'fail' and 'got_pg' being the same label? Ira > + if (woke_kswapd) > + atomic_dec(&pgdat->kswapd_waiters); > + if (!page) > + warn_alloc(gfp_mask, ac->nodemask, > + "page allocation failure: order:%u", order); > return page; > } [snip]