From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD6A2C11D25 for ; Thu, 20 Feb 2020 22:02:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 71D6A208CD for ; Thu, 20 Feb 2020 22:02:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="1sM+flAa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 71D6A208CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1BC316B0005; Thu, 20 Feb 2020 17:02:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 145F86B0006; Thu, 20 Feb 2020 17:02:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00DC86B0007; Thu, 20 Feb 2020 17:02:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0057.hostedemail.com [216.40.44.57]) by kanga.kvack.org (Postfix) with ESMTP id DA37C6B0005 for ; Thu, 20 Feb 2020 17:02:41 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 9462F180AD82F for ; Thu, 20 Feb 2020 22:02:41 +0000 (UTC) X-FDA: 76511880522.17.army67_17741eae80859 X-HE-Tag: army67_17741eae80859 X-Filterd-Recvd-Size: 4215 Received: from mail-qk1-f196.google.com (mail-qk1-f196.google.com [209.85.222.196]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Thu, 20 Feb 2020 22:02:41 +0000 (UTC) Received: by mail-qk1-f196.google.com with SMTP id p7so19106qkh.10 for ; Thu, 20 Feb 2020 14:02:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Qs+LhNiBMIj9A7PLEkqadpwwdn4t7ZJVTcZjDGn03PM=; b=1sM+flAalAjdf9H+ABF4RBpnc7mgf/EB1PkQ3GIvPhatEPuYG/+kZZYytUx2breYo9 oBS4Cz3/NHUDHKrF1wClmlsU2wMQWRh9jUeUVFlKDnYU1XDy2DbPjMAN6/dFKk+WparC n2mnFSbEJsFPwZS1Vkfj9gnphTLnT9mqRYcdYb3mcnuK5c108UQ0b24WLrAoGSNFpyha iPLMyEc4PN5W+kfi2o4BOepzuEVVQ0MwF8HwWATiYKm8p4b2uSETdNaNTVOHwu7ULX5K 9cl6gc557oQYGhjYLQyYi1BtFt0PWyzSVcxVJSRFwVQAzbgf64CESMf7EXkdNMTvkNc/ T1Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Qs+LhNiBMIj9A7PLEkqadpwwdn4t7ZJVTcZjDGn03PM=; b=DlmccEEko484Y8chnM3Tio2p1ZbNTctkp1fIM/TsgWnH88BHNUz7UxOjUE7wIh7y5S Lt74mj4623XQfv68hMtrbzSho/3/MGGvnom8GC9JNg2xqoCc1/FVfJu49pPHvn66TS6n gmFyKtwFAhUCuci1aTFOUHhT5CMLOUj5WY+7pq33UESiUdTkzmIxb7dU97jQD7ewNhm+ 7z3byicOpoDjOZZSodcVMQIEo3ISoU3vl6U4XLxkk/rbGS5ze5Hx+ZBDVlbFIYh7kPay XDRUC2WUejW88eizR3g/5WSd4OLE2k8KbF1Yu84PEqn3LX0U1JzQjnjJG8PpwjYPo+w2 GO5A== X-Gm-Message-State: APjAAAXJ4bqRsBX5mg8Ym6a7seMGv0j4yDrNe2tSmiQsl+TV9nKZEALO RLkupy72KRzRhGIO5KHY+L1MfA== X-Google-Smtp-Source: APXvYqzeLjYnxMcLPrrXE8eCyXI/Ol0Il3CHL5hbzaE2ieHBb3/wY1MEQ7PKwGJEA0oW/FVjRgCOZA== X-Received: by 2002:a05:620a:1037:: with SMTP id a23mr29030822qkk.82.1582236160287; Thu, 20 Feb 2020 14:02:40 -0800 (PST) Received: from localhost ([2620:10d:c091:500::1:3504]) by smtp.gmail.com with ESMTPSA id e16sm518875qkl.32.2020.02.20.14.02.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Feb 2020 14:02:39 -0800 (PST) Date: Thu, 20 Feb 2020 17:02:38 -0500 From: Johannes Weiner To: Dan Schatzberg Cc: Jens Axboe , Tejun Heo , Li Zefan , Michal Hocko , Vladimir Davydov , Andrew Morton , Hugh Dickins , Roman Gushchin , Shakeel Butt , Chris Down , Yang Shi , Thomas Gleixner , "open list:BLOCK LAYER" , open list , "open list:CONTROL GROUP (CGROUP)" , "open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)" Subject: Re: [PATCH v3 3/3] loop: Charge i/o to mem and blk cg Message-ID: <20200220220238.GB68937@cmpxchg.org> References: <78060dcbf6578b4da6081f9f48b24b33726c5083.1582216295.git.schatzberg.dan@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <78060dcbf6578b4da6081f9f48b24b33726c5083.1582216295.git.schatzberg.dan@gmail.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 20, 2020 at 11:51:53AM -0500, Dan Schatzberg wrote: > The current code only associates with the existing blkcg when aio is > used to access the backing file. This patch covers all types of i/o to > the backing file and also associates the memcg so if the backing file is > on tmpfs, memory is charged appropriately. > > This patch also exports cgroup_get_e_css so it can be used by the loop > module. > > Signed-off-by: Dan Schatzberg The cgroup bits look good to me. Acked-by: Johannes Weiner