From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A267C11D00 for ; Fri, 21 Feb 2020 01:35:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 087872465D for ; Fri, 21 Feb 2020 01:35:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ai5nYwXa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 087872465D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 95CBF6B0005; Thu, 20 Feb 2020 20:35:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 90CD56B0006; Thu, 20 Feb 2020 20:35:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 821F36B0007; Thu, 20 Feb 2020 20:35:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0085.hostedemail.com [216.40.44.85]) by kanga.kvack.org (Postfix) with ESMTP id 67E9D6B0005 for ; Thu, 20 Feb 2020 20:35:03 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 3B551185D for ; Fri, 21 Feb 2020 01:35:03 +0000 (UTC) X-FDA: 76512415686.02.walk55_8361e809af235 X-HE-Tag: walk55_8361e809af235 X-Filterd-Recvd-Size: 2030 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Fri, 21 Feb 2020 01:35:02 +0000 (UTC) Received: from X1 (nat-ab2241.sltdut.senawave.net [162.218.216.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AFBB0222C4; Fri, 21 Feb 2020 01:35:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582248901; bh=6+kua7juze61hnWFLaQDyc1e9v2NQTjrUfu9hvGFRyk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Ai5nYwXadTcx45tmQqfDPNdBmHRKuYTs4LnnfYNiboalPV3Jca6/WcxKoJj2JYuxI g4fotCxzuvHLMU98eFfkibrEOkkdSdWmbbIc+L6X/bNyT+IFdh8xVWW/lundiaqE/C BsHvKxZvm/2YdG3EsD3JzNxKbYmAKfEbzrzH2iiw= Date: Thu, 20 Feb 2020 17:35:01 -0800 From: Andrew Morton To: Nathan Chancellor Cc: Catalin Marinas , linux-mm@kvack.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Nick Desaulniers Subject: Re: [PATCH v2] mm: kmemleak: Use address-of operator on section symbols Message-Id: <20200220173501.0de88326911e41b15e27b62f@linux-foundation.org> In-Reply-To: <20200220051551.44000-1-natechancellor@gmail.com> References: <20200220051551.44000-1-natechancellor@gmail.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 19 Feb 2020 22:15:51 -0700 Nathan Chancellor wrote: > Clang warns: > > These are not true arrays, they are linker defined symbols, which are > just addresses. Using the address of operator silences the warning and > does not change the resulting assembly with either clang/ld.lld or > gcc/ld (tested with diff + objdump -Dr). I guess you forgot to quote the clang output?